| Message ID | 1378441521-10050-4-git-send-email-spenser@gillilanding.com |
|---|---|
| State | Superseded |
| Headers | show |
Dear Spenser Gilliland, On Thu, 5 Sep 2013 23:25:17 -0500, Spenser Gilliland wrote: > > Signed-off-by: Spenser Gilliland <spenser@gillilanding.com> > --- In your patch 4/7, mesa3d still has a 'depends on BR2_PACKAGE_XORG7', so to me, it makes little sense to move it out of the package/x11r7/ directory. I believe we first need to make the libdrm package selectable without BR2_PACKAGE_XORG7 (which as explained in my review of patch 1/7, requires moving the pthread-stubs package outside of the BR2_PACKAGE_XORG7 condition), then we can make mesa3d selectable without BR2_PACKAGE_XORG7. Bottom-line: I believe it's too early to move mesa3d outside of package/x11r7/. Let's keep it in there for now, merge your current patches, and work on that as a followup step. Thanks! Thomas
Thomas, > In your patch 4/7, mesa3d still has a 'depends on BR2_PACKAGE_XORG7', > so to me, it makes little sense to move it out of the package/x11r7/ > directory. > > I believe we first need to make the libdrm package selectable without > BR2_PACKAGE_XORG7 (which as explained in my review of patch 1/7, > requires moving the pthread-stubs package outside of the > BR2_PACKAGE_XORG7 condition), then we can make mesa3d selectable > without BR2_PACKAGE_XORG7. > > Bottom-line: I believe it's too early to move mesa3d outside of > package/x11r7/. Let's keep it in there for now, merge your current > patches, and work on that as a followup step. > I'll add the move of pthread stubs (and any other required X libs) to this patch set. Thanks, Spenser
Dear Spenser Gilliland, On Wed, 11 Sep 2013 21:57:21 -0500, Spenser Gilliland wrote: > > Bottom-line: I believe it's too early to move mesa3d outside of > > package/x11r7/. Let's keep it in there for now, merge your current > > patches, and work on that as a followup step. > > I'll add the move of pthread stubs (and any other required X libs) to > this patch set. Great, thanks! Thomas
diff --git a/package/Config.in b/package/Config.in index a94cb62..0111771 100644 --- a/package/Config.in +++ b/package/Config.in @@ -278,6 +278,7 @@ source "package/lvm2/Config.in" source "package/mdadm/Config.in" source "package/media-ctl/Config.in" source "package/memtester/Config.in" +source "package/mesa3d/Config.in" source "package/minicom/Config.in" source "package/nanocom/Config.in" source "package/neard/Config.in" diff --git a/package/x11r7/mesa3d/Config.in b/package/mesa3d/Config.in similarity index 100% rename from package/x11r7/mesa3d/Config.in rename to package/mesa3d/Config.in diff --git a/package/x11r7/mesa3d/mesa3d-uclibc-locale.patch b/package/mesa3d/mesa3d-uclibc-locale.patch similarity index 100% rename from package/x11r7/mesa3d/mesa3d-uclibc-locale.patch rename to package/mesa3d/mesa3d-uclibc-locale.patch diff --git a/package/x11r7/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk similarity index 100% rename from package/x11r7/mesa3d/mesa3d.mk rename to package/mesa3d/mesa3d.mk diff --git a/package/x11r7/Config.in b/package/x11r7/Config.in index 205079c..d5d6e60 100644 --- a/package/x11r7/Config.in +++ b/package/x11r7/Config.in @@ -13,7 +13,6 @@ if BR2_PACKAGE_XORG7 endmenu menu "X11R7 Libraries" source package/x11r7/libxcb/Config.in - source package/x11r7/mesa3d/Config.in source package/x11r7/xcb-util/Config.in source package/x11r7/xcb-util-image/Config.in source package/x11r7/xcb-util-keysyms/Config.in
Signed-off-by: Spenser Gilliland <spenser@gillilanding.com> --- package/Config.in | 1 + package/{x11r7 => }/mesa3d/Config.in | 0 package/{x11r7 => }/mesa3d/mesa3d-uclibc-locale.patch | 0 package/{x11r7 => }/mesa3d/mesa3d.mk | 0 package/x11r7/Config.in | 1 - 5 files changed, 1 insertion(+), 1 deletion(-) rename package/{x11r7 => }/mesa3d/Config.in (100%) rename package/{x11r7 => }/mesa3d/mesa3d-uclibc-locale.patch (100%) rename package/{x11r7 => }/mesa3d/mesa3d.mk (100%)