| Message ID | 20090331132944.GB2332@yoda.jdub.homelinux.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Tue, 2009-03-31 at 09:29 -0400, Josh Boyer wrote: > Add a MAINTAINERS entry for the hypervisor virtual console support > used on IBM POWER servers. > > Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com> > --- > > diff --git a/MAINTAINERS b/MAINTAINERS > index c5f4e9d..387ad45 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2176,6 +2176,11 @@ W: http://www.ia64-linux.org/ > T: git kernel.org:/pub/scm/linux/kernel/git/aegl/linux-2.6.git > S: Maintained > > +IBM HYPERVISOR VIRTUAL CONSOLE > +P: Several > +L: linuxppc-dev@ozlabs.org > +S: Maintained > + > IBM MCA SCSI SUBSYSTEM DRIVER > P: Michael Lang > M: langa2@kph.uni-mainz.de I think this sort of entry should not be acceptable. Maintainers should have individual names and contact addresses. An exploder entry should be OK though. For instance, the DVB subsystem: DVB SUBSYSTEM AND DRIVERS P: LinuxTV.org Project M: linux-media@vger.kernel.org A list entry could be something like: P: Linux PCMCIA Team L: linux-pcmcia@lists.infradead.org
On Tue, 31 Mar 2009 14:10:23 -0700 Joe Perches <joe@perches.com> wrote: > On Tue, 2009-03-31 at 09:29 -0400, Josh Boyer wrote: > > Add a MAINTAINERS entry for the hypervisor virtual console support > > used on IBM POWER servers. > > > > Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com> > > --- > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index c5f4e9d..387ad45 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -2176,6 +2176,11 @@ W: http://www.ia64-linux.org/ > > T: git kernel.org:/pub/scm/linux/kernel/git/aegl/linux-2.6.git > > S: Maintained > > > > +IBM HYPERVISOR VIRTUAL CONSOLE > > +P: Several > > +L: linuxppc-dev@ozlabs.org > > +S: Maintained > > + > > IBM MCA SCSI SUBSYSTEM DRIVER > > P: Michael Lang > > M: langa2@kph.uni-mainz.de > > I think this sort of entry should not be acceptable. > Maintainers should have individual names and contact addresses. There isn't a maintainer. But people send patches to the wrong list, so the ppc guys (who use this driver) don't get to see them. That's a practical, real-world problem. We should have a fix for it. > An exploder entry should be OK though. > For instance, the DVB subsystem: > > DVB SUBSYSTEM AND DRIVERS > P: LinuxTV.org Project > M: linux-media@vger.kernel.org > > A list entry could be something like: > > P: Linux PCMCIA Team > L: linux-pcmcia@lists.infradead.org > I'm unclear on what the difference is here..
On Tue, 2009-03-31 at 14:22 -0700, Andrew Morton wrote: > On Tue, 31 Mar 2009 14:10:23 -0700 > Joe Perches <joe@perches.com> wrote: > > On Tue, 2009-03-31 at 09:29 -0400, Josh Boyer wrote: > > > Add a MAINTAINERS entry for the hypervisor virtual console support > > > used on IBM POWER servers. > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index c5f4e9d..387ad45 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -2176,6 +2176,11 @@ W: http://www.ia64-linux.org/ > > > T: git kernel.org:/pub/scm/linux/kernel/git/aegl/linux-2.6.git > > > S: Maintained > > > > > > +IBM HYPERVISOR VIRTUAL CONSOLE > > > +P: Several > > > +L: linuxppc-dev@ozlabs.org > > > +S: Maintained > > > + > > > IBM MCA SCSI SUBSYSTEM DRIVER > > > P: Michael Lang > > > M: langa2@kph.uni-mainz.de > > > > I think this sort of entry should not be acceptable. > > Maintainers should have individual names and contact addresses. > > There isn't a maintainer. > > But people send patches to the wrong list, so the ppc guys (who use > this driver) don't get to see them. > > That's a practical, real-world problem. We should have a fix for it. > > > An exploder entry should be OK though. > > For instance, the DVB subsystem: > > > > DVB SUBSYSTEM AND DRIVERS > > P: LinuxTV.org Project > > M: linux-media@vger.kernel.org > > > > A list entry could be something like: > > > > P: Linux PCMCIA Team > > L: linux-pcmcia@lists.infradead.org > > > > I'm unclear on what the difference is here.. I have no problem with the "L: list" entry. I think that's good. Along with some file matching pattern as well of course... I think the "P: Several" entry is not good. "Several" doesn't give any idea as to who actually does the work. If the "P:" entry is there at all, it should be the list name. Maybe "P: Linux PPC Development Team" or something similar.
On Tue, 2009-03-31 at 09:29 -0400, Josh Boyer wrote: > Add a MAINTAINERS entry for the hypervisor virtual console support > used on IBM POWER servers. > > Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com> > --- > > diff --git a/MAINTAINERS b/MAINTAINERS > index c5f4e9d..387ad45 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2176,6 +2176,11 @@ W: http://www.ia64-linux.org/ > T: git kernel.org:/pub/scm/linux/kernel/git/aegl/linux-2.6.git > S: Maintained > > +IBM HYPERVISOR VIRTUAL CONSOLE > +P: Several > +L: linuxppc-dev@ozlabs.org > +S: Maintained I don't think it's the "IBM" Hypervisor virtual console driver anymore. There are backends for Xen, Beat (Toshiba) and virtio. cheers
On Wed, Apr 01, 2009 at 10:44:00AM +1100, Michael Ellerman wrote: >On Tue, 2009-03-31 at 09:29 -0400, Josh Boyer wrote: >> Add a MAINTAINERS entry for the hypervisor virtual console support >> used on IBM POWER servers. >> >> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com> >> --- >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index c5f4e9d..387ad45 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -2176,6 +2176,11 @@ W: http://www.ia64-linux.org/ >> T: git kernel.org:/pub/scm/linux/kernel/git/aegl/linux-2.6.git >> S: Maintained >> >> +IBM HYPERVISOR VIRTUAL CONSOLE >> +P: Several >> +L: linuxppc-dev@ozlabs.org >> +S: Maintained > >I don't think it's the "IBM" Hypervisor virtual console driver anymore. >There are backends for Xen, Beat (Toshiba) and virtio. Was just going by the copyright in the files, and Documentation/powerpc/hvc* Also, if there are other backends, then is the list specified really correct? Perhaps it should just be linux-kernel. Guess that's the problem with trying to add a maintainers entry for something that doesn't really have a specific maintainer. josh
On Tue, Mar 31, 2009 at 02:40:58PM -0700, Joe Perches wrote: >On Tue, 2009-03-31 at 14:22 -0700, Andrew Morton wrote: >> On Tue, 31 Mar 2009 14:10:23 -0700 >> Joe Perches <joe@perches.com> wrote: >> > On Tue, 2009-03-31 at 09:29 -0400, Josh Boyer wrote: >> > > Add a MAINTAINERS entry for the hypervisor virtual console support >> > > used on IBM POWER servers. >> > > diff --git a/MAINTAINERS b/MAINTAINERS >> > > index c5f4e9d..387ad45 100644 >> > > --- a/MAINTAINERS >> > > +++ b/MAINTAINERS >> > > @@ -2176,6 +2176,11 @@ W: http://www.ia64-linux.org/ >> > > T: git kernel.org:/pub/scm/linux/kernel/git/aegl/linux-2.6.git >> > > S: Maintained >> > > >> > > +IBM HYPERVISOR VIRTUAL CONSOLE >> > > +P: Several >> > > +L: linuxppc-dev@ozlabs.org >> > > +S: Maintained >> > > + >> > > IBM MCA SCSI SUBSYSTEM DRIVER >> > > P: Michael Lang >> > > M: langa2@kph.uni-mainz.de >> > >> > I think this sort of entry should not be acceptable. >> > Maintainers should have individual names and contact addresses. >> >> There isn't a maintainer. >> >> But people send patches to the wrong list, so the ppc guys (who use >> this driver) don't get to see them. >> >> That's a practical, real-world problem. We should have a fix for it. >> >> > An exploder entry should be OK though. >> > For instance, the DVB subsystem: >> > >> > DVB SUBSYSTEM AND DRIVERS >> > P: LinuxTV.org Project >> > M: linux-media@vger.kernel.org >> > >> > A list entry could be something like: >> > >> > P: Linux PCMCIA Team >> > L: linux-pcmcia@lists.infradead.org >> > >> >> I'm unclear on what the difference is here.. > >I have no problem with the "L: list" entry. >I think that's good. Along with some file >matching pattern as well of course... > >I think the "P: Several" entry is not good. > >"Several" doesn't give any idea as to who >actually does the work. I copied that from something else in MAINTAINERS. I believe it was the KERNEL JANITORS entry. I guess I should have known better than to copy from that... >If the "P:" entry is there at all, it should >be the list name. > >Maybe "P: Linux PPC Development Team" or >something similar. Except that isn't right for the reasons Michael specified. josh
On Tue, 2009-03-31 at 19:50 -0400, Josh Boyer wrote: > On Wed, Apr 01, 2009 at 10:44:00AM +1100, Michael Ellerman wrote: > >On Tue, 2009-03-31 at 09:29 -0400, Josh Boyer wrote: > >> Add a MAINTAINERS entry for the hypervisor virtual console support > >> used on IBM POWER servers. > >> > >> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com> > >> --- > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index c5f4e9d..387ad45 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -2176,6 +2176,11 @@ W: http://www.ia64-linux.org/ > >> T: git kernel.org:/pub/scm/linux/kernel/git/aegl/linux-2.6.git > >> S: Maintained > >> > >> +IBM HYPERVISOR VIRTUAL CONSOLE > >> +P: Several > >> +L: linuxppc-dev@ozlabs.org > >> +S: Maintained > > > >I don't think it's the "IBM" Hypervisor virtual console driver anymore. > >There are backends for Xen, Beat (Toshiba) and virtio. > > Was just going by the copyright in the files, and Documentation/powerpc/hvc* > > Also, if there are other backends, then is the list specified really > correct? Perhaps it should just be linux-kernel. I would say /also/ linux-kernel. I think there's still more folks on linux-ppc who have looked at the driver than elsewhere, but cross-posting to lkml is probably good as well. cheers
diff --git a/MAINTAINERS b/MAINTAINERS index c5f4e9d..387ad45 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2176,6 +2176,11 @@ W: http://www.ia64-linux.org/ T: git kernel.org:/pub/scm/linux/kernel/git/aegl/linux-2.6.git S: Maintained +IBM HYPERVISOR VIRTUAL CONSOLE +P: Several +L: linuxppc-dev@ozlabs.org +S: Maintained + IBM MCA SCSI SUBSYSTEM DRIVER P: Michael Lang M: langa2@kph.uni-mainz.de
Add a MAINTAINERS entry for the hypervisor virtual console support used on IBM POWER servers. Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com> ---