| Message ID | ff9dd301d8c91ec02362d52494b4a640f370bc68.1377196394.git.luto@amacapital.net |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Andy Lutomirski <luto@amacapital.net> writes: > This is a security bug. > > The follow-up will fix nsproxy to discourage this type of issue from > happening again. Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com> > > Cc: stable@vger.kernel.org > Signed-off-by: Andy Lutomirski <luto@amacapital.net> > --- > net/core/scm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/scm.c b/net/core/scm.c > index 03795d0..b4da80b 100644 > --- a/net/core/scm.c > +++ b/net/core/scm.c > @@ -54,7 +54,7 @@ static __inline__ int scm_check_creds(struct ucred *creds) > return -EINVAL; > > if ((creds->pid == task_tgid_vnr(current) || > - ns_capable(current->nsproxy->pid_ns->user_ns, CAP_SYS_ADMIN)) && > + ns_capable(task_active_pid_ns(current)->user_ns, CAP_SYS_ADMIN)) && > ((uid_eq(uid, cred->uid) || uid_eq(uid, cred->euid) || > uid_eq(uid, cred->suid)) || nsown_capable(CAP_SETUID)) && > ((gid_eq(gid, cred->gid) || gid_eq(gid, cred->egid) || -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/scm.c b/net/core/scm.c index 03795d0..b4da80b 100644 --- a/net/core/scm.c +++ b/net/core/scm.c @@ -54,7 +54,7 @@ static __inline__ int scm_check_creds(struct ucred *creds) return -EINVAL; if ((creds->pid == task_tgid_vnr(current) || - ns_capable(current->nsproxy->pid_ns->user_ns, CAP_SYS_ADMIN)) && + ns_capable(task_active_pid_ns(current)->user_ns, CAP_SYS_ADMIN)) && ((uid_eq(uid, cred->uid) || uid_eq(uid, cred->euid) || uid_eq(uid, cred->suid)) || nsown_capable(CAP_SETUID)) && ((gid_eq(gid, cred->gid) || gid_eq(gid, cred->egid) ||
This is a security bug. The follow-up will fix nsproxy to discourage this type of issue from happening again. Cc: stable@vger.kernel.org Signed-off-by: Andy Lutomirski <luto@amacapital.net> --- net/core/scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)