mbox

[Raring,SRU,Pull,Request] Fix for LP#1201869

Message ID 521B6248.3040603@canonical.com
State New
Headers show

Pull-request

git://kernel.ubuntu.com/arges/ubuntu-raring.git lp1201869

Message

Chris J Arges Aug. 26, 2013, 2:12 p.m. UTC
Note: this is a resubmission; it has been retested for an extended
period of time. In addition I checked upstream patches around the code
for bugfixes.

SRU Justification:

Impact:
Users of the 3.5/3.8 kernel will have poor network throughput when using
OpenStack Neutron depending on their setup.

Fix:
These upstream patches are necessary to fix the issue:

2681128f0ced8aa4e66f221197e183cc16d244fe
8093315a91340bca52549044975d8c7f673b28a1
d0e2c55e7c940a3ee91e9e23a2683b593690f1e9
2efd32ee1b60b0b31404ca47c1ce70e5a5d24ebc
f45a5c267da35174e22cec955093a7513dc1623d

Testcase:
Setup OpenStack Neutron. Test throughput between internal and external
nodes.

The following explains an example vlan+namespace configuration:
Internal Node: [10.x.x.2]->eth2.123->br123->tap123->qr-123[10.x.x.1]
<--- netns: qrouter-123
netns: qrouter-123 --->
qg-234[10.x.y.1]->tap234->br234->eth2.234->External Node[10.x.y.2]
Where:
1) tap123+qr-123 and tap234+qg-234 are veth pairs
2) qr-123 and qg-234 reside inside the qrouter-123 namespace

--

The following changes since commit 29bbc65473021ae5629a8b168861dae188c9d685:

  UBUNTU: Ubuntu-3.8.0-30.43 (2013-08-21 14:33:56 -0500)

are available in the git repository at:

  git://kernel.ubuntu.com/arges/ubuntu-raring.git lp1201869

for you to fetch changes up to ac5deed73dad847054266ffc039def69308802c2:

  veth: fix NULL dereference in veth_dellink() (2013-08-21 16:43:44 -0500)

----------------------------------------------------------------
Eric Dumazet (5):
      veth: reduce stat overhead
      veth: extend device features
      veth: avoid a NULL deref in veth_stats_one
      veth: fix a NULL deref in netif_carrier_off
      veth: fix NULL dereference in veth_dellink()

 drivers/net/veth.c        |  177
++++++++++++++++++++++++---------------------
 include/linux/netdevice.h |    1 +
 2 files changed, 94 insertions(+), 84 deletions(-)

Comments

Tim Gardner Aug. 26, 2013, 2:55 p.m. UTC | #1

Luis Henriques Aug. 26, 2013, 4:36 p.m. UTC | #2
Chris J Arges <chris.j.arges@canonical.com> writes:

> Note: this is a resubmission; it has been retested for an extended
> period of time. In addition I checked upstream patches around the code
> for bugfixes.
>
> SRU Justification:
>
> Impact:
> Users of the 3.5/3.8 kernel will have poor network throughput when using
> OpenStack Neutron depending on their setup.
>
> Fix:
> These upstream patches are necessary to fix the issue:
>
> 2681128f0ced8aa4e66f221197e183cc16d244fe
> 8093315a91340bca52549044975d8c7f673b28a1
> d0e2c55e7c940a3ee91e9e23a2683b593690f1e9
> 2efd32ee1b60b0b31404ca47c1ce70e5a5d24ebc
> f45a5c267da35174e22cec955093a7513dc1623d
>
> Testcase:
> Setup OpenStack Neutron. Test throughput between internal and external
> nodes.
>
> The following explains an example vlan+namespace configuration:
> Internal Node: [10.x.x.2]->eth2.123->br123->tap123->qr-123[10.x.x.1]
> <--- netns: qrouter-123
> netns: qrouter-123 --->
> qg-234[10.x.y.1]->tap234->br234->eth2.234->External Node[10.x.y.2]
> Where:
> 1) tap123+qr-123 and tap234+qg-234 are veth pairs
> 2) qr-123 and qg-234 reside inside the qrouter-123 namespace
>
> --
>
> The following changes since commit 29bbc65473021ae5629a8b168861dae188c9d685:
>
>   UBUNTU: Ubuntu-3.8.0-30.43 (2013-08-21 14:33:56 -0500)
>
> are available in the git repository at:
>
>   git://kernel.ubuntu.com/arges/ubuntu-raring.git lp1201869
>
> for you to fetch changes up to ac5deed73dad847054266ffc039def69308802c2:
>
>   veth: fix NULL dereference in veth_dellink() (2013-08-21 16:43:44 -0500)
>
> ----------------------------------------------------------------
> Eric Dumazet (5):
>       veth: reduce stat overhead
>       veth: extend device features
>       veth: avoid a NULL deref in veth_stats_one
>       veth: fix a NULL deref in netif_carrier_off
>       veth: fix NULL dereference in veth_dellink()
>
>  drivers/net/veth.c        |  177
> ++++++++++++++++++++++++---------------------
>  include/linux/netdevice.h |    1 +
>  2 files changed, 94 insertions(+), 84 deletions(-)

Cheers,
Tim Gardner Aug. 26, 2013, 4:41 p.m. UTC | #3