| Message ID | 20090330090306.19172.94170.stgit@localhost.localdomain |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
Jesper Dangaard Brouer wrote, On 03/30/2009 11:03 AM: > Trival spelling fixes in RCU/rculist_nulls.txt. > > Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk> > --- > > Documentation/RCU/rculist_nulls.txt | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/RCU/rculist_nulls.txt b/Documentation/RCU/rculist_nulls.txt > index 239f542..ba075b2 100644 > --- a/Documentation/RCU/rculist_nulls.txt > +++ b/Documentation/RCU/rculist_nulls.txt > @@ -21,7 +21,7 @@ if (obj) { > /* > * Because a writer could delete object, and a writer could > * reuse these object before the RCU grace period, we > - * must check key after geting the reference on object > + * must check key after getting the reference on object > */ > if (obj->key != key) { // not the object we expected > put_ref(obj); > @@ -117,7 +117,7 @@ a race (some writer did a delete and/or a move of an object > to another chain) checking the final 'nulls' value if > the lookup met the end of chain. If final 'nulls' value > is not the slot number, then we must restart the lookup at > -the begining. If the object was moved to same chain, > +the beginning. If the object was moved to same chain, "by way":) +the beginning. If the object was moved to the same chain, Jarek P. > then the reader doesnt care : It might eventually > scan the list again without harm. > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 30 Mar 2009, Jarek Poplawski wrote: > Jesper Dangaard Brouer wrote, On 03/30/2009 11:03 AM: > >> Trival spelling fixes in RCU/rculist_nulls.txt. >> >> the lookup met the end of chain. If final 'nulls' value >> is not the slot number, then we must restart the lookup at >> -the begining. If the object was moved to same chain, >> +the beginning. If the object was moved to same chain, > > > "by way":) > +the beginning. If the object was moved to the same chain, *LOL* this was suppose to be a simple trivial insignificant fix, but you are right there is _also_ missing a "the" in the sentence ;-). Cheers, Jesper Brouer -- ------------------------------------------------------------------- MSc. Master of Computer Science Dept. of Computer Science, University of Copenhagen Author of http://www.adsl-optimizer.dk ------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Jesper Dangaard Brouer a écrit : > On Mon, 30 Mar 2009, Jarek Poplawski wrote: > >> Jesper Dangaard Brouer wrote, On 03/30/2009 11:03 AM: >> >>> Trival spelling fixes in RCU/rculist_nulls.txt. >>> >>> the lookup met the end of chain. If final 'nulls' value >>> is not the slot number, then we must restart the lookup at >>> -the begining. If the object was moved to same chain, >>> +the beginning. If the object was moved to same chain, >> >> >> "by way":) >> +the beginning. If the object was moved to the same chain, > > *LOL* this was suppose to be a simple trivial insignificant fix, but you > are right there is _also_ missing a "the" in the sentence ;-). > RCU is complex, and english too, at last for me ... I am very surprised you found so few errors in this file, that mixes these two parts :) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/RCU/rculist_nulls.txt b/Documentation/RCU/rculist_nulls.txt index 239f542..ba075b2 100644 --- a/Documentation/RCU/rculist_nulls.txt +++ b/Documentation/RCU/rculist_nulls.txt @@ -21,7 +21,7 @@ if (obj) { /* * Because a writer could delete object, and a writer could * reuse these object before the RCU grace period, we - * must check key after geting the reference on object + * must check key after getting the reference on object */ if (obj->key != key) { // not the object we expected put_ref(obj); @@ -117,7 +117,7 @@ a race (some writer did a delete and/or a move of an object to another chain) checking the final 'nulls' value if the lookup met the end of chain. If final 'nulls' value is not the slot number, then we must restart the lookup at -the begining. If the object was moved to same chain, +the beginning. If the object was moved to same chain, then the reader doesnt care : It might eventually scan the list again without harm.
Trival spelling fixes in RCU/rculist_nulls.txt. Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk> --- Documentation/RCU/rculist_nulls.txt | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html