| Message ID | 1375939511-7590-1-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Aug 08, 2013 at 10:55:11AM +0530, Sachin Kamat wrote: > __initdata should be placed between the variable name and equal > sign for the variable to be placed in the intended section. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Did this become a rule? Where? When?
On 15 August 2013 18:33, Wolfram Sang <wsa@the-dreams.de> wrote: > On Thu, Aug 08, 2013 at 10:55:11AM +0530, Sachin Kamat wrote: >> __initdata should be placed between the variable name and equal >> sign for the variable to be placed in the intended section. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > > Did this become a rule? Where? When? The correct usage has been documented in the header file init.h where the macros have been defined. I quote it below for reference: For initialized data: * You should insert __initdata between the variable name and equal * sign followed by value, e.g.: * * static int init_variable __initdata = 0; * static const char linux_logo[] __initconst = { 0x32, 0x36, ... };
On Thu, Aug 08, 2013 at 10:55:11AM +0530, Sachin Kamat wrote: > __initdata should be placed between the variable name and equal > sign for the variable to be placed in the intended section. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Applied to for-next, thanks!
diff --git a/Documentation/i2c/instantiating-devices b/Documentation/i2c/instantiating-devices index 2218266..c70e7a7 100644 --- a/Documentation/i2c/instantiating-devices +++ b/Documentation/i2c/instantiating-devices @@ -19,7 +19,7 @@ i2c_board_info which is registered by calling i2c_register_board_info(). Example (from omap2 h4): -static struct i2c_board_info __initdata h4_i2c_board_info[] = { +static struct i2c_board_info h4_i2c_board_info[] __initdata = { { I2C_BOARD_INFO("isp1301_omap", 0x2d), .irq = OMAP_GPIO_IRQ(125),
__initdata should be placed between the variable name and equal sign for the variable to be placed in the intended section. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- Documentation/i2c/instantiating-devices | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)