| Message ID | 51ECD203.9050507@asianux.com |
|---|---|
| State | New, archived |
| Headers | show |
Hello Maintainers: Please help check this patch whether OK or not, when you have time. Thanks. On 07/22/2013 02:32 PM, Chen Gang wrote: > 'rmls' is 'unsigned long', lpcr_rmls() will return negative number when > failure occurs, so it need a type cast for comparing. > > 'lpid' is 'unsigned long', kvmppc_alloc_lpid() return negative number > when failure occurs, so it need a type cast for comparing. > > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- > arch/powerpc/kvm/book3s_hv.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c > index 2efa9dd..7629cd3 100644 > --- a/arch/powerpc/kvm/book3s_hv.c > +++ b/arch/powerpc/kvm/book3s_hv.c > @@ -1809,7 +1809,7 @@ static int kvmppc_hv_setup_htab_rma(struct kvm_vcpu *vcpu) > rma_size <<= PAGE_SHIFT; > rmls = lpcr_rmls(rma_size); > err = -EINVAL; > - if (rmls < 0) { > + if ((long)rmls < 0) { > pr_err("KVM: Can't use RMA of 0x%lx bytes\n", rma_size); > goto out_srcu; > } > @@ -1874,7 +1874,7 @@ int kvmppc_core_init_vm(struct kvm *kvm) > /* Allocate the guest's logical partition ID */ > > lpid = kvmppc_alloc_lpid(); > - if (lpid < 0) > + if ((long)lpid < 0) > return -ENOMEM; > kvm->arch.lpid = lpid; > >
On Mon, Jul 22, 2013 at 02:32:35PM +0800, Chen Gang wrote: > 'rmls' is 'unsigned long', lpcr_rmls() will return negative number when > failure occurs, so it need a type cast for comparing. > > 'lpid' is 'unsigned long', kvmppc_alloc_lpid() return negative number > when failure occurs, so it need a type cast for comparing. > > > Signed-off-by: Chen Gang <gang.chen@asianux.com> Looks right, thanks. Acked-by: Paul Mackerras <paulus@samba.org> -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/05/2013 12:34 PM, Paul Mackerras wrote: > On Mon, Jul 22, 2013 at 02:32:35PM +0800, Chen Gang wrote: >> > 'rmls' is 'unsigned long', lpcr_rmls() will return negative number when >> > failure occurs, so it need a type cast for comparing. >> > >> > 'lpid' is 'unsigned long', kvmppc_alloc_lpid() return negative number >> > when failure occurs, so it need a type cast for comparing. >> > >> > >> > Signed-off-by: Chen Gang <gang.chen@asianux.com> > Looks right, thanks. > > Acked-by: Paul Mackerras <paulus@samba.org> > > Thank you very much.
On 05.08.2013, at 07:50, Chen Gang wrote: > On 08/05/2013 12:34 PM, Paul Mackerras wrote: >> On Mon, Jul 22, 2013 at 02:32:35PM +0800, Chen Gang wrote: >>>> 'rmls' is 'unsigned long', lpcr_rmls() will return negative number when >>>> failure occurs, so it need a type cast for comparing. >>>> >>>> 'lpid' is 'unsigned long', kvmppc_alloc_lpid() return negative number >>>> when failure occurs, so it need a type cast for comparing. >>>> >>>> >>>> Signed-off-by: Chen Gang <gang.chen@asianux.com> >> Looks right, thanks. >> >> Acked-by: Paul Mackerras <paulus@samba.org> >> >> > > Thank you very much. Thanks, applied to kvm-ppc-queue. Alex -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c index 2efa9dd..7629cd3 100644 --- a/arch/powerpc/kvm/book3s_hv.c +++ b/arch/powerpc/kvm/book3s_hv.c @@ -1809,7 +1809,7 @@ static int kvmppc_hv_setup_htab_rma(struct kvm_vcpu *vcpu) rma_size <<= PAGE_SHIFT; rmls = lpcr_rmls(rma_size); err = -EINVAL; - if (rmls < 0) { + if ((long)rmls < 0) { pr_err("KVM: Can't use RMA of 0x%lx bytes\n", rma_size); goto out_srcu; } @@ -1874,7 +1874,7 @@ int kvmppc_core_init_vm(struct kvm *kvm) /* Allocate the guest's logical partition ID */ lpid = kvmppc_alloc_lpid(); - if (lpid < 0) + if ((long)lpid < 0) return -ENOMEM; kvm->arch.lpid = lpid;
'rmls' is 'unsigned long', lpcr_rmls() will return negative number when failure occurs, so it need a type cast for comparing. 'lpid' is 'unsigned long', kvmppc_alloc_lpid() return negative number when failure occurs, so it need a type cast for comparing. Signed-off-by: Chen Gang <gang.chen@asianux.com> --- arch/powerpc/kvm/book3s_hv.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)