Message ID | 1375292522-7855-5-git-send-email-ttynkkynen@nvidia.com |
---|---|
State | Not Applicable, archived |
Headers | show |
On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: > The Tegra30 TRM recommends configuration of certain PHY parameters for > optimal quality. Program the following registers based on device tree > parameters: > > - UTMIP_XCVR_HSSLEW: HS slew rate control. > - UTMIP_HSSQUELCH_LEVEL: HS squelch detector level > - UTMIP_HSDISCON_LEVEL: HS disconnect detector level. > > These registers exist in Tegra20, but programming them hasn't been > necessary, so these parameters won't be set on Tegra20 to keep the > device trees backward compatible. > > Additionally, the UTMIP_XCVR_SETUP parameter can be set from fuses > instead of a software-programmed value, as the optimal value can > vary between invidual boards. The boolean property > nvidia,xcvr-setup-use-fuses can be used to enable this behaviour. > diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c > -#define UTMIP_XCVR_HSSLEW_MSB(x) (((x) & 0x7f) << 25) > +#define UTMIP_XCVR_HSSLEW(x) (((x) & 0x3) << 4) > +#define UTMIP_XCVR_HSSLEW_MSB(x) ((((x) & 0x1ff) >> 2) << 25) Similarly, may as well s/0x1ff/0x1fc/ there too. > @@ -262,7 +267,14 @@ static void utmip_pad_power_on(struct tegra_usb_phy *phy) > > if (utmip_pad_count++ == 0) { > val = readl(base + UTMIP_BIAS_CFG0); > - val &= ~(UTMIP_OTGPD | UTMIP_BIASPD); > + val &= ~(UTMIP_OTGPD | UTMIP_BIASPD | > + UTMIP_HSSQUELCH_LEVEL(~0) | > + UTMIP_HSDISCON_LEVEL(~0) | > + UTMIP_HSDISCON_LEVEL_MSB(~0)); > + > + val |= UTMIP_HSSQUELCH_LEVEL(config->hssquelch_level); > + val |= UTMIP_HSDISCON_LEVEL(config->hsdiscon_level); > + val |= UTMIP_HSDISCON_LEVEL_MSB(config->hsdiscon_level); > writel(val, base + UTMIP_BIAS_CFG0); > } > > @@ -432,11 +444,16 @@ static int utmi_phy_power_on(struct tegra_usb_phy *phy) > UTMIP_FORCE_PDZI_POWERDOWN | UTMIP_XCVR_LSBIAS_SEL | > UTMIP_XCVR_SETUP(~0) | UTMIP_XCVR_SETUP_MSB(~0) | > UTMIP_XCVR_LSFSLEW(~0) | UTMIP_XCVR_LSRSLEW(~0) | > - UTMIP_XCVR_HSSLEW_MSB(~0)); > - val |= UTMIP_XCVR_SETUP(config->xcvr_setup); > - val |= UTMIP_XCVR_SETUP_MSB(config->xcvr_setup); > + UTMIP_XCVR_HSSLEW(~0) | UTMIP_XCVR_HSSLEW_MSB(~0)); > + > + if (!config->xcvr_setup_use_fuses) { > + val |= UTMIP_XCVR_SETUP(config->xcvr_setup); > + val |= UTMIP_XCVR_SETUP_MSB(config->xcvr_setup); > + } > val |= UTMIP_XCVR_LSFSLEW(config->xcvr_lsfslew); > val |= UTMIP_XCVR_LSRSLEW(config->xcvr_lsrslew); > + val |= UTMIP_XCVR_HSSLEW(config->xcvr_hsslew); > + val |= UTMIP_XCVR_HSSLEW_MSB(config->xcvr_hsslew); Those two chunks end up clearing some fields in the register now even on earlier chips, whereas before their values were maintained when doing the read/modify/write. Yet, the commit description says the new fields aren't changed on Tegra20. Do the changes above need to be guarded by if (requires_extra_tuning_parameters)? (When I tested this series, I only tested Tegra30/114; I didn't any Tegra20 devices...) -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/02/2013 12:16 AM, Stephen Warren wrote: > On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: >> The Tegra30 TRM recommends configuration of certain PHY parameters for >> optimal quality. Program the following registers based on device tree >> parameters: >> >> - UTMIP_XCVR_HSSLEW: HS slew rate control. >> - UTMIP_HSSQUELCH_LEVEL: HS squelch detector level >> - UTMIP_HSDISCON_LEVEL: HS disconnect detector level. >> >> These registers exist in Tegra20, but programming them hasn't been >> necessary, so these parameters won't be set on Tegra20 to keep the >> device trees backward compatible. >> >> Additionally, the UTMIP_XCVR_SETUP parameter can be set from fuses >> instead of a software-programmed value, as the optimal value can >> vary between invidual boards. The boolean property >> nvidia,xcvr-setup-use-fuses can be used to enable this behaviour. > >> diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c > Those two chunks end up clearing some fields in the register now even on > earlier chips, whereas before their values were maintained when doing > the read/modify/write. Yet, the commit description says the new fields > aren't changed on Tegra20. Do the changes above need to be guarded by if > (requires_extra_tuning_parameters)? Oops, you are right. I overlooked that some of those fields have non-zero reset values. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c index 85ec70e..5a34b45 100644 --- a/drivers/usb/phy/phy-tegra-usb.c +++ b/drivers/usb/phy/phy-tegra-usb.c @@ -99,11 +99,15 @@ #define UTMIP_FORCE_PD2_POWERDOWN (1 << 16) #define UTMIP_FORCE_PDZI_POWERDOWN (1 << 18) #define UTMIP_XCVR_LSBIAS_SEL (1 << 21) -#define UTMIP_XCVR_HSSLEW_MSB(x) (((x) & 0x7f) << 25) +#define UTMIP_XCVR_HSSLEW(x) (((x) & 0x3) << 4) +#define UTMIP_XCVR_HSSLEW_MSB(x) ((((x) & 0x1ff) >> 2) << 25) #define UTMIP_BIAS_CFG0 0x80c #define UTMIP_OTGPD (1 << 11) #define UTMIP_BIASPD (1 << 10) +#define UTMIP_HSSQUELCH_LEVEL(x) (((x) & 0x3) << 0) +#define UTMIP_HSDISCON_LEVEL(x) (((x) & 0x3) << 2) +#define UTMIP_HSDISCON_LEVEL_MSB(x) ((((x) & 0x4) >> 2) << 24) #define UTMIP_HSRX_CFG0 0x810 #define UTMIP_ELASTIC_LIMIT(x) (((x) & 0x1f) << 10) @@ -255,6 +259,7 @@ static void utmip_pad_power_on(struct tegra_usb_phy *phy) { unsigned long val, flags; void __iomem *base = phy->pad_regs; + struct tegra_utmip_config *config = phy->config; clk_prepare_enable(phy->pad_clk); @@ -262,7 +267,14 @@ static void utmip_pad_power_on(struct tegra_usb_phy *phy) if (utmip_pad_count++ == 0) { val = readl(base + UTMIP_BIAS_CFG0); - val &= ~(UTMIP_OTGPD | UTMIP_BIASPD); + val &= ~(UTMIP_OTGPD | UTMIP_BIASPD | + UTMIP_HSSQUELCH_LEVEL(~0) | + UTMIP_HSDISCON_LEVEL(~0) | + UTMIP_HSDISCON_LEVEL_MSB(~0)); + + val |= UTMIP_HSSQUELCH_LEVEL(config->hssquelch_level); + val |= UTMIP_HSDISCON_LEVEL(config->hsdiscon_level); + val |= UTMIP_HSDISCON_LEVEL_MSB(config->hsdiscon_level); writel(val, base + UTMIP_BIAS_CFG0); } @@ -432,11 +444,16 @@ static int utmi_phy_power_on(struct tegra_usb_phy *phy) UTMIP_FORCE_PDZI_POWERDOWN | UTMIP_XCVR_LSBIAS_SEL | UTMIP_XCVR_SETUP(~0) | UTMIP_XCVR_SETUP_MSB(~0) | UTMIP_XCVR_LSFSLEW(~0) | UTMIP_XCVR_LSRSLEW(~0) | - UTMIP_XCVR_HSSLEW_MSB(~0)); - val |= UTMIP_XCVR_SETUP(config->xcvr_setup); - val |= UTMIP_XCVR_SETUP_MSB(config->xcvr_setup); + UTMIP_XCVR_HSSLEW(~0) | UTMIP_XCVR_HSSLEW_MSB(~0)); + + if (!config->xcvr_setup_use_fuses) { + val |= UTMIP_XCVR_SETUP(config->xcvr_setup); + val |= UTMIP_XCVR_SETUP_MSB(config->xcvr_setup); + } val |= UTMIP_XCVR_LSFSLEW(config->xcvr_lsfslew); val |= UTMIP_XCVR_LSRSLEW(config->xcvr_lsrslew); + val |= UTMIP_XCVR_HSSLEW(config->xcvr_hsslew); + val |= UTMIP_XCVR_HSSLEW_MSB(config->xcvr_hsslew); writel(val, base + UTMIP_XCVR_CFG0); val = readl(base + UTMIP_XCVR_CFG1); @@ -450,14 +467,14 @@ static int utmi_phy_power_on(struct tegra_usb_phy *phy) val |= UTMIP_BIAS_PDTRK_COUNT(0x5); writel(val, base + UTMIP_BIAS_CFG1); - if (phy->is_legacy_phy) { - val = readl(base + UTMIP_SPARE_CFG0); - if (phy->mode == USB_DR_MODE_PERIPHERAL) - val &= ~FUSE_SETUP_SEL; - else - val |= FUSE_SETUP_SEL; - writel(val, base + UTMIP_SPARE_CFG0); - } else { + val = readl(base + UTMIP_SPARE_CFG0); + if (config->xcvr_setup_use_fuses) + val |= FUSE_SETUP_SEL; + else + val &= ~FUSE_SETUP_SEL; + writel(val, base + UTMIP_SPARE_CFG0); + + if (!phy->is_legacy_phy) { val = readl(base + USB_SUSP_CTRL); val |= UTMIP_PHY_ENABLE; writel(val, base + USB_SUSP_CTRL); @@ -888,11 +905,6 @@ static int utmi_phy_probe(struct tegra_usb_phy *tegra_phy, if (err < 0) return err; - err = read_utmi_param(pdev, "nvidia,xcvr-setup", - &config->xcvr_setup); - if (err < 0) - return err; - err = read_utmi_param(pdev, "nvidia,xcvr-lsfslew", &config->xcvr_lsfslew); if (err < 0) @@ -903,6 +915,33 @@ static int utmi_phy_probe(struct tegra_usb_phy *tegra_phy, if (err < 0) return err; + if (tegra_phy->soc_config->requires_extra_tuning_parameters) { + err = read_utmi_param(pdev, "nvidia,xcvr-hsslew", + &config->xcvr_hsslew); + if (err < 0) + return err; + + err = read_utmi_param(pdev, "nvidia,hssquelch-level", + &config->hssquelch_level); + if (err < 0) + return err; + + err = read_utmi_param(pdev, "nvidia,hsdiscon-level", + &config->hsdiscon_level); + if (err < 0) + return err; + } + + config->xcvr_setup_use_fuses = of_property_read_bool( + pdev->dev.of_node, "nvidia,xcvr-setup-use-fuses"); + + if (!config->xcvr_setup_use_fuses) { + err = read_utmi_param(pdev, "nvidia,xcvr-setup", + &config->xcvr_setup); + if (err < 0) + return err; + } + return 0; } diff --git a/include/linux/usb/tegra_usb_phy.h b/include/linux/usb/tegra_usb_phy.h index d3a63c3..1de16c3 100644 --- a/include/linux/usb/tegra_usb_phy.h +++ b/include/linux/usb/tegra_usb_phy.h @@ -41,9 +41,13 @@ struct tegra_utmip_config { u8 elastic_limit; u8 idle_wait_delay; u8 term_range_adj; + bool xcvr_setup_use_fuses; u8 xcvr_setup; u8 xcvr_lsfslew; u8 xcvr_lsrslew; + u8 xcvr_hsslew; + u8 hssquelch_level; + u8 hsdiscon_level; }; enum tegra_usb_phy_port_speed {
The Tegra30 TRM recommends configuration of certain PHY parameters for optimal quality. Program the following registers based on device tree parameters: - UTMIP_XCVR_HSSLEW: HS slew rate control. - UTMIP_HSSQUELCH_LEVEL: HS squelch detector level - UTMIP_HSDISCON_LEVEL: HS disconnect detector level. These registers exist in Tegra20, but programming them hasn't been necessary, so these parameters won't be set on Tegra20 to keep the device trees backward compatible. Additionally, the UTMIP_XCVR_SETUP parameter can be set from fuses instead of a software-programmed value, as the optimal value can vary between invidual boards. The boolean property nvidia,xcvr-setup-use-fuses can be used to enable this behaviour. Signed-off-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com> --- drivers/usb/phy/phy-tegra-usb.c | 75 +++++++++++++++++++++++++++++---------- include/linux/usb/tegra_usb_phy.h | 4 +++ 2 files changed, 61 insertions(+), 18 deletions(-)