| Message ID | 20090320115838.GA26371@orion |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Alexander Beregalov <a.beregalov@gmail.com> Date: Fri, 20 Mar 2009 14:58:38 +0300 > net/phonet/pep.c: In function 'pipe_rcv_status': > net/phonet/pep.c:262: error: lvalue required as left operand of assignment > > Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com> What platform hits this problem? I think that platform's atomic_add() implementation should be fixed instead. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2009/3/22 David Miller <davem@davemloft.net>: > From: Alexander Beregalov <a.beregalov@gmail.com> > Date: Fri, 20 Mar 2009 14:58:38 +0300 > >> net/phonet/pep.c: In function 'pipe_rcv_status': >> net/phonet/pep.c:262: error: lvalue required as left operand of assignment >> >> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com> > > What platform hits this problem? > > I think that platform's atomic_add() implementation should > be fixed instead. It is parisc, CC added. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/phonet/pep.c b/net/phonet/pep.c index 8ad2b53..9a1aefa 100644 --- a/net/phonet/pep.c +++ b/net/phonet/pep.c @@ -259,7 +259,8 @@ static int pipe_rcv_status(struct sock *sk, struct sk_buff *skb) case PN_PEP_IND_ID_MCFC_GRANT_CREDITS: if (pn->tx_fc != PN_MULTI_CREDIT_FLOW_CONTROL) break; - atomic_add(wake = hdr->data[4], &pn->tx_credits); + wake = hdr->data[4]; + atomic_add(wake, &pn->tx_credits); break; default:
net/phonet/pep.c: In function 'pipe_rcv_status': net/phonet/pep.c:262: error: lvalue required as left operand of assignment Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com> --- net/phonet/pep.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html