| Message ID | 1374324735-2286-3-git-send-email-gustavo@zacarias.com.ar |
|---|---|
| State | Accepted |
| Headers | show |
Gustavo, All, On 2013-07-20 09:52 -0300, Gustavo Zacarias spake thusly: > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > --- > package/uclibc/Config.in | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in > index 90aae90..f9c4956 100644 > --- a/package/uclibc/Config.in > +++ b/package/uclibc/Config.in > @@ -104,6 +104,7 @@ choice > > config BR2_PTHREADS > bool "linuxthreads" > + depends on !BR2_bfin > depends on !BR2_xtensa > select BR2_TOOLCHAIN_HAS_THREADS > > @@ -115,9 +116,10 @@ choice > bool "Native POSIX Threading (NPTL)" > select BR2_TOOLCHAIN_HAS_THREADS > depends on !BR2_x86_i386 > + depends on !BR2_arc > depends on !BR2_avr32 > + depends on !BR2_bfin > depends on !BR2_xtensa > - depends on !BR2_arc While at re-ordering, you could have also reorderd x86_i386. Note this in the commit log, such as: trivial options re-rodering at the same time. Although I would prefer you not mix cosmetics with actual changes. Regards, Yann E. MORIN.
Dear Gustavo Zacarias, On Sat, 20 Jul 2013 09:52:08 -0300, Gustavo Zacarias wrote: > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > --- > package/uclibc/Config.in | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in > index 90aae90..f9c4956 100644 > --- a/package/uclibc/Config.in > +++ b/package/uclibc/Config.in > @@ -104,6 +104,7 @@ choice > > config BR2_PTHREADS > bool "linuxthreads" > + depends on !BR2_bfin > depends on !BR2_xtensa > select BR2_TOOLCHAIN_HAS_THREADS > > @@ -115,9 +116,10 @@ choice > bool "Native POSIX Threading (NPTL)" > select BR2_TOOLCHAIN_HAS_THREADS > depends on !BR2_x86_i386 > + depends on !BR2_arc > depends on !BR2_avr32 > + depends on !BR2_bfin > depends on !BR2_xtensa > - depends on !BR2_arc > endchoice As suggested by Yann, I've splitted this in two patches, one adding the !bfin dependency, another one doing the re-ordering, including x86_i386. Thomas
diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in index 90aae90..f9c4956 100644 --- a/package/uclibc/Config.in +++ b/package/uclibc/Config.in @@ -104,6 +104,7 @@ choice config BR2_PTHREADS bool "linuxthreads" + depends on !BR2_bfin depends on !BR2_xtensa select BR2_TOOLCHAIN_HAS_THREADS @@ -115,9 +116,10 @@ choice bool "Native POSIX Threading (NPTL)" select BR2_TOOLCHAIN_HAS_THREADS depends on !BR2_x86_i386 + depends on !BR2_arc depends on !BR2_avr32 + depends on !BR2_bfin depends on !BR2_xtensa - depends on !BR2_arc endchoice config BR2_PTHREAD_DEBUG
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> --- package/uclibc/Config.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)