| Message ID | 1372712161-8711-1-git-send-email-dirtyepic@gentoo.org |
|---|---|
| State | New |
| Headers | show |
On Mon, 1 Jul 2013 14:56:01 -0600 Ryan Hill <dirtyepic@gentoo.org> wrote: Ping. http://gcc.gnu.org/ml/gcc-patches/2013-07/msg00033.html > libitm is currently unconditionally built with -Werror. This patch adds > --enable-werror to control it (enabled by default). Bootstrapped and tested > on x86_64, and inspected build logs to ensure it was doing what it should. > > I'm assuming copyright assignment isn't necessary for a small change like > this. I will also need someone to check this in for me please. > > > gcc/libitm/ > 2013-06-30 Ryan Hill <dirtyepic@gentoo.org> > > * configure.ac: Add --enable-werror. > (XCFLAGS): Use it. > * configure: Regenerate. > > --- > libitm/configure.ac | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/libitm/configure.ac b/libitm/configure.ac > index ff41266..5a9400d 100644 > --- a/libitm/configure.ac > +++ b/libitm/configure.ac > @@ -252,9 +252,15 @@ GCC_CHECK_ELF_STYLE_WEAKREF > CFLAGS="$save_CFLAGS" > AC_CACHE_SAVE > > -# Add -Wall -Werror if we are using GCC. > +AC_ARG_ENABLE(werror, [AS_HELP_STRING([--enable-werror], > + [turns on -Werror @<:@default=yes@:>@])]) > +# Add -Wall if we are using GCC. > if test "x$GCC" = "xyes"; then > - XCFLAGS="$XCFLAGS -Wall -Werror" > + XCFLAGS="$XCFLAGS -Wall" > + # Add -Werror if requested. > + if test "x$enable_werror" != "xno"; then > + XCFLAGS="$XCFLAGS -Werror" > + fi > fi > > XCFLAGS="$XCFLAGS $XPCFLAGS"
On Mon, 8 Jul 2013 20:20:01 -0600 Ryan Hill <dirtyepic@gentoo.org> wrote: Ping. > On Mon, 1 Jul 2013 14:56:01 -0600 > Ryan Hill <dirtyepic@gentoo.org> wrote: > > Ping. > http://gcc.gnu.org/ml/gcc-patches/2013-07/msg00033.html > > > > libitm is currently unconditionally built with -Werror. This patch adds > > --enable-werror to control it (enabled by default). Bootstrapped and tested > > on x86_64, and inspected build logs to ensure it was doing what it should. > > > > I'm assuming copyright assignment isn't necessary for a small change like > > this. I will also need someone to check this in for me please. > > > > > > gcc/libitm/ > > 2013-06-30 Ryan Hill <dirtyepic@gentoo.org> > > > > * configure.ac: Add --enable-werror. > > (XCFLAGS): Use it. > > * configure: Regenerate. > > > > --- > > libitm/configure.ac | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/libitm/configure.ac b/libitm/configure.ac > > index ff41266..5a9400d 100644 > > --- a/libitm/configure.ac > > +++ b/libitm/configure.ac > > @@ -252,9 +252,15 @@ GCC_CHECK_ELF_STYLE_WEAKREF > > CFLAGS="$save_CFLAGS" > > AC_CACHE_SAVE > > > > -# Add -Wall -Werror if we are using GCC. > > +AC_ARG_ENABLE(werror, [AS_HELP_STRING([--enable-werror], > > + [turns on -Werror @<:@default=yes@:>@])]) > > +# Add -Wall if we are using GCC. > > if test "x$GCC" = "xyes"; then > > - XCFLAGS="$XCFLAGS -Wall -Werror" > > + XCFLAGS="$XCFLAGS -Wall" > > + # Add -Werror if requested. > > + if test "x$enable_werror" != "xno"; then > > + XCFLAGS="$XCFLAGS -Werror" > > + fi > > fi > > > > XCFLAGS="$XCFLAGS $XPCFLAGS" > > >
diff --git a/libitm/configure.ac b/libitm/configure.ac index ff41266..5a9400d 100644 --- a/libitm/configure.ac +++ b/libitm/configure.ac @@ -252,9 +252,15 @@ GCC_CHECK_ELF_STYLE_WEAKREF CFLAGS="$save_CFLAGS" AC_CACHE_SAVE -# Add -Wall -Werror if we are using GCC. +AC_ARG_ENABLE(werror, [AS_HELP_STRING([--enable-werror], + [turns on -Werror @<:@default=yes@:>@])]) +# Add -Wall if we are using GCC. if test "x$GCC" = "xyes"; then - XCFLAGS="$XCFLAGS -Wall -Werror" + XCFLAGS="$XCFLAGS -Wall" + # Add -Werror if requested. + if test "x$enable_werror" != "xno"; then + XCFLAGS="$XCFLAGS -Werror" + fi fi XCFLAGS="$XCFLAGS $XPCFLAGS"