Message ID | 1370563459-30270-2-git-send-email-festevam@gmail.com |
---|---|
State | Accepted |
Delegated to: | Joe Hershberger |
Headers | show |
Hi Joe, On Thu, Jun 6, 2013 at 9:04 PM, Fabio Estevam <festevam@gmail.com> wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field. > > Cc: Joe Hershberger <joe.hershberger@ni.com> > Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Any comments?
On Thu, Jul 11, 2013 at 9:45 PM, Fabio Estevam <festevam@gmail.com> wrote: > Hi Joe, > > On Thu, Jun 6, 2013 at 9:04 PM, Fabio Estevam <festevam@gmail.com> wrote: >> From: Fabio Estevam <fabio.estevam@freescale.com> >> >> LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field. >> >> Cc: Joe Hershberger <joe.hershberger@ni.com> >> Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > Any comments? Seems pretty reasonable. I'll pick it up for next release. -Joe
On Thu, Jul 11, 2013 at 11:57 PM, Joe Hershberger <joe.hershberger@gmail.com> wrote: > On Thu, Jul 11, 2013 at 9:45 PM, Fabio Estevam <festevam@gmail.com> wrote: >> Hi Joe, >> >> On Thu, Jun 6, 2013 at 9:04 PM, Fabio Estevam <festevam@gmail.com> wrote: >>> From: Fabio Estevam <fabio.estevam@freescale.com> >>> >>> LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field. >>> >>> Cc: Joe Hershberger <joe.hershberger@ni.com> >>> Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> >>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> >> >> Any comments? > > > Seems pretty reasonable. I'll pick it up for next release. On second thought, it's delegated in patchwork to Stefano and it's marked rejected. Why is that Stefano? -Joe
On Fri, Jul 12, 2013 at 2:00 AM, Joe Hershberger <joe.hershberger@gmail.com> wrote: > On second thought, it's delegated in patchwork to Stefano and it's > marked rejected. Why is that Stefano? Ok, I think I understand the reason. I asked him to reject the 1/2 patch of the series (it was a mx28evk related patch). This one (2/2) is fine. Sorry for the confusion.
On Fri, Jul 12, 2013 at 12:06 AM, Fabio Estevam <festevam@gmail.com> wrote: > On Fri, Jul 12, 2013 at 2:00 AM, Joe Hershberger > <joe.hershberger@gmail.com> wrote: > >> On second thought, it's delegated in patchwork to Stefano and it's >> marked rejected. Why is that Stefano? > > Ok, I think I understand the reason. I asked him to reject the 1/2 > patch of the series (it was a mx28evk related patch). > > This one (2/2) is fine. > > Sorry for the confusion. OK. That sounds fine. -Joe
On 12/07/2013 07:06, Fabio Estevam wrote: > On Fri, Jul 12, 2013 at 2:00 AM, Joe Hershberger > <joe.hershberger@gmail.com> wrote: > >> On second thought, it's delegated in patchwork to Stefano and it's >> marked rejected. Why is that Stefano? > > Ok, I think I understand the reason. I asked him to reject the 1/2 > patch of the series (it was a mx28evk related patch). > > This one (2/2) is fine. > > Sorry for the confusion. Yes, I confirm this - I rejected on Fabio's request. Regards, Stefano
On Thu, Jun 6, 2013 at 7:04 PM, Fabio Estevam <festevam@gmail.com> wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field. > > Cc: Joe Hershberger <joe.hershberger@ni.com> > Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- Applied, Thanks! -Joe
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index 6dee8eb..0c658f4 100644 --- a/drivers/net/phy/smsc.c +++ b/drivers/net/phy/smsc.c @@ -76,7 +76,7 @@ static struct phy_driver lan8710_driver = { .name = "SMSC LAN8710/LAN8720", .uid = 0x0007c0f0, .mask = 0xffff0, - .features = PHY_GBIT_FEATURES, + .features = PHY_BASIC_FEATURES, .config = &genphy_config_aneg, .startup = &smsc_startup, .shutdown = &genphy_shutdown,