diff mbox

net/cadence/macb: fix bug/typo in extracting gem_irq_read_clear bit

Message ID 1373358960-10900-1-git-send-email-neidhard.kim@lge.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Jongsung Kim July 9, 2013, 8:36 a.m. UTC 
Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
---
 drivers/net/ethernet/cadence/macb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Nicolas Ferre July 9, 2013, 4:02 p.m. UTC | #1 
On 09/07/2013 10:36, Jongsung Kim :
> Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: stable <stable@vger.kernel.org> # 3.10+

Thanks for having spotted that.

Best regards,

> ---
>   drivers/net/ethernet/cadence/macb.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index c89aa41..b4e0dc8 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -1070,7 +1070,7 @@ static void macb_configure_dma(struct macb *bp)
>   static void macb_configure_caps(struct macb *bp)
>   {
>   	if (macb_is_gem(bp)) {
> -		if (GEM_BF(IRQCOR, gem_readl(bp, DCFG1)) == 0)
> +		if (GEM_BFEXT(IRQCOR, gem_readl(bp, DCFG1)) == 0)
>   			bp->caps |= MACB_CAPS_ISR_CLEAR_ON_WRITE;
>   	}
>   }
>
David Miller July 9, 2013, 7:50 p.m. UTC | #2 
From: Nicolas Ferre <nicolas.ferre@atmel.com>
Date: Tue, 9 Jul 2013 18:02:23 +0200

> On 09/07/2013 10:36, Jongsung Kim :
>> Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: stable <stable@vger.kernel.org> # 3.10+

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index c89aa41..b4e0dc8 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -1070,7 +1070,7 @@  static void macb_configure_dma(struct macb *bp)
 static void macb_configure_caps(struct macb *bp)
 {
 	if (macb_is_gem(bp)) {
-		if (GEM_BF(IRQCOR, gem_readl(bp, DCFG1)) == 0)
+		if (GEM_BFEXT(IRQCOR, gem_readl(bp, DCFG1)) == 0)
 			bp->caps |= MACB_CAPS_ISR_CLEAR_ON_WRITE;
 	}
 }