| Message ID | 1373307567-21958-1-git-send-email-wd@denx.de |
|---|---|
| State | Superseded |
| Headers | show |
On 07/08/2013 01:19 PM, Wolfgang Denk wrote: > + uint32_t crc_buf; > + > + memcpy(&crc_buf, &buf[24], sizeof(unsigned int)); Well, this is wrong, because it should be sizeof(uint32_t). Or maybe sizeof(crc_buf).
Dear Timur Tabi, In message <51DB3787.4000308@tabi.org> you wrote: > On 07/08/2013 01:19 PM, Wolfgang Denk wrote: > > + uint32_t crc_buf; > > + > > + memcpy(&crc_buf, &buf[24], sizeof(unsigned int)); > > Well, this is wrong, because it should be sizeof(uint32_t). Or maybe > sizeof(crc_buf). Indedd. Sorry. V3 on the way. Thanks! Best regards, Wolfgang Denk
diff --git a/board/freescale/mpc8323erdb/mpc8323erdb.c b/board/freescale/mpc8323erdb/mpc8323erdb.c index f29b2f4..533cb08 100644 --- a/board/freescale/mpc8323erdb/mpc8323erdb.c +++ b/board/freescale/mpc8323erdb/mpc8323erdb.c @@ -195,7 +195,11 @@ int mac_read_from_eeprom(void) printf("\nEEPROM @ 0x%02x read FAILED!!!\n", CONFIG_SYS_I2C_EEPROM_ADDR); } else { - if (crc32(crc, buf, 24) == *(unsigned int *)&buf[24]) { + uint32_t crc_buf; + + memcpy(&crc_buf, &buf[24], sizeof(unsigned int)); + + if (crc32(crc, buf, 24) == crc_buf) { printf("Reading MAC from EEPROM\n"); for (i = 0; i < 4; i++) { if (memcmp(&buf[i * 6], "\0\0\0\0\0\0", 6)) {
Fix: mpc8323erdb.c: In function 'mac_read_from_eeprom': mpc8323erdb.c:198:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] Signed-off-by: Wolfgang Denk <wd@denx.de> cc: Timur Tabi <timur@tabi.org> cc: Kim Phillips <kim.phillips@freescale.com> --- V2: use uint32_t for crc_buf to make sure we always get exactly 32 bit; thanks to Timur Tabi for pointing out. board/freescale/mpc8323erdb/mpc8323erdb.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)