| Message ID | 51D9AB5A.8000303@gcc.gnu.org |
|---|---|
| State | New |
| Headers | show |
On Sun, 2013-07-07 at 19:54 +0200, Georg-Johann Lay wrote: > Ondrej Bilka schrieb: > > > http://kam.mff.cuni.cz/~ondra/gcc_misspell.patch > Below are some other hunks that look suspicious... (trying not to duplicate the things already mentioned by others) - * 1) It means that finalizers, and all methods calle by them, + * 1) It means that finalizers, and all methods callee by them, -> 'called' - /* SET_ACCESS, we want to set an explicte set of permissions, do not + /* SET_ACCESS, we want to set an explicate set of permissions, do not -> 'explicit' In Objective-C, there are two additional variants: foreach-statement: - for ( expression in expresssion ) statement + for ( expression in expressions ) statement for ( declaration in expression ) statement Really? I'm not so sure. - configury */ + configure */ -> 'configury' - calll #gettlsoff(ADDR)@(gr8, gr0) + call #gettlsoff(ADDR)@(gr8, gr0) - calll #gettlsoff(ADDR)@(gr8, gr0) + call #gettlsoff(ADDR)@(gr8, gr0) The original 'calll' is correct (see frv.md). - have the same priority - candidate is best if its dependees were + have the same priority - candidate is best if its dependencies were -> 'dependees' - does not look at other present displacement addressings around it. + does not look at other present displacement addressing around it. -> 'addressings' (as in addressing modes) - CM_SMALL, /* Makes various assumpation about sizes of code and + CM_SMALL, /* Makes various assumption about sizes of code and - CM_SMALL_PIC, /* Makes various assumpation about sizes of code and + CM_SMALL_PIC, /* Makes various assumption about sizes of code and -> 'assumptions' /* If we had fewer function args than explicit template args, - just use the explicits. */ + just use the explicit. */ -> 'explicit ones' - array reference if the where and elswhere destinations + array reference if the where and Elsinore destinations -> 'elsewhere' - We provide accestor to the inline_summary datastructure and + We provide accessor to the inline_summary datastructure and -> probably 'ancestor' -/* The array used to find duplications in conflict vectors of +/* The array used to find duplication in conflict vectors of -/* Remove duplications in conflict vector of OBJ. */ +/* Remove duplication in conflict vector of OBJ. */ -/* Process operator duplications in insn with ID. We do it after the +/* Process operator duplication in insn with ID. We do it after the -> 'duplicates' maybe? - function we iterate decompressions until no data remains. */ + function we iterate decompression's until no data remains. */ -> 'decompressions' - TODO: Make into some kind of configury-generated table. */ + TODO: Make into some kind of configure-generated table. */ -> 'configury-generated' - point of view as prefetch withouth dependecies will have a + point of view as prefetch withouth dependencies will have a -> missed 'without' - * Unique vinsn derivates from CALL, ASM, JUMP (for a while) and other + * Unique vinsn derivatives from CALL, ASM, JUMP (for a while) and other -> maybe 'deviates' ? -/* Find the set of registers that are unavailable for storing expres +/* Find the set of registers that are unavailable for storing express - that are not available for storing expres while moving ORIG_OPS up on the + that are not available for storing express while moving ORIG_OPS up on the - /* Merge c_expres found or unify live register sets from different + /* Merge c_express found or unify live register sets from different -> maybe 'expression' ? -/* { dg-final { scan-assembler "calll.*#gettlsoff\\(0\\)" } } */ +/* { dg-final { scan-assembler "call.*#gettlsoff\\(0\\)" } } */ -> see above for the 'calll' frv case. This breaks the test case. Do not change things inside /* { } */ comments in test cases. -/* PR target/50749: Verify that subsequent post-increment addressings +/* PR target/50749: Verify that subsequent post-increment addressing -/* PR target/50749: Verify that subsequent pre-decrement addressings +/* PR target/50749: Verify that subsequent pre-decrement addressing -/* PR target/50749: Verify that subsequent post-increment addressings +/* PR target/50749: Verify that subsequent post-increment addressing -/* PR target/50749: Verify that subsequent pre-decrement addressings +/* PR target/50749: Verify that subsequent pre-decrement addressing -> 'addressings' (as in addressing modes) - /* For buitins that are likely expanded to nothing or + /* For builtin's that are likely expanded to nothing or -> 'builtins' BASE must be either a declaration or a memory reference that has correct - alignment ifformation embeded in it (e.g. a pre-existing one in SRA). */ + alignment ifformation embedded in it (e.g. a pre-existing one in SRA). */ -> missed 'information' I guess... - via commutating the addition and contracting operations to zero + via commuting the addition and contracting operations to zero -> 'commutating' - and one can be commutated try that for the scalar stmts + and one can be commuted try that for the scalar stmts -> 'commutated' - http://www.ddj.com/articles/1997/9701/9701o/9701o.htm?topic=algoritms + http://www.ddj.com/articles/1997/9701/9701o/9701o.htm?topic=algorithms both links do 404 anyway ;) - Written by Cary Coutant <ccoutant@google.com>. + Written by Cary Coutant <accountant@google.com>. As Georg-Johann mentioned, do not touch email addresses. - /* This definition was pre-empted by a definition in a regular + /* This definition was pre-emptied by a definition in a regular - /* This definition was pre-empted by a definition in another IR file. */ + /* This definition was pre-emptied by a definition in another IR file. */ -> 'preempted' ? - set it true anyway, since malloc copes with non-contiguities. + set it true anyway, since malloc copes with non-continuities. -> 'non-contiguities' -/* mstate bit set if continguous morecore disabled or failed */ +/* mstate bit set if continuous morecore disabled or failed */ -> 'contiguous' -/* Chebyshev polynom coeficients for (exp(x)-1)/x */ +/* Chebyshev polynom coefficients for (exp(x)-1)/x */ -> 'polynomial' - // Randomize the colour, just for asthetics =) + // Randomize the colour, just for aesthetics =) -> missed 'color' (in a couple of places actually)
On Sun, Jul 07, 2013 at 07:54:34PM +0200, Georg-Johann Lay wrote: > Ondrej Bilka schrieb: > > >http://kam.mff.cuni.cz/~ondra/gcc_misspell.patch > > This is wrong: > > @@ -10834,7 +10834,7 @@ avr_convert_to_type (tree type, tree expr) > XOP[2] # Bytes to copy > > Return TRUE if the expansion is accomplished. > - Return FALSE if the operand compination is not supported. */ > + Return FALSE if the operand compilation is not supported. */ > > Should be "combination" not "compilation". > > > index 406617f..c7a7f7b 100644 > --- a/gcc/config/frv/frv-opts.h > +++ b/gcc/config/frv/frv-opts.h > @@ -1,4 +1,4 @@ > -/* Frv option-handling defitions. > +/* Frv option-handling deviations. > > Should be "definitions" instead of "deviations". > > > -/* Expand SYMBOL into its corresponding far-addresse symbol. > +/* Expand SYMBOL into its corresponding far-addressee symbol. > > Is this correct or should be "far-address"? > > > @@ -5336,7 +5336,7 @@ pa_print_operand (FILE *file, rtx x, int code) > && GET_CODE (XEXP (XEXP (x, 0), 1)) == REG) > { > /* Because the REG_POINTER flag can get lost during reload, > - pa_legitimate_address_p canonicalizes the order of the > + pa_legitimate_address_p canonizes the order of the > > I am not sure about this one and many others. "canonicalize" sounds > ok to me, so does "canonicalization". "canonize" sounds odd to me. > For example the following which should change none or both: > > -/* Canonicalize the filename NAME by canonicalizing directory > +/* Canonicalize the filename NAME by canonizing directory > > - * Unique vinsn derivates from CALL, ASM, JUMP (for a while) and other > + * Unique vinsn derivatives from CALL, ASM, JUMP (for a while) and other > > Shouldn't this be "derives"? > > > - /* Merge c_expres found or unify live register sets from different > + /* Merge c_express found or unify live register sets from different > > Some lines above in sel-sched.c there is "C_EXPRes". Again, change > none or both (none seems fine here): > oops it was bug, fixed. > > - /* Test exponentials and their signs. A buggy lexer is more likely > + /* Test exponential and their signs. A buggy lexer is more likely > > Should both be plural or singular. "exponents" sounds good to me. > it is also in string bellow so probably we need change or keep both. > > - Roger Sayle <...@eyesopen.com> > + Roger Sayle <...@eyes open.com> > > Don't change email addresses! bug, fixed
On Sun, Jul 07, 2013 at 09:57:05PM +0200, Oleg Endo wrote: > On Sun, 2013-07-07 at 19:54 +0200, Georg-Johann Lay wrote: > > Ondrej Bilka schrieb: > > > > > http://kam.mff.cuni.cz/~ondra/gcc_misspell.patch > > I fixed most comments, put it here so you can diff these two files. http://kam.mff.cuni.cz/~ondra/gcc_misspell_fixed.patch > > BASE must be either a declaration or a memory reference that has correct > - alignment ifformation embeded in it (e.g. a pre-existing one in SRA). */ > + alignment ifformation embedded in it (e.g. a pre-existing one in SRA). */ > > -> missed 'information' I guess... > This fixes only a-e. These are probably incomplete as I needed to exclude lot of names that are variable names etc. I did selectin based on following file: http://kam.mff.cuni.cz/~ondra/gcc_misspells > > > - http://www.ddj.com/articles/1997/9701/9701o/9701o.htm?topic=algoritms > + http://www.ddj.com/articles/1997/9701/9701o/9701o.htm?topic=algorithms > > both links do 404 anyway ;) > could you find what this was? I need to add another filter not touch html which I will do probably tomorrow. > > - // Randomize the colour, just for asthetics =) > + // Randomize the colour, just for aesthetics =) > > -> missed 'color' (in a couple of places actually) > Wa- not on my list because my aspell thinks its valid.
On Mon, 2013-07-08 at 16:12 +0200, Ondřej Bílka wrote: > On Sun, Jul 07, 2013 at 09:57:05PM +0200, Oleg Endo wrote: > > On Sun, 2013-07-07 at 19:54 +0200, Georg-Johann Lay wrote: > > > Ondrej Bilka schrieb: > > > > > > > http://kam.mff.cuni.cz/~ondra/gcc_misspell.patch > > > > I fixed most comments, put it here so you can diff these two files. > http://kam.mff.cuni.cz/~ondra/gcc_misspell_fixed.patch > > > > > > > BASE must be either a declaration or a memory reference that has correct > > - alignment ifformation embeded in it (e.g. a pre-existing one in SRA). */ > > + alignment ifformation embedded in it (e.g. a pre-existing one in SRA). */ > > > > -> missed 'information' I guess... > > > > This fixes only a-e. These are probably incomplete as I needed to > exclude lot of names that are variable names etc. > > I did selectin based on following file: > http://kam.mff.cuni.cz/~ondra/gcc_misspells > > > > > > - http://www.ddj.com/articles/1997/9701/9701o/9701o.htm?topic=algoritms > > + http://www.ddj.com/articles/1997/9701/9701o/9701o.htm?topic=algorithms > > > > both links do 404 anyway ;) > > > could you find what this was? I need to add another filter not touch > html which I will do probably tomorrow. It seems the original article is gone. At least I can't find it easily (the patch that added the link is from 2001...). It's about Fibonacci Heaps so there's plenty of material out there on the net. The paper mentioned in the comment can be found rather easily: http://www.cs.princeton.edu/courses/archive/fall03/cs528/handouts/fibonacci%20heaps.pdf However, maybe it's better to replace the DDJ link with this http://en.wikipedia.org/wiki/Fibonacci_heap Cheers, Oleg
On Mon, Jul 08, 2013 at 09:42:14PM +0200, Oleg Endo wrote: > On Mon, 2013-07-08 at 16:12 +0200, Ondřej Bílka wrote: > > On Sun, Jul 07, 2013 at 09:57:05PM +0200, Oleg Endo wrote: > > > On Sun, 2013-07-07 at 19:54 +0200, Georg-Johann Lay wrote: > > > > > > - http://www.ddj.com/articles/1997/9701/9701o/9701o.htm?topic=algoritms > > > + http://www.ddj.com/articles/1997/9701/9701o/9701o.htm?topic=algorithms > > > > > > both links do 404 anyway ;) > > > > > could you find what this was? I need to add another filter not touch > > html which I will do probably tomorrow. > > It seems the original article is gone. At least I can't find it easily > (the patch that added the link is from 2001...). It's about Fibonacci > Heaps so there's plenty of material out there on the net. The paper > mentioned in the comment can be found rather easily: > > http://www.cs.princeton.edu/courses/archive/fall03/cs528/handouts/fibonacci%20heaps.pdf > > However, maybe it's better to replace the DDJ link with this > http://en.wikipedia.org/wiki/Fibonacci_heap > I prefer fix issues one class at time. I added script that checks dead links by extracting http addresses from sources and checking them by curl -f. It found: $ ./stylepp/script/stylepp_warn_dead_link Dead link: http://anubis.dkuug.dk/jtc1/sc22/wg21/docs/cwg_closed.html#46 Dead link: http://citeseer.nj.nec.com/15361.html Dead link: http://dwarf.freestandards.org Dead link: http://fedora.linux.duke.edu/fc1_x86_64 Dead link: http://gcc.gnu.org/ml/gcc-patches/2004-02/msg01307.html Dead link: http://gcc.gnu.org/ml/gcc-patches/2004-02/msg01518.html Dead link: http://gcc.gnu.org/onlinedocs/libstdc++/documentation.html Dead link: http://rogue.colorado.edu/EPIC7/ Dead link: http://sourcery.mentor.com/public/cxx-abi/exceptions.pdf Dead link: http://www.beunited.org/articles/jbq/nasm.shtml Dead link: http://www.netlib.org/specfun/algama Dead link: http://www.netlib.org/specfun/erf Dead link: http://www.netlib.org/specfun/gamma If somebody wants to find replacements for them it would be welcome.
On 10 July 2013 15:00, Ondřej Bílka wrote: >> > I prefer fix issues one class at time. I added script that checks dead > links by extracting http addresses from sources and checking them by curl -f. > It found: > > $ ./stylepp/script/stylepp_warn_dead_link > > Dead link: http://anubis.dkuug.dk/jtc1/sc22/wg21/docs/cwg_closed.html#46 http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_closed.html#46 > Dead link: http://citeseer.nj.nec.com/15361.html > Dead link: http://dwarf.freestandards.org http://www.dwarfstd.org/ > Dead link: http://fedora.linux.duke.edu/fc1_x86_64 > Dead link: http://gcc.gnu.org/ml/gcc-patches/2004-02/msg01307.html > Dead link: http://gcc.gnu.org/ml/gcc-patches/2004-02/msg01518.html Strange, I don't know why those messages are missing, they're in the index. > Dead link: http://gcc.gnu.org/onlinedocs/libstdc++/documentation.html Where is that link? It should probably be http://gcc.gnu.org/onlinedocs/libstdc++/ > Dead link: http://rogue.colorado.edu/EPIC7/ > Dead link: http://sourcery.mentor.com/public/cxx-abi/exceptions.pdf Probably http://mentorembedded.github.io/cxx-abi/abi-eh.html > Dead link: http://www.beunited.org/articles/jbq/nasm.shtml > Dead link: http://www.netlib.org/specfun/algama > Dead link: http://www.netlib.org/specfun/erf > Dead link: http://www.netlib.org/specfun/gamma > > If somebody wants to find replacements for them it would be welcome.
On Wed, 2013-07-10 at 16:00 +0200, Ondřej Bílka wrote:
> Dead link: http://fedora.linux.duke.edu/fc1_x86_64
FWIW, this link occurs in historical notes at the top of these files:
zlib/contrib/inflate86/inffas86.c
zlib/contrib/masmx64/inffas8664.c
dated Dec-29-2003 describing specific testing done at that time, and
thus although the link is dead, it seems wrong to me to go changing it
(also, given that it's an embedded copy of a 3rd-party library, this
would be more for upstream zlib).
Hope this is helpful
Dave
On 10 July 2013 15:47, David Malcolm wrote: > On Wed, 2013-07-10 at 16:00 +0200, Ondřej Bílka wrote: > >> Dead link: http://fedora.linux.duke.edu/fc1_x86_64 > > FWIW, this link occurs in historical notes at the top of these files: > zlib/contrib/inflate86/inffas86.c > zlib/contrib/masmx64/inffas8664.c > dated Dec-29-2003 describing specific testing done at that time, and > thus although the link is dead, it seems wrong to me to go changing it > (also, given that it's an embedded copy of a 3rd-party library, this > would be more for upstream zlib). > > Hope this is helpful Thanks. Ondřej, as stated a few times now, anything in zlib, boehm-gc, etc. is maintained outside the GCC project. Do you have any way to filter out certain directories from being checked by your scripts?
On Wed, Jul 10, 2013 at 04:01:54PM +0100, Jonathan Wakely wrote: > On 10 July 2013 15:47, David Malcolm wrote: > > On Wed, 2013-07-10 at 16:00 +0200, Ondřej Bílka wrote: > > > >> Dead link: http://fedora.linux.duke.edu/fc1_x86_64 > > > > FWIW, this link occurs in historical notes at the top of these files: > > zlib/contrib/inflate86/inffas86.c > > zlib/contrib/masmx64/inffas8664.c > > dated Dec-29-2003 describing specific testing done at that time, and > > thus although the link is dead, it seems wrong to me to go changing it > > (also, given that it's an embedded copy of a 3rd-party library, this > > would be more for upstream zlib). > > > > Hope this is helpful > > Thanks. Ondřej, as stated a few times now, anything in zlib, > boehm-gc, etc. is maintained outside the GCC project. Do you have any > way to filter out certain directories from being checked by your > scripts? I have (place .indent.off file to directory) but I do not know which ones except these are external. Closest what I could find is http://gcc.gnu.org/onlinedocs/gccint/Top-Level.html#Top-Level I added boehm-gc,zlib and gcc/testsuite. Are there others?
On 10 July 2013 16:22, Ondřej Bílka wrote: >> Thanks. Ondřej, as stated a few times now, anything in zlib, >> boehm-gc, etc. is maintained outside the GCC project. Do you have any >> way to filter out certain directories from being checked by your >> scripts? > > I have (place .indent.off file to directory) but I do not know which ones > except these are external. Closest what I could find is > http://gcc.gnu.org/onlinedocs/gccint/Top-Level.html#Top-Level > > I added boehm-gc,zlib and gcc/testsuite. Are there others? Joseph listed some more at http://gcc.gnu.org/ml/gcc/2013-07/msg00119.html
--- a/gcc/config/frv/frv-opts.h +++ b/gcc/config/frv/frv-opts.h @@ -1,4 +1,4 @@ -/* Frv option-handling defitions. +/* Frv option-handling deviations. Should be "definitions" instead of "deviations".
Ondrej Bilka schrieb: > http://kam.mff.cuni.cz/~ondra/gcc_misspell.patch This is wrong: @@ -10834,7 +10834,7 @@ avr_convert_to_type (tree type, tree expr) XOP[2] # Bytes to copy Return TRUE if the expansion is accomplished. - Return FALSE if the operand compination is not supported. */ + Return FALSE if the operand compilation is not supported. */ Should be "combination" not "compilation". index 406617f..c7a7f7b 100644 -/* Expand SYMBOL into its corresponding far-addresse symbol. +/* Expand SYMBOL into its corresponding far-addressee symbol. Is this correct or should be "far-address"? @@ -5336,7 +5336,7 @@ pa_print_operand (FILE *file, rtx x, int code) && GET_CODE (XEXP (XEXP (x, 0), 1)) == REG) { /* Because the REG_POINTER flag can get lost during reload, - pa_legitimate_address_p canonicalizes the order of the + pa_legitimate_address_p canonizes the order of the I am not sure about this one and many others. "canonicalize" sounds ok to me, so does "canonicalization". "canonize" sounds odd to me. For example the following which should change none or both: -/* Canonicalize the filename NAME by canonicalizing directory +/* Canonicalize the filename NAME by canonizing directory - * Unique vinsn derivates from CALL, ASM, JUMP (for a while) and other + * Unique vinsn derivatives from CALL, ASM, JUMP (for a while) and other Shouldn't this be "derives"? - /* Merge c_expres found or unify live register sets from different + /* Merge c_express found or unify live register sets from different Some lines above in sel-sched.c there is "C_EXPRes". Again, change none or both (none seems fine here): - /* Test exponentials and their signs. A buggy lexer is more likely + /* Test exponential and their signs. A buggy lexer is more likely Should both be plural or singular. "exponents" sounds good to me. - Roger Sayle <...@eyesopen.com> + Roger Sayle <...@eyes open.com> Don't change email addresses! Johann