| Message ID | 1372437710-6361-2-git-send-email-l.majewski@samsung.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski wrote: > For the first eMMC read of data for upload, use the "large" dfu_buf (now > configurable) instead of usb request buffer allocated at composite layer > (which is 4KiB) [*]. > > For eMMC the whole file is read, which usually is larger than the buffer [*] > provided with usb request. > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > Cc: Tom Rini <trini@ti.com> > Cc: Pantelis Antoniou <panto@antoniou-consulting.com> > Cc: Marek Vasut <marex@denx.de> > Cc: Heiko Schocher <hs@denx.de> Applied to u-boot/master, thanks!
Dear Tom Rini, > On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski wrote: > > For the first eMMC read of data for upload, use the "large" dfu_buf (now > > configurable) instead of usb request buffer allocated at composite layer > > (which is 4KiB) [*]. > > > > For eMMC the whole file is read, which usually is larger than the buffer > > [*] provided with usb request. > > > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > > Cc: Tom Rini <trini@ti.com> > > Cc: Pantelis Antoniou <panto@antoniou-consulting.com> > > Cc: Marek Vasut <marex@denx.de> > > Cc: Heiko Schocher <hs@denx.de> > > Applied to u-boot/master, thanks! Tom, why are you picking USB changes now? This is creating quite some mess ... Best regards, Marek Vasut
On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: > Dear Tom Rini, > > > On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski wrote: > > > For the first eMMC read of data for upload, use the "large" dfu_buf (now > > > configurable) instead of usb request buffer allocated at composite layer > > > (which is 4KiB) [*]. > > > > > > For eMMC the whole file is read, which usually is larger than the buffer > > > [*] provided with usb request. > > > > > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > > > Cc: Tom Rini <trini@ti.com> > > > Cc: Pantelis Antoniou <panto@antoniou-consulting.com> > > > Cc: Marek Vasut <marex@denx.de> > > > Cc: Heiko Schocher <hs@denx.de> > > > > Applied to u-boot/master, thanks! > > Tom, why are you picking USB changes now? This is creating quite some mess ... Just trying to clear up the queue of fixes.
Dear Tom Rini, > On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: > > Dear Tom Rini, > > > > > On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski wrote: > > > > For the first eMMC read of data for upload, use the "large" dfu_buf > > > > (now configurable) instead of usb request buffer allocated at > > > > composite layer (which is 4KiB) [*]. > > > > > > > > For eMMC the whole file is read, which usually is larger than the > > > > buffer [*] provided with usb request. > > > > > > > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > > > > Cc: Tom Rini <trini@ti.com> > > > > Cc: Pantelis Antoniou <panto@antoniou-consulting.com> > > > > Cc: Marek Vasut <marex@denx.de> > > > > Cc: Heiko Schocher <hs@denx.de> > > > > > > Applied to u-boot/master, thanks! > > > > Tom, why are you picking USB changes now? This is creating quite some > > mess ... > > Just trying to clear up the queue of fixes. Ok, if you manage to merge it with the USB PR ... Best regards, Marek Vasut
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 07/05/2013 09:55 AM, Marek Vasut wrote: > Dear Tom Rini, > >> On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: >>> Dear Tom Rini, >>> >>>> On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski >>>> wrote: >>>>> For the first eMMC read of data for upload, use the "large" >>>>> dfu_buf (now configurable) instead of usb request buffer >>>>> allocated at composite layer (which is 4KiB) [*]. >>>>> >>>>> For eMMC the whole file is read, which usually is larger >>>>> than the buffer [*] provided with usb request. >>>>> >>>>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> Cc: >>>>> Tom Rini <trini@ti.com> Cc: Pantelis Antoniou >>>>> <panto@antoniou-consulting.com> Cc: Marek Vasut >>>>> <marex@denx.de> Cc: Heiko Schocher <hs@denx.de> >>>> >>>> Applied to u-boot/master, thanks! >>> >>> Tom, why are you picking USB changes now? This is creating >>> quite some mess ... >> >> Just trying to clear up the queue of fixes. > > Ok, if you manage to merge it with the USB PR ... Yup, fit right on top. I'll stop being an overarching custodian and let you grab the copyright fix :) - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJR1tOoAAoJENk4IS6UOR1WUToP/1+NJg5S9fFWaFWFfya0eRhi N3qdiA9bTs2hye/EwPB75HQ7tllWmr5/pHwFXLvkrCbV8pL/P2SnSch/lmN4PX7l qC6EEz5xlgpy0vhPQ8S+rLgoa2qavurBFAR2G3D+s2s4NkjSTmUrs/VHnzXOexKI 6DG4gu8FrNBvE0SMCfuXHJcRD7rEvXYsDH0sz+21DlhFr/WIk1ErREP3rXHk0ffp b0rOWvdYTQcceYDgXS70JSXpwmRl/QWga8UpdseNtujhz18RX3C8W8XG6dSoTZGv CYZQzAldU9k5y/S1c7t1W87Himc6bZfcuTYlXpvAB2isN02S3jQmzmdFZ95xc0Lv AZUV05VRAsVKXkwihpmxUCBwTafzcczFjm48bdJ5n5Qvpy5VnwsiFucHyB4/9ikv 1e3eOueaxLaMNHCHfiP/J8tr8/4H8M+dq4HKQvjZdmCsBqEHiKUUDQIKTFaryOg2 sohWAH6v76qK2CjQ2I2rHju1lMeLeOHpR33ZUb0FBVLRVzdZl9QD3rTRuW840pPt OCdscioGWatJ0YkND4giCey15O38IaKQ0Q6McqoZe/GIhvt2tqTWJrKdM1d76lXZ 9TaYLKxY20GAvfxPAopUaNdnwFiu3uefwZpMsJGbqg+aJyOuncCqXRDKprru9bbj chpFHxwvm/wGhkLDleeO =XazZ -----END PGP SIGNATURE-----
Dear Tom Rini, > On 07/05/2013 09:55 AM, Marek Vasut wrote: > > Dear Tom Rini, > > > >> On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: > >>> Dear Tom Rini, > >>> > >>>> On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski > >>>> > >>>> wrote: > >>>>> For the first eMMC read of data for upload, use the "large" > >>>>> dfu_buf (now configurable) instead of usb request buffer > >>>>> allocated at composite layer (which is 4KiB) [*]. > >>>>> > >>>>> For eMMC the whole file is read, which usually is larger > >>>>> than the buffer [*] provided with usb request. > >>>>> > >>>>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> Cc: > >>>>> Tom Rini <trini@ti.com> Cc: Pantelis Antoniou > >>>>> <panto@antoniou-consulting.com> Cc: Marek Vasut > >>>>> <marex@denx.de> Cc: Heiko Schocher <hs@denx.de> > >>>> > >>>> Applied to u-boot/master, thanks! > >>> > >>> Tom, why are you picking USB changes now? This is creating > >>> quite some mess ... > >> > >> Just trying to clear up the queue of fixes. > > > > Ok, if you manage to merge it with the USB PR ... > > Yup, fit right on top. I'll stop being an overarching custodian and > let you grab the copyright fix :) I see discussion , not patch. Link? Best regards, Marek Vasut
On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote: Hi, > Dear Tom Rini, > > > On 07/05/2013 09:55 AM, Marek Vasut wrote: > > > Dear Tom Rini, > > > > > >> On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: > > >>> Dear Tom Rini, > > >>> > > >>>> On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski > > >>>> > > >>>> wrote: > > >>>>> For the first eMMC read of data for upload, use the "large" > > >>>>> dfu_buf (now configurable) instead of usb request buffer > > >>>>> allocated at composite layer (which is 4KiB) [*]. > > >>>>> > > >>>>> For eMMC the whole file is read, which usually is larger > > >>>>> than the buffer [*] provided with usb request. > > >>>>> > > >>>>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> Cc: > > >>>>> Tom Rini <trini@ti.com> Cc: Pantelis Antoniou > > >>>>> <panto@antoniou-consulting.com> Cc: Marek Vasut > > >>>>> <marex@denx.de> Cc: Heiko Schocher <hs@denx.de> > > >>>> > > >>>> Applied to u-boot/master, thanks! > > >>> > > >>> Tom, why are you picking USB changes now? This is creating > > >>> quite some mess ... > > >> > > >> Just trying to clear up the queue of fixes. > > > > > > Ok, if you manage to merge it with the USB PR ... > > > > Yup, fit right on top. I'll stop being an overarching custodian and > > let you grab the copyright fix :) > > I see discussion , not patch. Link? > Here you are: http://patchwork.ozlabs.org/patch/257068/ :-) > Best regards, > Marek Vasut > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot
HI All, May i know how DFU upload functionality resolved as still i am facing problem, when i tried to upload binaries from dfu devices it copied only 4kb images and shoes upload done. Please give me pointer to solution of this problem Regards ~Sumit Gemini On Fri, Jul 5, 2013 at 8:55 PM, Lukasz Majewski <l.majewski@samsung.com>wrote: > On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote: > > Hi, > > > Dear Tom Rini, > > > > > On 07/05/2013 09:55 AM, Marek Vasut wrote: > > > > Dear Tom Rini, > > > > > > > >> On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: > > > >>> Dear Tom Rini, > > > >>> > > > >>>> On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski > > > >>>> > > > >>>> wrote: > > > >>>>> For the first eMMC read of data for upload, use the "large" > > > >>>>> dfu_buf (now configurable) instead of usb request buffer > > > >>>>> allocated at composite layer (which is 4KiB) [*]. > > > >>>>> > > > >>>>> For eMMC the whole file is read, which usually is larger > > > >>>>> than the buffer [*] provided with usb request. > > > >>>>> > > > >>>>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> Cc: > > > >>>>> Tom Rini <trini@ti.com> Cc: Pantelis Antoniou > > > >>>>> <panto@antoniou-consulting.com> Cc: Marek Vasut > > > >>>>> <marex@denx.de> Cc: Heiko Schocher <hs@denx.de> > > > >>>> > > > >>>> Applied to u-boot/master, thanks! > > > >>> > > > >>> Tom, why are you picking USB changes now? This is creating > > > >>> quite some mess ... > > > >> > > > >> Just trying to clear up the queue of fixes. > > > > > > > > Ok, if you manage to merge it with the USB PR ... > > > > > > Yup, fit right on top. I'll stop being an overarching custodian and > > > let you grab the copyright fix :) > > > > I see discussion , not patch. Link? > > > > Here you are: > http://patchwork.ozlabs.org/patch/257068/ > > :-) > > > Best regards, > > Marek Vasut > > _______________________________________________ > > U-Boot mailing list > > U-Boot@lists.denx.de > > http://lists.denx.de/mailman/listinfo/u-boot > > > -- > Best regards, > > Lukasz Majewski > > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >
On Sun, 07 Jul 2013 12:13:48 +0530, Sumit Gemini wrote: Hi Sumit, > HI All, > May i know how DFU upload functionality resolved as still i am > facing problem, when i tried to upload binaries from dfu devices it > copied only 4kb images and shoes upload done. From what medium do you copy? Is that NAND or eMMC device. Have you applied all fixes related to DFU (which were posted recently)? One interesting change it the "configurable" buffer, which might be defined from envs. > > Please give me pointer to solution of this problem > > Regards > ~Sumit Gemini > > > On Fri, Jul 5, 2013 at 8:55 PM, Lukasz Majewski > <l.majewski@samsung.com>wrote: > > > On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote: > > > > Hi, > > > > > Dear Tom Rini, > > > > > > > On 07/05/2013 09:55 AM, Marek Vasut wrote: > > > > > Dear Tom Rini, > > > > > > > > > >> On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote: > > > > >>> Dear Tom Rini, > > > > >>> > > > > >>>> On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski > > > > >>>> > > > > >>>> wrote: > > > > >>>>> For the first eMMC read of data for upload, use the > > > > >>>>> "large" dfu_buf (now configurable) instead of usb request > > > > >>>>> buffer allocated at composite layer (which is 4KiB) [*]. > > > > >>>>> > > > > >>>>> For eMMC the whole file is read, which usually is larger > > > > >>>>> than the buffer [*] provided with usb request. > > > > >>>>> > > > > >>>>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > > > > >>>>> Cc: Tom Rini <trini@ti.com> Cc: Pantelis Antoniou > > > > >>>>> <panto@antoniou-consulting.com> Cc: Marek Vasut > > > > >>>>> <marex@denx.de> Cc: Heiko Schocher <hs@denx.de> > > > > >>>> > > > > >>>> Applied to u-boot/master, thanks! > > > > >>> > > > > >>> Tom, why are you picking USB changes now? This is creating > > > > >>> quite some mess ... > > > > >> > > > > >> Just trying to clear up the queue of fixes. > > > > > > > > > > Ok, if you manage to merge it with the USB PR ... > > > > > > > > Yup, fit right on top. I'll stop being an overarching > > > > custodian and let you grab the copyright fix :) > > > > > > I see discussion , not patch. Link? > > > > > > > Here you are: > > http://patchwork.ozlabs.org/patch/257068/ > > > > :-) > > > > > Best regards, > > > Marek Vasut > > > _______________________________________________ > > > U-Boot mailing list > > > U-Boot@lists.denx.de > > > http://lists.denx.de/mailman/listinfo/u-boot > > > > > > -- > > Best regards, > > > > Lukasz Majewski > > > > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group > > _______________________________________________ > > U-Boot mailing list > > U-Boot@lists.denx.de > > http://lists.denx.de/mailman/listinfo/u-boot > >
HI Lukasz,
I am using spi nor flash, and may i know the fixes which you fixed, and
all changes. because i am facing problem only in upload.
Please help me in this issue.
Thanks
~Sumit
On Mon, Jul 8, 2013 at 11:52 AM, Lukasz Majewski <l.majewski@samsung.com>wrote:
> On Sun, 07 Jul 2013 12:13:48 +0530, Sumit Gemini wrote:
>
> Hi Sumit,
>
> > HI All,
> > May i know how DFU upload functionality resolved as still i am
> > facing problem, when i tried to upload binaries from dfu devices it
> > copied only 4kb images and shoes upload done.
>
> From what medium do you copy? Is that NAND or eMMC device.
>
> Have you applied all fixes related to DFU (which were posted recently)?
> One interesting change it the "configurable" buffer, which might be
> defined from envs.
>
> >
> > Please give me pointer to solution of this problem
> >
> > Regards
> > ~Sumit Gemini
> >
> >
> > On Fri, Jul 5, 2013 at 8:55 PM, Lukasz Majewski
> > <l.majewski@samsung.com>wrote:
> >
> > > On Fri, 05 Jul 2013 16:32:03 +0200, Marek Vasut wrote:
> > >
> > > Hi,
> > >
> > > > Dear Tom Rini,
> > > >
> > > > > On 07/05/2013 09:55 AM, Marek Vasut wrote:
> > > > > > Dear Tom Rini,
> > > > > >
> > > > > >> On Wed, Jul 03, 2013 at 11:49:20PM +0200, Marek Vasut wrote:
> > > > > >>> Dear Tom Rini,
> > > > > >>>
> > > > > >>>> On Fri, Jun 28, 2013 at 06:41:50PM +0200, ??ukasz Majewski
> > > > > >>>>
> > > > > >>>> wrote:
> > > > > >>>>> For the first eMMC read of data for upload, use the
> > > > > >>>>> "large" dfu_buf (now configurable) instead of usb request
> > > > > >>>>> buffer allocated at composite layer (which is 4KiB) [*].
> > > > > >>>>>
> > > > > >>>>> For eMMC the whole file is read, which usually is larger
> > > > > >>>>> than the buffer [*] provided with usb request.
> > > > > >>>>>
> > > > > >>>>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > > > > >>>>> Cc: Tom Rini <trini@ti.com> Cc: Pantelis Antoniou
> > > > > >>>>> <panto@antoniou-consulting.com> Cc: Marek Vasut
> > > > > >>>>> <marex@denx.de> Cc: Heiko Schocher <hs@denx.de>
> > > > > >>>>
> > > > > >>>> Applied to u-boot/master, thanks!
> > > > > >>>
> > > > > >>> Tom, why are you picking USB changes now? This is creating
> > > > > >>> quite some mess ...
> > > > > >>
> > > > > >> Just trying to clear up the queue of fixes.
> > > > > >
> > > > > > Ok, if you manage to merge it with the USB PR ...
> > > > >
> > > > > Yup, fit right on top. I'll stop being an overarching
> > > > > custodian and let you grab the copyright fix :)
> > > >
> > > > I see discussion , not patch. Link?
> > > >
> > >
> > > Here you are:
> > > http://patchwork.ozlabs.org/patch/257068/
> > >
> > > :-)
> > >
> > > > Best regards,
> > > > Marek Vasut
> > > > _______________________________________________
> > > > U-Boot mailing list
> > > > U-Boot@lists.denx.de
> > > > http://lists.denx.de/mailman/listinfo/u-boot
> > >
> > >
> > > --
> > > Best regards,
> > >
> > > Lukasz Majewski
> > >
> > > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
> > > _______________________________________________
> > > U-Boot mailing list
> > > U-Boot@lists.denx.de
> > > http://lists.denx.de/mailman/listinfo/u-boot
> > >
>
>
> --
> Best regards,
>
> Lukasz Majewski
>
> Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
>
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 07/08/2013 04:59 AM, Sumit Gemini wrote: > HI Lukasz, > > I am using spi nor flash, and may i know the fixes which you > fixed, and all changes. because i am facing problem only in > upload. This means you are not using mainline, as we do not have DFU for SPI. Please post it, or hassle your vendor (I suspect I know who it is) to get the patches posted. Thanks! - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJR2sm9AAoJENk4IS6UOR1WuRUP/iKBpBTUO+hAphWC+kqrjAgn 5z0zQbZNSL4S2eGCdI4ApmVs7uMxavPFf2hukwX4pJal631G8AkAPfgfiYRMYZ3U iv6mkhwSV0IMxE4zemcZkfABILo+O5+2RlJo7QUvSaNs5c3xNBkdIb20797ORinS MNi17zYeFph8NDYz/TTcIE0MWLwcH/skW8jabw6skgaeoEa+wUIJTayExe7thTcJ S1ZuAk6WQ5SKQ5hAdKTjNtPTv35ZK5IFYp1HIKpCiq2RHCUHzuvgdlz60fcbdQSI 9Av9c+9zWO90vEFK+0dT8LkdRylPrGdH/CnRNFep9DKnHUrBPdMGIYN94MRCpIiJ TWIPD2LvquwJAMeARw9Wak+fnTb/7K1xMN2A+LyRV+N6sRgB46b71lQkE/I5+6E3 QC0RD4pG70gXQSmJfolpwgjdk3NvFuzDGTasjW0e23I6znKivGvTJU56fs4lZ9Mi jvRk9qeWVL4JrFXVXcvciRUXgaNk3GNymvkJd+QUybh+ZW09NEaLMpBAye9xg80Q eQd4acdg92P8x7/3avKS8Z2xjWqLvwOPJD8ux2lmEMq6PnVH7bRxHCyW1ZNI4vQk wc9Gbt0TTFVax0v/lxqtXgpr7y4WqjvQPWh1cTErkELo00tdx95q4xeKvQHl4Oyi +h/+U2ot7gBB82SfYk+x =fB83 -----END PGP SIGNATURE-----
diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c index e429d74..0521752 100644 --- a/drivers/dfu/dfu.c +++ b/drivers/dfu/dfu.c @@ -248,7 +248,11 @@ int dfu_read(struct dfu_entity *dfu, void *buf, int size, int blk_seq_num) __func__, dfu->name, buf, size, blk_seq_num, dfu->i_buf); if (!dfu->inited) { - ret = dfu->read_medium(dfu, 0, buf, &dfu->r_left); + dfu->i_buf_start = dfu_get_buf(); + if (dfu->i_buf_start == NULL) + return -ENOMEM; + + ret = dfu->read_medium(dfu, 0, dfu->i_buf_start, &dfu->r_left); if (ret != 0) { debug("%s: failed to get r_left\n", __func__); return ret; @@ -259,9 +263,6 @@ int dfu_read(struct dfu_entity *dfu, void *buf, int size, int blk_seq_num) dfu->i_blk_seq_num = 0; dfu->crc = 0; dfu->offset = 0; - dfu->i_buf_start = dfu_get_buf(); - if (dfu->i_buf_start == NULL) - return -ENOMEM; dfu->i_buf_end = dfu_get_buf() + dfu_buf_size; dfu->i_buf = dfu->i_buf_start; dfu->b_left = 0;
For the first eMMC read of data for upload, use the "large" dfu_buf (now configurable) instead of usb request buffer allocated at composite layer (which is 4KiB) [*]. For eMMC the whole file is read, which usually is larger than the buffer [*] provided with usb request. Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> Cc: Tom Rini <trini@ti.com> Cc: Pantelis Antoniou <panto@antoniou-consulting.com> Cc: Marek Vasut <marex@denx.de> Cc: Heiko Schocher <hs@denx.de> --- drivers/dfu/dfu.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)