| Message ID | 1372870566-11299-2-git-send-email-mihai.caraman@freescale.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On 07/03/2013 11:56:06 AM, Mihai Caraman wrote: > With LRAT (Logical to Real Address Translation) error exception > handler in kernel > KVM needs to add the counterpart otherwise will break the build. > > Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com> > --- > arch/powerpc/kvm/bookehv_interrupts.S | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Please combine these two patches to avoid breaking bisectability. -Scott
On 03.07.2013, at 22:16, Scott Wood wrote: > On 07/03/2013 11:56:06 AM, Mihai Caraman wrote: >> With LRAT (Logical to Real Address Translation) error exception handler in kernel >> KVM needs to add the counterpart otherwise will break the build. >> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com> >> --- >> arch/powerpc/kvm/bookehv_interrupts.S | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) > > Please combine these two patches to avoid breaking bisectability. Why does the split break bisectability? Alex
On 07/03/2013 04:42:40 PM, Alexander Graf wrote: > > On 03.07.2013, at 22:16, Scott Wood wrote: > > > On 07/03/2013 11:56:06 AM, Mihai Caraman wrote: > >> With LRAT (Logical to Real Address Translation) error exception > handler in kernel > >> KVM needs to add the counterpart otherwise will break the build. > >> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com> > >> --- > >> arch/powerpc/kvm/bookehv_interrupts.S | 2 ++ > >> 1 files changed, 2 insertions(+), 0 deletions(-) > > > > Please combine these two patches to avoid breaking bisectability. > > Why does the split break bisectability? Same reason as the altivec build breakage from earlier. If we add a new exception type but not a KVM handler for it, the kernel won't link. -Scott
> -----Original Message----- > From: Wood Scott-B07421 > Sent: Wednesday, July 03, 2013 11:17 PM > To: Caraman Mihai Claudiu-B02008 > Cc: linuxppc-dev@lists.ozlabs.org; kvm-ppc@vger.kernel.org; > kvm@vger.kernel.org; Caraman Mihai Claudiu-B02008 > Subject: Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception > handler > > On 07/03/2013 11:56:06 AM, Mihai Caraman wrote: > > With LRAT (Logical to Real Address Translation) error exception > > handler in kernel > > KVM needs to add the counterpart otherwise will break the build. > > > > Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com> > > --- > > arch/powerpc/kvm/bookehv_interrupts.S | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > Please combine these two patches to avoid breaking bisectability. > > -Scott This is a solid reason. Ben it's ok for you to apply the combined patch? If so I will respin it. -Mike
On Thu, 2013-07-04 at 06:47 +0000, Caraman Mihai Claudiu-B02008 wrote: > This is a solid reason. Ben it's ok for you to apply the combined > patch? If so I will respin it. Sure, but nowadays, all that stuff goes via Scott and Alex. Cheers, Ben.
diff --git a/arch/powerpc/kvm/bookehv_interrupts.S b/arch/powerpc/kvm/bookehv_interrupts.S index e8ed7d6..a0d6929 100644 --- a/arch/powerpc/kvm/bookehv_interrupts.S +++ b/arch/powerpc/kvm/bookehv_interrupts.S @@ -319,6 +319,8 @@ kvm_handler BOOKE_INTERRUPT_DEBUG, EX_PARAMS(DBG), \ SPRN_DSRR0, SPRN_DSRR1, 0 kvm_handler BOOKE_INTERRUPT_DEBUG, EX_PARAMS(CRIT), \ SPRN_CSRR0, SPRN_CSRR1, 0 +kvm_handler BOOKE_INTERRUPT_LRAT_ERROR, EX_PARAMS(GEN), \ + SPRN_SRR0, SPRN_SRR1, (NEED_EMU | NEED_DEAR | NEED_ESR) #else /* * For input register values, see arch/powerpc/include/asm/kvm_booke_hv_asm.h
With LRAT (Logical to Real Address Translation) error exception handler in kernel KVM needs to add the counterpart otherwise will break the build. Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com> --- arch/powerpc/kvm/bookehv_interrupts.S | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)