| Message ID | 1372238906-9346-12-git-send-email-hdoyu@nvidia.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wed, Jun 26, 2013 at 12:28:14PM +0300, Hiroshi Doyu wrote:
> Add of_mach_id for T114
I don't think of_mach_id is the right word. Why not use a subject such
as "iommu/tegra: smmu: Add Tegra114 support". And instead of duplicating
the subject in the commit message, perhaps you can say instead that for
Tegra114 the SMMU is the same as for Tegra30 (which I assume here given
that no code changes are required).
And we really need the nvidia,tegra114-smmu.txt binding documentation.
Either that or update the nvidia,tegra30-smmu.txt with Tegra114 specific
information.
Thierry
diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c index 4c16c90..3e03c69 100644 --- a/drivers/iommu/tegra-smmu.c +++ b/drivers/iommu/tegra-smmu.c @@ -1262,6 +1262,7 @@ const struct dev_pm_ops tegra_smmu_pm_ops = { }; static struct of_device_id tegra_smmu_of_match[] = { + { .compatible = "nvidia,tegra114-smmu", }, { .compatible = "nvidia,tegra30-smmu", }, { }, };
Add of_mach_id for T114 Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com> --- drivers/iommu/tegra-smmu.c | 1 + 1 file changed, 1 insertion(+)