Message ID | 1372055996-4072-13-git-send-email-kraxel@redhat.com |
---|---|
State | New |
Headers | show |
Typo in subject: s/udb/UDP/ Gerd Hoffmann <kraxel@redhat.com> writes: > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > qemu-char.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/qemu-char.c b/qemu-char.c > index 7d072a8..dcc91bb 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -2255,6 +2255,8 @@ static CharDriverState *qemu_chr_open_udp(QemuOpts *opts) > > fd = inet_dgram_opts(opts, &local_err); > if (fd < 0) { > + qerror_report_err(local_err); > + error_free(local_err); > return NULL; > } > return qemu_chr_open_udp_fd(fd); Also plugs memory leak on error path. Worth mentioning in commit message.
diff --git a/qemu-char.c b/qemu-char.c index 7d072a8..dcc91bb 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2255,6 +2255,8 @@ static CharDriverState *qemu_chr_open_udp(QemuOpts *opts) fd = inet_dgram_opts(opts, &local_err); if (fd < 0) { + qerror_report_err(local_err); + error_free(local_err); return NULL; } return qemu_chr_open_udp_fd(fd);
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- qemu-char.c | 2 ++ 1 file changed, 2 insertions(+)