Message ID | 1371731653-13568-1-git-send-email-nikolay@redhat.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Thu, Jun 20, 2013 at 02:34:13PM +0200, nikolay@redhat.com wrote: >From: Nikolay Aleksandrov <nikolay@redhat.com> > >When we have BOND_LINK_UP the speed is reported unconditionally with %u >format although it can be SPEED_UNKNOWN (-1). After this patch it returns >0 in that case in an attempt to keep the existing scripts happy. >One line is intenionally left 81 chars because it gets ugly if broken. > >Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com> > Acked-by: Veaceslav Falico <vfalico@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Veaceslav Falico <vfalico@redhat.com> Date: Thu, 20 Jun 2013 15:42:48 +0200 > On Thu, Jun 20, 2013 at 02:34:13PM +0200, nikolay@redhat.com wrote: >>From: Nikolay Aleksandrov <nikolay@redhat.com> >> >>When we have BOND_LINK_UP the speed is reported unconditionally with >>%u >>format although it can be SPEED_UNKNOWN (-1). After this patch it >>returns >>0 in that case in an attempt to keep the existing scripts happy. >>One line is intenionally left 81 chars because it gets ugly if broken. >> >>Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com> >> > > Acked-by: Veaceslav Falico <vfalico@redhat.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 02d9ae7..f975696 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -2413,7 +2413,8 @@ static void bond_miimon_commit(struct bonding *bond) pr_info("%s: link status definitely up for interface %s, %u Mbps %s duplex.\n", bond->dev->name, slave->dev->name, - slave->speed, slave->duplex ? "full" : "half"); + slave->speed == SPEED_UNKNOWN ? 0 : slave->speed, + slave->duplex ? "full" : "half"); /* notify ad that the link status has changed */ if (bond->params.mode == BOND_MODE_8023AD)