diff mbox

[U-Boot] checkpatch.pl: Do not hardcode perl path

Message ID d25ec307-4f3d-49fc-9af6-e77ec9782553@CH1EHSMHS024.ehs.local
State Changes Requested
Delegated to: Tom Rini
Headers show

Commit Message

Jagannadha Sutradharudu Teki June 16, 2013, 7:16 a.m. UTC 
From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>

checkpatch.pl requires perl v5.10.0 to run but it
doesn't require to place in /usr/bin/perl
Use env to ensure that the interpreter used is the
first one on environment's $PATH on system with
several versions of perl installed.

Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
---
 tools/checkpatch.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Sumit Gemini June 16, 2013, 7:30 a.m. UTC | #1 
Hi ALL,

      Could any buddy tell me how can I define bootcount value after each
reset cycle, right now i am using SRAM but when boot loader pass the
control to kernel, it reset Sram memory so i lost my bootcount value.
please suggest me another idea for storing bootcount value...

My another query is I want to increase my bootcount value when system is
being reset by watchdog only..

Any pointer from you guys would be help me.


Thanks
~Sumit Gemini


On Sun, Jun 16, 2013 at 12:46 PM, Jagannadha Sutradharudu Teki <
jagannadha.sutradharudu-teki@xilinx.com> wrote:

> From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
>
> checkpatch.pl requires perl v5.10.0 to run but it
> doesn't require to place in /usr/bin/perl
> Use env to ensure that the interpreter used is the
> first one on environment's $PATH on system with
> several versions of perl installed.
>
> Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
> ---
>  tools/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
> index 896e2bc..8dc5b9c 100755
> --- a/tools/checkpatch.pl
> +++ b/tools/checkpatch.pl
> @@ -1,10 +1,11 @@
> -#!/usr/bin/perl -w
> +#!/usr/bin/env perl
>  # (c) 2001, Dave Jones. (the file handling bit)
>  # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
>  # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test
> suite)
>  # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
>  # Licensed under the terms of the GNU GPL License version 2
>
> +use warnings;
>  use strict;
>
>  my $P = $0;
> --
> 1.8.3
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Michael Nazzareno Trimarchi June 16, 2013, 10:25 a.m. UTC | #2 
Hi

Il giorno 16/giu/2013 11:55, "Sumit Gemini" <sumit.gemini0@gmail.com> ha
scritto:
>
> Hi ALL,
>
>       Could any buddy tell me how can I define bootcount value after each
> reset cycle, right now i am using SRAM but when boot loader pass the
> control to kernel, it reset Sram memory so i lost my bootcount value.

Is this your comment on the patch?

I suggest to create a new thread and at describe your architecture.

Michael

> please suggest me another idea for storing bootcount value...
>
> My another query is I want to increase my bootcount value when system is
> being reset by watchdog only..
>
> Any pointer from you guys would be help me.
>
>
> Thanks
> ~Sumit Gemini
>
>
> On Sun, Jun 16, 2013 at 12:46 PM, Jagannadha Sutradharudu Teki <
> jagannadha.sutradharudu-teki@xilinx.com> wrote:
>
> > From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
> >
> > checkpatch.pl requires perl v5.10.0 to run but it
> > doesn't require to place in /usr/bin/perl
> > Use env to ensure that the interpreter used is the
> > first one on environment's $PATH on system with
> > several versions of perl installed.
> >
> > Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
> > ---
> >  tools/checkpatch.pl | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
> > index 896e2bc..8dc5b9c 100755
> > --- a/tools/checkpatch.pl
> > +++ b/tools/checkpatch.pl
> > @@ -1,10 +1,11 @@
> > -#!/usr/bin/perl -w
> > +#!/usr/bin/env perl
> >  # (c) 2001, Dave Jones. (the file handling bit)
> >  # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
> >  # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test
> > suite)
> >  # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
> >  # Licensed under the terms of the GNU GPL License version 2
> >
> > +use warnings;
> >  use strict;
> >
> >  my $P = $0;
> > --
> > 1.8.3
> >
> >
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
> >
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Tom Rini June 16, 2013, 1:42 p.m. UTC | #3 
On Sun, Jun 16, 2013 at 12:46:37PM +0530, Jagannadha Sutradharudu Teki wrote:

> From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
> 
> checkpatch.pl requires perl v5.10.0 to run but it
> doesn't require to place in /usr/bin/perl
> Use env to ensure that the interpreter used is the
> first one on environment's $PATH on system with
> several versions of perl installed.
> 
> Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
> ---
>  tools/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
> index 896e2bc..8dc5b9c 100755
> --- a/tools/checkpatch.pl
> +++ b/tools/checkpatch.pl
> @@ -1,10 +1,11 @@
> -#!/usr/bin/perl -w
> +#!/usr/bin/env perl
>  # (c) 2001, Dave Jones. (the file handling bit)
>  # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
>  # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
>  # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
>  # Licensed under the terms of the GNU GPL License version 2
>  
> +use warnings;
>  use strict;
>  
>  my $P = $0;

Lets get this to come in via the kernel please, thanks!
Joel Fernandes June 16, 2013, 3:44 p.m. UTC | #4 
On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote:

> From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com<javascript:;>
> >
>
> checkpatch.pl requires perl v5.10.0 to run but it
> doesn't require to place in /usr/bin/perl
> Use env to ensure that the interpreter used is the
> first one on environment's $PATH on system with
> several versions of perl installed.
>
> Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com<javascript:;>
> >
> ---
>  tools/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
> index 896e2bc..8dc5b9c 100755
> --- a/tools/checkpatch.pl
> +++ b/tools/checkpatch.pl
> @@ -1,10 +1,11 @@
> -#!/usr/bin/perl -w
> +#!/usr/bin/env perl


Would it not work to pass in the -w here?

Joel


>  # (c) 2001, Dave Jones. (the file handling bit)
>  # (c) 2005, Joel Schopp <jschopp@austin.ibm.com <javascript:;>> (the
> ugly bit)
>  # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com <javascript:;>> (new
> conditions, test suite)
>  # (c) 2008-2010 Andy Whitcroft <apw@canonical.com <javascript:;>>
>  # Licensed under the terms of the GNU GPL License version 2
>
> +use warnings;
>  use strict;
>
>  my $P = $0;
> --
> 1.8.3
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de <javascript:;>
> http://lists.denx.de/mailman/listinfo/u-boot
>
Andreas Bießmann June 17, 2013, 6:38 a.m. UTC | #5 
Dear Joel A Fernandes,

On 16.06.13 17:44, Joel A Fernandes wrote:
> On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote:
> 
>> From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com<javascript:;>
>>>
>>
>> checkpatch.pl requires perl v5.10.0 to run but it
>> doesn't require to place in /usr/bin/perl
>> Use env to ensure that the interpreter used is the
>> first one on environment's $PATH on system with
>> several versions of perl installed.
>>
>> Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com<javascript:;>
>>>
>> ---
>>  tools/checkpatch.pl | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
>> index 896e2bc..8dc5b9c 100755
>> --- a/tools/checkpatch.pl
>> +++ b/tools/checkpatch.pl
>> @@ -1,10 +1,11 @@
>> -#!/usr/bin/perl -w
>> +#!/usr/bin/env perl
> 
> 
> Would it not work to pass in the -w here?

this is not portable! BSD variants of env will only take a single parameter.

Best regards

Andreas Bießmann
Joel Fernandes June 17, 2013, 2:47 p.m. UTC | #6 
On Mon, Jun 17, 2013 at 1:38 AM, Andreas Bießmann
<andreas.devel@googlemail.com> wrote:
> Dear Joel A Fernandes,
>
> On 16.06.13 17:44, Joel A Fernandes wrote:
>> On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote:
>>
>>> From: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com<javascript:;>
>>>>
>>>
>>> checkpatch.pl requires perl v5.10.0 to run but it
>>> doesn't require to place in /usr/bin/perl
>>> Use env to ensure that the interpreter used is the
>>> first one on environment's $PATH on system with
>>> several versions of perl installed.
>>>
>>> Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com<javascript:;>
>>>>
>>> ---
>>>  tools/checkpatch.pl | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
>>> index 896e2bc..8dc5b9c 100755
>>> --- a/tools/checkpatch.pl
>>> +++ b/tools/checkpatch.pl
>>> @@ -1,10 +1,11 @@
>>> -#!/usr/bin/perl -w
>>> +#!/usr/bin/env perl
>>
>>
>> Would it not work to pass in the -w here?
>
> this is not portable! BSD variants of env will only take a single parameter.
>

Sure yes I noticed that, this is an acceptable approach though I've
seen some cases people solve the problem using exec.

Thanks,
Joel
diff mbox

Patch

diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
index 896e2bc..8dc5b9c 100755
--- a/tools/checkpatch.pl
+++ b/tools/checkpatch.pl
@@ -1,10 +1,11 @@ 
-#!/usr/bin/perl -w
+#!/usr/bin/env perl
 # (c) 2001, Dave Jones. (the file handling bit)
 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
 # Licensed under the terms of the GNU GPL License version 2
 
+use warnings;
 use strict;
 
 my $P = $0;