| Message ID | 51B791EF.9070904@samsung.com |
|---|---|
| State | New |
| Headers | show |
On Wed, Jun 12, 2013 at 06:09:03AM +0900, Kukjin Kim wrote: > The following changes since commit 317ddd256b9c24b0d78fa8018f80f1e495481a10: > > Linux 3.10-rc5 (2013-06-08 17:41:04 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git > tags/remove-nondt-exynos > > for you to fetch changes up to 8661bc149b95b5d4298b4ffd55c298972c4820d1: > > ARM: exynos4_defconfig: remove non-DT configuration (2013-06-10 > 18:37:01 +0900) > > ---------------------------------------------------------------- > remove non DT support for exynos > > ---------------------------------------------------------------- > Kukjin Kim (2): > ARM: EXYNOS: no more support non-DT for EXYNOS SoCs > ARM: exynos4_defconfig: remove non-DT configuration > > arch/arm/configs/exynos4_defconfig | 68 -------- > arch/arm/mach-exynos/Kconfig | 320 > +----------------------------------- > arch/arm/mach-exynos/Makefile | 26 --- > arch/arm/mach-exynos/common.c | 10 -- > arch/arm/mach-exynos/dev-ahci.c | 255 ----------------------------- > arch/arm/mach-exynos/dev-ohci.c | 52 ------ > arch/arm/mach-exynos/dma.c | 322 > ------------------------------------- > arch/arm/mach-exynos/pm_domains.c | 7 - > 8 files changed, 1 insertion(+), 1059 deletions(-) > delete mode 100644 arch/arm/configs/exynos4_defconfig > delete mode 100644 arch/arm/mach-exynos/dev-ahci.c > delete mode 100644 arch/arm/mach-exynos/dev-ohci.c > delete mode 100644 arch/arm/mach-exynos/dma.c Kukjin, What about the legacy board files? I don't see them removed (nor converted to DT) here, so this is not a full removal. Also, the argument to keep exynos4_defconfig was that it needed to enable non-DT boards. I think we might as well just remove the defconfig and make sure all the needed options are enabled in exynos_defconfig -- they should coexist just fine. I'll hold off pulling until the defconfig situation has been resolved, but please follow up on the board file piece too. -Olof
Olof Johansson wrote: > > On Wed, Jun 12, 2013 at 06:09:03AM +0900, Kukjin Kim wrote: > > The following changes since commit > 317ddd256b9c24b0d78fa8018f80f1e495481a10: > > > > Linux 3.10-rc5 (2013-06-08 17:41:04 -0700) > > > > are available in the git repository at: > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git > > tags/remove-nondt-exynos > > > > for you to fetch changes up to 8661bc149b95b5d4298b4ffd55c298972c4820d1: > > > > ARM: exynos4_defconfig: remove non-DT configuration (2013-06-10 > > 18:37:01 +0900) > > > > ---------------------------------------------------------------- > > remove non DT support for exynos > > > > ---------------------------------------------------------------- > > Kukjin Kim (2): > > ARM: EXYNOS: no more support non-DT for EXYNOS SoCs > > ARM: exynos4_defconfig: remove non-DT configuration > > > > arch/arm/configs/exynos4_defconfig | 68 -------- > > arch/arm/mach-exynos/Kconfig | 320 > > +----------------------------------- > > arch/arm/mach-exynos/Makefile | 26 --- > > arch/arm/mach-exynos/common.c | 10 -- > > arch/arm/mach-exynos/dev-ahci.c | 255 ----------------------------- > > arch/arm/mach-exynos/dev-ohci.c | 52 ------ > > arch/arm/mach-exynos/dma.c | 322 > > ------------------------------------- > > arch/arm/mach-exynos/pm_domains.c | 7 - > > 8 files changed, 1 insertion(+), 1059 deletions(-) > > delete mode 100644 arch/arm/configs/exynos4_defconfig > > delete mode 100644 arch/arm/mach-exynos/dev-ahci.c > > delete mode 100644 arch/arm/mach-exynos/dev-ohci.c > > delete mode 100644 arch/arm/mach-exynos/dma.c > > Kukjin, > Hi Olof, > What about the legacy board files? I don't see them removed (nor converted > to > DT) here, so this is not a full removal. > Oops, why are there still the board files :( Probably, there was a mistake... Thanks. > Also, the argument to keep exynos4_defconfig was that it needed to enable > non-DT boards. I think we might as well just remove the defconfig and make > sure > all the needed options are enabled in exynos_defconfig -- they should > coexist > just fine. > OK agreed. > I'll hold off pulling until the defconfig situation has been resolved, but > please follow up on the board file piece too. > Sure, thanks. - Kukjin
On Fri, Jun 14, 2013 at 6:17 AM, Arnd Bergmann <arnd@arndb.de> wrote: > After exynos has been converted to DT-only booting by removing > most a lot of the ATAGS code, I had a closer look of what is > left. It turns out that a number of unused files are left in > the tree that can be removed along with about another quarter > of the remaining code in mach-exynos. > > Specifically this includes: > > * all board files > * all setup-*.c files > * dev-audio.c and dev-uart.c > * all code testing for of_have_populated_dt > * the eint_irqchip > * almost all the mach/irqs.h constants (the remaining ones > are likely bugs) > * Most physical address constants. The remaining ones are > either bugs or used for the iotable. Both can probably > get removed in the long run. > * regs-usb-phy.h, which was already unused before > * A lot of code in plat-samsung/ can be made conditional > on CONFIG_ATAGS, in particular now unused device > definitions. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Olof Johansson <olof@lixom.net> > Hi Kukjin, > > Could you check the validity of this patch please? > > I think we should apply it on top of your series. I've generated > the patch using 'git format-patch -D' for brevity, so be careful > to actually delete the unused files if you want to apply it to > a local branch on your side. Great. This is the piece that I wanted to see in the non-DT-removal branch before I pulled it. -Olof
Olof Johansson wrote: > > On Fri, Jun 14, 2013 at 6:17 AM, Arnd Bergmann <arnd@arndb.de> wrote: > > After exynos has been converted to DT-only booting by removing > > most a lot of the ATAGS code, I had a closer look of what is > > left. It turns out that a number of unused files are left in > > the tree that can be removed along with about another quarter > > of the remaining code in mach-exynos. > > > > Specifically this includes: > > > > * all board files > > * all setup-*.c files > > * dev-audio.c and dev-uart.c > > * all code testing for of_have_populated_dt > > * the eint_irqchip > > * almost all the mach/irqs.h constants (the remaining ones > > are likely bugs) > > * Most physical address constants. The remaining ones are > > either bugs or used for the iotable. Both can probably > > get removed in the long run. > > * regs-usb-phy.h, which was already unused before > > * A lot of code in plat-samsung/ can be made conditional > > on CONFIG_ATAGS, in particular now unused device > > definitions. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Acked-by: Olof Johansson <olof@lixom.net> > > > Hi Kukjin, > > > > Could you check the validity of this patch please? > > > > I think we should apply it on top of your series. I've generated > > the patch using 'git format-patch -D' for brevity, so be careful > > to actually delete the unused files if you want to apply it to > > a local branch on your side. > > Great. This is the piece that I wanted to see in the non-DT-removal > branch before I pulled it. > Yeah, I think so. But as Arnd suggested, I'm looking at Tomasz's patches and it will be sorted out in this weekend. Thanks, - Kukjin
On Fri, Jun 14, 2013 at 7:24 PM, Kukjin Kim <kgene.kim@samsung.com> wrote: > Olof Johansson wrote: >> >> On Fri, Jun 14, 2013 at 6:17 AM, Arnd Bergmann <arnd@arndb.de> wrote: >> > After exynos has been converted to DT-only booting by removing >> > most a lot of the ATAGS code, I had a closer look of what is >> > left. It turns out that a number of unused files are left in >> > the tree that can be removed along with about another quarter >> > of the remaining code in mach-exynos. >> > >> > Specifically this includes: >> > >> > * all board files >> > * all setup-*.c files >> > * dev-audio.c and dev-uart.c >> > * all code testing for of_have_populated_dt >> > * the eint_irqchip >> > * almost all the mach/irqs.h constants (the remaining ones >> > are likely bugs) >> > * Most physical address constants. The remaining ones are >> > either bugs or used for the iotable. Both can probably >> > get removed in the long run. >> > * regs-usb-phy.h, which was already unused before >> > * A lot of code in plat-samsung/ can be made conditional >> > on CONFIG_ATAGS, in particular now unused device >> > definitions. >> > >> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> >> Acked-by: Olof Johansson <olof@lixom.net> >> >> > Hi Kukjin, >> > >> > Could you check the validity of this patch please? >> > >> > I think we should apply it on top of your series. I've generated >> > the patch using 'git format-patch -D' for brevity, so be careful >> > to actually delete the unused files if you want to apply it to >> > a local branch on your side. >> >> Great. This is the piece that I wanted to see in the non-DT-removal >> branch before I pulled it. >> > Yeah, I think so. But as Arnd suggested, I'm looking at Tomasz's patches and > it will be sorted out in this weekend. Yes, please pick up Thomasz' patches instead (and his follow-up ones early next week). -Olof
The following changes since commit 317ddd256b9c24b0d78fa8018f80f1e495481a10: Linux 3.10-rc5 (2013-06-08 17:41:04 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/remove-nondt-exynos for you to fetch changes up to 8661bc149b95b5d4298b4ffd55c298972c4820d1: ARM: exynos4_defconfig: remove non-DT configuration (2013-06-10 18:37:01 +0900) ---------------------------------------------------------------- remove non DT support for exynos ---------------------------------------------------------------- Kukjin Kim (2): ARM: EXYNOS: no more support non-DT for EXYNOS SoCs ARM: exynos4_defconfig: remove non-DT configuration arch/arm/configs/exynos4_defconfig | 68 -------- arch/arm/mach-exynos/Kconfig | 320 +----------------------------------- arch/arm/mach-exynos/Makefile | 26 --- arch/arm/mach-exynos/common.c | 10 -- arch/arm/mach-exynos/dev-ahci.c | 255 ----------------------------- arch/arm/mach-exynos/dev-ohci.c | 52 ------ arch/arm/mach-exynos/dma.c | 322 ------------------------------------- arch/arm/mach-exynos/pm_domains.c | 7 - 8 files changed, 1 insertion(+), 1059 deletions(-) delete mode 100644 arch/arm/configs/exynos4_defconfig delete mode 100644 arch/arm/mach-exynos/dev-ahci.c delete mode 100644 arch/arm/mach-exynos/dev-ohci.c delete mode 100644 arch/arm/mach-exynos/dma.c