| Message ID | 1371215539.3888.1.camel@phoenix |
|---|---|
| State | Accepted |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
On 14/06/13 09:12 AM, Axel Lin wrote: > This change slightly improves readability. > > Signed-off-by: Axel Lin<axel.lin@ingics.com> > --- > drivers/spi/cf_qspi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/cf_qspi.c b/drivers/spi/cf_qspi.c > index a37ac4e..06bcf91 100644 > --- a/drivers/spi/cf_qspi.c > +++ b/drivers/spi/cf_qspi.c > @@ -171,7 +171,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout, > volatile qspi_t *qspi = dev->regs; > u8 *txbuf = (u8 *)dout; > u8 *rxbuf = (u8 *)din; > - u32 count = ((bitlen / 8) + (bitlen % 8 ? 1 : 0)); > + u32 count = DIV_ROUND_UP(bitlen, 8); > u32 n, i = 0; > > /* Sanitize arguments */ ACK. Thanks for the cleanup. Signed-off-by: Richard Retanubun<richardretanubun@ruggedcom.com>
On 14-06-2013 18:45, Richard Retanubun wrote: > On 14/06/13 09:12 AM, Axel Lin wrote: >> This change slightly improves readability. >> >> Signed-off-by: Axel Lin<axel.lin@ingics.com> >> --- >> drivers/spi/cf_qspi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/spi/cf_qspi.c b/drivers/spi/cf_qspi.c >> index a37ac4e..06bcf91 100644 >> --- a/drivers/spi/cf_qspi.c >> +++ b/drivers/spi/cf_qspi.c >> @@ -171,7 +171,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int >> bitlen, const void *dout, >> volatile qspi_t *qspi = dev->regs; >> u8 *txbuf = (u8 *)dout; >> u8 *rxbuf = (u8 *)din; >> - u32 count = ((bitlen / 8) + (bitlen % 8 ? 1 : 0)); >> + u32 count = DIV_ROUND_UP(bitlen, 8); >> u32 n, i = 0; >> >> /* Sanitize arguments */ > ACK. Thanks for the cleanup. > > Signed-off-by: Richard Retanubun<richardretanubun@ruggedcom.com> Reviewed-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com> -- Thanks, Jagan.
On 14-06-2013 20:40, Jagan Teki wrote: > On 14-06-2013 18:45, Richard Retanubun wrote: >> On 14/06/13 09:12 AM, Axel Lin wrote: >>> This change slightly improves readability. >>> >>> Signed-off-by: Axel Lin<axel.lin@ingics.com> >>> --- >>> drivers/spi/cf_qspi.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/spi/cf_qspi.c b/drivers/spi/cf_qspi.c >>> index a37ac4e..06bcf91 100644 >>> --- a/drivers/spi/cf_qspi.c >>> +++ b/drivers/spi/cf_qspi.c >>> @@ -171,7 +171,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int >>> bitlen, const void *dout, >>> volatile qspi_t *qspi = dev->regs; >>> u8 *txbuf = (u8 *)dout; >>> u8 *rxbuf = (u8 *)din; >>> - u32 count = ((bitlen / 8) + (bitlen % 8 ? 1 : 0)); >>> + u32 count = DIV_ROUND_UP(bitlen, 8); >>> u32 n, i = 0; >>> >>> /* Sanitize arguments */ >> ACK. Thanks for the cleanup. >> >> Signed-off-by: Richard Retanubun<richardretanubun@ruggedcom.com> > > Reviewed-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com> Applied to u-boot-spi/master -- Thanks, Jagan.
diff --git a/drivers/spi/cf_qspi.c b/drivers/spi/cf_qspi.c index a37ac4e..06bcf91 100644 --- a/drivers/spi/cf_qspi.c +++ b/drivers/spi/cf_qspi.c @@ -171,7 +171,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout, volatile qspi_t *qspi = dev->regs; u8 *txbuf = (u8 *)dout; u8 *rxbuf = (u8 *)din; - u32 count = ((bitlen / 8) + (bitlen % 8 ? 1 : 0)); + u32 count = DIV_ROUND_UP(bitlen, 8); u32 n, i = 0; /* Sanitize arguments */
This change slightly improves readability. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/spi/cf_qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)