| Message ID | 3f3d7c43-a9e1-437a-a387-ea204b1f8055@CH1EHSMHS001.ehs.local |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On Fri, Jun 14, 2013 at 12:20:11AM +0530, Jagannadha Sutradharudu Teki wrote: > The following changes since commit 48e0b2bd2b6ecc80cd25181ca2fb9c0eaffef320: > > powerpc/esdhc: Correct judgement for DATA PIO mode (2013-05-15 18:18:16 -0500) > > are available in the git repository at: > > git://git.denx.de/u-boot-spi.git master > > for you to fetch changes up to ea7fcc5aeb10d2cbb5589e91f36b205dcaf4b7a8: > > sf: winbond: Correct the nr_blocks used for W25Q32DW (2013-06-13 23:42:46 +0530) > > ---------------------------------------------------------------- > Axel Lin (3): > spi: armada100_spi: Remove unnecessary NULL test for dout and din > spi: tegra114_spi: Convert to use spi_alloc_slave() > spi: tegra20_sflash: Remove redundant code to set bus and cs of struct spi_slave > > Jagannadha Sutradharudu Teki (7): > sf: winbond: Add support for W25Q256 > sf: Fix sf read for memory-mapped SPI flashes > cmd_sf: Add print mesg for 'sf erase' command > cmd_sf: Add print mesgs on sf read/write commands > sf: spansion: Update the name for S25FL256S flash > sf: winbond: Add support for W25Q80BW > sf: winbond: Correct the nr_blocks used for W25Q32DW > > Kuo-Jung Su (1): > sf: winbond: Add support for W25PXX SPI flash > > Marek Vasut (1): > sf: spansion: Add Spansion S25FL064P IDs > > Rajeshwari Shinde (2): > spi: Add support for preamble bytes > spi: exynos: Support SPI_PREAMBLE mode > > common/cmd_sf.c | 34 ++++++++++++---------- > drivers/mtd/spi/spansion.c | 9 +++++- > drivers/mtd/spi/spi_flash.c | 14 ++++----- > drivers/mtd/spi/winbond.c | 28 +++++++++++++++--- > drivers/spi/armada100_spi.c | 11 ++----- > drivers/spi/exynos_spi.c | 69 +++++++++++++++++++++++++++++++++++++------- > drivers/spi/tegra114_spi.c | 4 +-- > drivers/spi/tegra20_sflash.c | 2 -- > include/spi.h | 5 ++++ > 9 files changed, 122 insertions(+), 54 deletions(-) Trying this on am335x_evm, booting from SPI: SF: Detected W25Q64 with page size 4 KiB, total 8 MiB U-Boot SPL 2013.04-00626-gf0df254 (Jun 14 2013 - 09:43:52) SPI error: malloc of SPI structure failed SF: Failed to set up slave SPI probe failed. ### ERROR ### Please RESET the board ### malloc should have been initalized already, digging further.
On 14-06-2013 20:06, Tom Rini wrote: > On Fri, Jun 14, 2013 at 12:20:11AM +0530, Jagannadha Sutradharudu Teki wrote: > >> The following changes since commit 48e0b2bd2b6ecc80cd25181ca2fb9c0eaffef320: >> >> powerpc/esdhc: Correct judgement for DATA PIO mode (2013-05-15 18:18:16 -0500) >> >> are available in the git repository at: >> >> git://git.denx.de/u-boot-spi.git master >> >> for you to fetch changes up to ea7fcc5aeb10d2cbb5589e91f36b205dcaf4b7a8: >> >> sf: winbond: Correct the nr_blocks used for W25Q32DW (2013-06-13 23:42:46 +0530) >> >> ---------------------------------------------------------------- >> Axel Lin (3): >> spi: armada100_spi: Remove unnecessary NULL test for dout and din >> spi: tegra114_spi: Convert to use spi_alloc_slave() >> spi: tegra20_sflash: Remove redundant code to set bus and cs of struct spi_slave >> >> Jagannadha Sutradharudu Teki (7): >> sf: winbond: Add support for W25Q256 >> sf: Fix sf read for memory-mapped SPI flashes >> cmd_sf: Add print mesg for 'sf erase' command >> cmd_sf: Add print mesgs on sf read/write commands >> sf: spansion: Update the name for S25FL256S flash >> sf: winbond: Add support for W25Q80BW >> sf: winbond: Correct the nr_blocks used for W25Q32DW >> >> Kuo-Jung Su (1): >> sf: winbond: Add support for W25PXX SPI flash >> >> Marek Vasut (1): >> sf: spansion: Add Spansion S25FL064P IDs >> >> Rajeshwari Shinde (2): >> spi: Add support for preamble bytes >> spi: exynos: Support SPI_PREAMBLE mode >> >> common/cmd_sf.c | 34 ++++++++++++---------- >> drivers/mtd/spi/spansion.c | 9 +++++- >> drivers/mtd/spi/spi_flash.c | 14 ++++----- >> drivers/mtd/spi/winbond.c | 28 +++++++++++++++--- >> drivers/spi/armada100_spi.c | 11 ++----- >> drivers/spi/exynos_spi.c | 69 +++++++++++++++++++++++++++++++++++++------- >> drivers/spi/tegra114_spi.c | 4 +-- >> drivers/spi/tegra20_sflash.c | 2 -- >> include/spi.h | 5 ++++ >> 9 files changed, 122 insertions(+), 54 deletions(-) > > Trying this on am335x_evm, booting from SPI: > SF: Detected W25Q64 with page size 4 KiB, total 8 MiB It's passed here? > > U-Boot SPL 2013.04-00626-gf0df254 (Jun 14 2013 - 09:43:52) > SPI error: malloc of SPI structure failed > SF: Failed to set up slave > SPI probe failed. > ### ERROR ### Please RESET the board ### > > malloc should have been initalized already, digging further. Was this working earlier releases? No changes w.r.t sf framework on current tree as of now. Need to dig further and let you know. -- Thanks, Jagan.
On Fri, Jun 14, 2013 at 08:15:04PM +0530, Jagan Teki wrote: > On 14-06-2013 20:06, Tom Rini wrote: > >On Fri, Jun 14, 2013 at 12:20:11AM +0530, Jagannadha Sutradharudu Teki wrote: > > > >>The following changes since commit 48e0b2bd2b6ecc80cd25181ca2fb9c0eaffef320: > >> > >> powerpc/esdhc: Correct judgement for DATA PIO mode (2013-05-15 18:18:16 -0500) > >> > >>are available in the git repository at: > >> > >> git://git.denx.de/u-boot-spi.git master > >> > >>for you to fetch changes up to ea7fcc5aeb10d2cbb5589e91f36b205dcaf4b7a8: > >> > >> sf: winbond: Correct the nr_blocks used for W25Q32DW (2013-06-13 23:42:46 +0530) > >> > >>---------------------------------------------------------------- > >>Axel Lin (3): > >> spi: armada100_spi: Remove unnecessary NULL test for dout and din > >> spi: tegra114_spi: Convert to use spi_alloc_slave() > >> spi: tegra20_sflash: Remove redundant code to set bus and cs of struct spi_slave > >> > >>Jagannadha Sutradharudu Teki (7): > >> sf: winbond: Add support for W25Q256 > >> sf: Fix sf read for memory-mapped SPI flashes > >> cmd_sf: Add print mesg for 'sf erase' command > >> cmd_sf: Add print mesgs on sf read/write commands > >> sf: spansion: Update the name for S25FL256S flash > >> sf: winbond: Add support for W25Q80BW > >> sf: winbond: Correct the nr_blocks used for W25Q32DW > >> > >>Kuo-Jung Su (1): > >> sf: winbond: Add support for W25PXX SPI flash > >> > >>Marek Vasut (1): > >> sf: spansion: Add Spansion S25FL064P IDs > >> > >>Rajeshwari Shinde (2): > >> spi: Add support for preamble bytes > >> spi: exynos: Support SPI_PREAMBLE mode > >> > >> common/cmd_sf.c | 34 ++++++++++++---------- > >> drivers/mtd/spi/spansion.c | 9 +++++- > >> drivers/mtd/spi/spi_flash.c | 14 ++++----- > >> drivers/mtd/spi/winbond.c | 28 +++++++++++++++--- > >> drivers/spi/armada100_spi.c | 11 ++----- > >> drivers/spi/exynos_spi.c | 69 +++++++++++++++++++++++++++++++++++++------- > >> drivers/spi/tegra114_spi.c | 4 +-- > >> drivers/spi/tegra20_sflash.c | 2 -- > >> include/spi.h | 5 ++++ > >> 9 files changed, 122 insertions(+), 54 deletions(-) > > > >Trying this on am335x_evm, booting from SPI: > >SF: Detected W25Q64 with page size 4 KiB, total 8 MiB > It's passed here? > > > > >U-Boot SPL 2013.04-00626-gf0df254 (Jun 14 2013 - 09:43:52) > >SPI error: malloc of SPI structure failed > >SF: Failed to set up slave > >SPI probe failed. > >### ERROR ### Please RESET the board ### > > > >malloc should have been initalized already, digging further. > Was this working earlier releases? > No changes w.r.t sf framework on current tree as of now. > > Need to dig further and let you know. OK, I'm digging into making sure this isn't a local problem, which it might just be :(
On Fri, Jun 14, 2013 at 10:51:05AM -0400, Tom Rini wrote: > On Fri, Jun 14, 2013 at 08:15:04PM +0530, Jagan Teki wrote: > > On 14-06-2013 20:06, Tom Rini wrote: > > >On Fri, Jun 14, 2013 at 12:20:11AM +0530, Jagannadha Sutradharudu Teki wrote: > > > > > >>The following changes since commit 48e0b2bd2b6ecc80cd25181ca2fb9c0eaffef320: > > >> > > >> powerpc/esdhc: Correct judgement for DATA PIO mode (2013-05-15 18:18:16 -0500) > > >> > > >>are available in the git repository at: > > >> > > >> git://git.denx.de/u-boot-spi.git master > > >> > > >>for you to fetch changes up to ea7fcc5aeb10d2cbb5589e91f36b205dcaf4b7a8: > > >> > > >> sf: winbond: Correct the nr_blocks used for W25Q32DW (2013-06-13 23:42:46 +0530) > > >> > > >>---------------------------------------------------------------- > > >>Axel Lin (3): > > >> spi: armada100_spi: Remove unnecessary NULL test for dout and din > > >> spi: tegra114_spi: Convert to use spi_alloc_slave() > > >> spi: tegra20_sflash: Remove redundant code to set bus and cs of struct spi_slave > > >> > > >>Jagannadha Sutradharudu Teki (7): > > >> sf: winbond: Add support for W25Q256 > > >> sf: Fix sf read for memory-mapped SPI flashes > > >> cmd_sf: Add print mesg for 'sf erase' command > > >> cmd_sf: Add print mesgs on sf read/write commands > > >> sf: spansion: Update the name for S25FL256S flash > > >> sf: winbond: Add support for W25Q80BW > > >> sf: winbond: Correct the nr_blocks used for W25Q32DW > > >> > > >>Kuo-Jung Su (1): > > >> sf: winbond: Add support for W25PXX SPI flash > > >> > > >>Marek Vasut (1): > > >> sf: spansion: Add Spansion S25FL064P IDs > > >> > > >>Rajeshwari Shinde (2): > > >> spi: Add support for preamble bytes > > >> spi: exynos: Support SPI_PREAMBLE mode > > >> > > >> common/cmd_sf.c | 34 ++++++++++++---------- > > >> drivers/mtd/spi/spansion.c | 9 +++++- > > >> drivers/mtd/spi/spi_flash.c | 14 ++++----- > > >> drivers/mtd/spi/winbond.c | 28 +++++++++++++++--- > > >> drivers/spi/armada100_spi.c | 11 ++----- > > >> drivers/spi/exynos_spi.c | 69 +++++++++++++++++++++++++++++++++++++------- > > >> drivers/spi/tegra114_spi.c | 4 +-- > > >> drivers/spi/tegra20_sflash.c | 2 -- > > >> include/spi.h | 5 ++++ > > >> 9 files changed, 122 insertions(+), 54 deletions(-) > > > > > >Trying this on am335x_evm, booting from SPI: > > >SF: Detected W25Q64 with page size 4 KiB, total 8 MiB > > It's passed here? > > > > > > > >U-Boot SPL 2013.04-00626-gf0df254 (Jun 14 2013 - 09:43:52) > > >SPI error: malloc of SPI structure failed > > >SF: Failed to set up slave > > >SPI probe failed. > > >### ERROR ### Please RESET the board ### > > > > > >malloc should have been initalized already, digging further. > > Was this working earlier releases? > > No changes w.r.t sf framework on current tree as of now. > > > > Need to dig further and let you know. > > OK, I'm digging into making sure this isn't a local problem, which it > might just be :( Local problem, please disregard.
On Fri, Jun 14, 2013 at 8:23 PM, Tom Rini <trini@ti.com> wrote: > On Fri, Jun 14, 2013 at 10:51:05AM -0400, Tom Rini wrote: >> On Fri, Jun 14, 2013 at 08:15:04PM +0530, Jagan Teki wrote: >> > On 14-06-2013 20:06, Tom Rini wrote: >> > >On Fri, Jun 14, 2013 at 12:20:11AM +0530, Jagannadha Sutradharudu Teki wrote: >> > > >> > >>The following changes since commit 48e0b2bd2b6ecc80cd25181ca2fb9c0eaffef320: >> > >> >> > >> powerpc/esdhc: Correct judgement for DATA PIO mode (2013-05-15 18:18:16 -0500) >> > >> >> > >>are available in the git repository at: >> > >> >> > >> git://git.denx.de/u-boot-spi.git master >> > >> >> > >>for you to fetch changes up to ea7fcc5aeb10d2cbb5589e91f36b205dcaf4b7a8: >> > >> >> > >> sf: winbond: Correct the nr_blocks used for W25Q32DW (2013-06-13 23:42:46 +0530) >> > >> >> > >>---------------------------------------------------------------- >> > >>Axel Lin (3): >> > >> spi: armada100_spi: Remove unnecessary NULL test for dout and din >> > >> spi: tegra114_spi: Convert to use spi_alloc_slave() >> > >> spi: tegra20_sflash: Remove redundant code to set bus and cs of struct spi_slave >> > >> >> > >>Jagannadha Sutradharudu Teki (7): >> > >> sf: winbond: Add support for W25Q256 >> > >> sf: Fix sf read for memory-mapped SPI flashes >> > >> cmd_sf: Add print mesg for 'sf erase' command >> > >> cmd_sf: Add print mesgs on sf read/write commands >> > >> sf: spansion: Update the name for S25FL256S flash >> > >> sf: winbond: Add support for W25Q80BW >> > >> sf: winbond: Correct the nr_blocks used for W25Q32DW >> > >> >> > >>Kuo-Jung Su (1): >> > >> sf: winbond: Add support for W25PXX SPI flash >> > >> >> > >>Marek Vasut (1): >> > >> sf: spansion: Add Spansion S25FL064P IDs >> > >> >> > >>Rajeshwari Shinde (2): >> > >> spi: Add support for preamble bytes >> > >> spi: exynos: Support SPI_PREAMBLE mode >> > >> >> > >> common/cmd_sf.c | 34 ++++++++++++---------- >> > >> drivers/mtd/spi/spansion.c | 9 +++++- >> > >> drivers/mtd/spi/spi_flash.c | 14 ++++----- >> > >> drivers/mtd/spi/winbond.c | 28 +++++++++++++++--- >> > >> drivers/spi/armada100_spi.c | 11 ++----- >> > >> drivers/spi/exynos_spi.c | 69 +++++++++++++++++++++++++++++++++++++------- >> > >> drivers/spi/tegra114_spi.c | 4 +-- >> > >> drivers/spi/tegra20_sflash.c | 2 -- >> > >> include/spi.h | 5 ++++ >> > >> 9 files changed, 122 insertions(+), 54 deletions(-) >> > > >> > >Trying this on am335x_evm, booting from SPI: >> > >SF: Detected W25Q64 with page size 4 KiB, total 8 MiB >> > It's passed here? >> > >> > > >> > >U-Boot SPL 2013.04-00626-gf0df254 (Jun 14 2013 - 09:43:52) >> > >SPI error: malloc of SPI structure failed >> > >SF: Failed to set up slave >> > >SPI probe failed. >> > >### ERROR ### Please RESET the board ### >> > > >> > >malloc should have been initalized already, digging further. >> > Was this working earlier releases? >> > No changes w.r.t sf framework on current tree as of now. >> > >> > Need to dig further and let you know. >> >> OK, I'm digging into making sure this isn't a local problem, which it >> might just be :( > > Local problem, please disregard. I can say there is no issue w.r.t recent change from Simon. [moving malloc with global function spi_alloc_slave()] http://git.denx.de/?p=u-boot/u-boot-spi.git;a=commitdiff;h=d3504fee73ec626117427afa08116d1dde21ba9d -- Thanks, Jagan.
On Fri, Jun 14, 2013 at 12:20:11AM +0530, Jagannadha Sutradharudu Teki wrote: > The following changes since commit 48e0b2bd2b6ecc80cd25181ca2fb9c0eaffef320: > > powerpc/esdhc: Correct judgement for DATA PIO mode (2013-05-15 18:18:16 -0500) > > are available in the git repository at: > > git://git.denx.de/u-boot-spi.git master > > for you to fetch changes up to ea7fcc5aeb10d2cbb5589e91f36b205dcaf4b7a8: > > sf: winbond: Correct the nr_blocks used for W25Q32DW (2013-06-13 23:42:46 +0530) > > ---------------------------------------------------------------- > Axel Lin (3): > spi: armada100_spi: Remove unnecessary NULL test for dout and din > spi: tegra114_spi: Convert to use spi_alloc_slave() > spi: tegra20_sflash: Remove redundant code to set bus and cs of struct spi_slave > > Jagannadha Sutradharudu Teki (7): > sf: winbond: Add support for W25Q256 > sf: Fix sf read for memory-mapped SPI flashes > cmd_sf: Add print mesg for 'sf erase' command > cmd_sf: Add print mesgs on sf read/write commands > sf: spansion: Update the name for S25FL256S flash > sf: winbond: Add support for W25Q80BW > sf: winbond: Correct the nr_blocks used for W25Q32DW > > Kuo-Jung Su (1): > sf: winbond: Add support for W25PXX SPI flash > > Marek Vasut (1): > sf: spansion: Add Spansion S25FL064P IDs > > Rajeshwari Shinde (2): > spi: Add support for preamble bytes > spi: exynos: Support SPI_PREAMBLE mode > > common/cmd_sf.c | 34 ++++++++++++---------- > drivers/mtd/spi/spansion.c | 9 +++++- > drivers/mtd/spi/spi_flash.c | 14 ++++----- > drivers/mtd/spi/winbond.c | 28 +++++++++++++++--- > drivers/spi/armada100_spi.c | 11 ++----- > drivers/spi/exynos_spi.c | 69 +++++++++++++++++++++++++++++++++++++------- > drivers/spi/tegra114_spi.c | 4 +-- > drivers/spi/tegra20_sflash.c | 2 -- > include/spi.h | 5 ++++ > 9 files changed, 122 insertions(+), 54 deletions(-) Booted on am335x_evm via SPI and applied to u-boot/master, thanks!
The following changes since commit 48e0b2bd2b6ecc80cd25181ca2fb9c0eaffef320: powerpc/esdhc: Correct judgement for DATA PIO mode (2013-05-15 18:18:16 -0500) are available in the git repository at: git://git.denx.de/u-boot-spi.git master for you to fetch changes up to ea7fcc5aeb10d2cbb5589e91f36b205dcaf4b7a8: sf: winbond: Correct the nr_blocks used for W25Q32DW (2013-06-13 23:42:46 +0530) ---------------------------------------------------------------- Axel Lin (3): spi: armada100_spi: Remove unnecessary NULL test for dout and din spi: tegra114_spi: Convert to use spi_alloc_slave() spi: tegra20_sflash: Remove redundant code to set bus and cs of struct spi_slave Jagannadha Sutradharudu Teki (7): sf: winbond: Add support for W25Q256 sf: Fix sf read for memory-mapped SPI flashes cmd_sf: Add print mesg for 'sf erase' command cmd_sf: Add print mesgs on sf read/write commands sf: spansion: Update the name for S25FL256S flash sf: winbond: Add support for W25Q80BW sf: winbond: Correct the nr_blocks used for W25Q32DW Kuo-Jung Su (1): sf: winbond: Add support for W25PXX SPI flash Marek Vasut (1): sf: spansion: Add Spansion S25FL064P IDs Rajeshwari Shinde (2): spi: Add support for preamble bytes spi: exynos: Support SPI_PREAMBLE mode common/cmd_sf.c | 34 ++++++++++++---------- drivers/mtd/spi/spansion.c | 9 +++++- drivers/mtd/spi/spi_flash.c | 14 ++++----- drivers/mtd/spi/winbond.c | 28 +++++++++++++++--- drivers/spi/armada100_spi.c | 11 ++----- drivers/spi/exynos_spi.c | 69 +++++++++++++++++++++++++++++++++++++------- drivers/spi/tegra114_spi.c | 4 +-- drivers/spi/tegra20_sflash.c | 2 -- include/spi.h | 5 ++++ 9 files changed, 122 insertions(+), 54 deletions(-)