| Message ID | 1371131298-2059-1-git-send-email-paul.gortmaker@windriver.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Thu, Jun 13, 2013 at 09:48:18AM -0400, Paul Gortmaker wrote: > The code refactoring in commit "ext4: refactor punch hole code" > left behind a now unused variable, causing: > > fs/ext4/inode.c: In function ‘ext4_punch_hole’: > fs/ext4/inode.c:3495:24: warning: unused variable ‘mapping’ [-Wunused-variable] > > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Thanks, I had actually noticed this already, but I had pushed out the wrong version to the dev branch. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 4411130..2644679 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -3492,7 +3492,6 @@ int ext4_punch_hole(struct file *file, loff_t offset, loff_t length) struct inode *inode = file_inode(file); struct super_block *sb = inode->i_sb; ext4_lblk_t first_block, stop_block; - struct address_space *mapping = inode->i_mapping; loff_t first_block_offset, last_block_offset; handle_t *handle; unsigned int credits;
The code refactoring in commit "ext4: refactor punch hole code" left behind a now unused variable, causing: fs/ext4/inode.c: In function ‘ext4_punch_hole’: fs/ext4/inode.c:3495:24: warning: unused variable ‘mapping’ [-Wunused-variable] Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- [Feel free to also fold this trivial change back into the original punch hole commit on the dev branch] fs/ext4/inode.c | 1 - 1 file changed, 1 deletion(-)