| Message ID | 1370647138-26623-9-git-send-email-spenser@gillilanding.com |
|---|---|
| State | Superseded |
| Headers | show |
On 08/06/13 01:18, Spenser Gilliland wrote: > Adds gstreamer 1.X base plugins. Missing SoB. Protip: git config --global format.signoff true > --- > package/multimedia/Config.in | 1 + > package/multimedia/gst1-plugins-base/Config.in | 106 ++++++++++ > .../gst1-plugins-base/gst1-plugins-base.mk | 204 ++++++++++++++++++++ > 3 files changed, 311 insertions(+), 0 deletions(-) > create mode 100644 package/multimedia/gst1-plugins-base/Config.in > create mode 100644 package/multimedia/gst1-plugins-base/gst1-plugins-base.mk > > diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in > index 0351fd0..253fd17 100644 > --- a/package/multimedia/Config.in > +++ b/package/multimedia/Config.in > @@ -12,6 +12,7 @@ source "package/multimedia/gst-dsp/Config.in" > source "package/multimedia/gst-fsl-plugins/Config.in" > source "package/multimedia/gst-omapfb/Config.in" > source "package/multimedia/gst-plugins-base/Config.in" > +source "package/multimedia/gst1-plugins-base/Config.in" Same remark: keep all gst1 stuff together. > source "package/multimedia/gst-plugins-good/Config.in" > source "package/multimedia/gst-plugins-bad/Config.in" > source "package/multimedia/gst-plugins-ugly/Config.in" > diff --git a/package/multimedia/gst1-plugins-base/Config.in b/package/multimedia/gst1-plugins-base/Config.in > new file mode 100644 > index 0000000..2a95846 > --- /dev/null > +++ b/package/multimedia/gst1-plugins-base/Config.in > @@ -0,0 +1,106 @@ > +menuconfig BR2_PACKAGE_GST1_PLUGINS_BASE > + bool "gst1-plugins-base" > + depends on BR2_PACKAGE_GSTREAMER1 > + select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7 > + select BR2_PACKAGE_XLIB_LIBXEXT if BR2_PACKAGE_XORG7 > + select BR2_PACKAGE_XLIB_LIBXV if BR2_PACKAGE_XORG7 > + help > + A basic set of well-supported plug-ins for GStreamer. > + > + http://gstreamer.freedesktop.org/ > + > +if BR2_PACKAGE_GST1_PLUGINS_BASE > + > +comment "dependency-less plugins" It would be nice if these plugins would get some help text explaining what they are. Copy and past of the description in gst-inspect is probably sufficient. > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ADDER > + bool "adder" > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP > + bool "app" > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOCONVERT > + bool "audioconvert (mandatory for audio playback)" > + default y > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORATE > + bool "audiorate" > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORESAMPLE > + bool "audioresample (mandatory for audio playback)" > + default y > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOTESTSRC > + bool "audiotestsrc" > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ENCODING > + bool "encoding" > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_GIO > + bool "gio" > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PLAYBACK > + bool "playback" > + default y I would add a "select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TYPEFIND" here. I think that is the only required dependency of the playsinks. There's also a gdp and a gst_v4l plugin for which no config option exists. > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_SUBPARSE > + bool "subparse" > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TCP > + bool "tcp" > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TYPEFIND > + bool "typefind" > + default y > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOCONVERT > + bool "videoconvert" > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOTESTSRC > + bool "videotestsrc" > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEORATE > + bool "videorate" > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOSCALE > + bool "videoscale (mandatory for video playback)" > + default y > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME > + bool "volume (mandatory for audio playback)" > + default y > + > +comment "plugins with external dependencies (there may be more available)" What does "there may be more available" mean? > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA > + bool "alsa (mandatory for audio playback)" > + select BR2_PACKAGE_ALSA_LIB > + select BR2_PACKAGE_ALSA_LIB_MIXER > + select BR2_PACKAGE_ALSA_LIB_PCM > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_OGG > + bool "ogg (*.ogg audio/video)" > + select BR2_PACKAGE_LIBOGG > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PANGO > + bool "pango font renderer" > + depends on BR2_INSTALL_LIBSTDCPP > + select BR2_PACKAGE_PANGO > + > +comment "pango plugin requires a toolchain with C++ support" > + depends on !BR2_INSTALL_LIBSTDCPP > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_THEORA > + bool "theora (*.ogg video)" > + select BR2_PACKAGE_LIBTHEORA > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TREMOR > + bool "tremor" > + select BR2_PACKAGE_TREMOR > + > +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VORBIS > + bool "vorbis (*.ogg audio)" > + select BR2_PACKAGE_LIBVORBIS > + > +endif > + > diff --git a/package/multimedia/gst1-plugins-base/gst1-plugins-base.mk b/package/multimedia/gst1-plugins-base/gst1-plugins-base.mk > new file mode 100644 > index 0000000..63c4955 > --- /dev/null > +++ b/package/multimedia/gst1-plugins-base/gst1-plugins-base.mk > @@ -0,0 +1,204 @@ > +################################################################################ > +# > +# gst1-plugins-base > +# > +################################################################################ > + > +GST1_PLUGINS_BASE_VERSION = 1.1.1 I could be wrong, but didn't gstreamer switch to simultaneous releases, so we could use $(GSTREAMER1_VERSION) here instead? > +GST1_PLUGINS_BASE_SOURCE = gst-plugins-base-$(GST1_PLUGINS_BASE_VERSION).tar.xz > +GST1_PLUGINS_BASE_SITE = http://gstreamer.freedesktop.org/src/gst-plugins-base > +GST1_PLUGINS_BASE_INSTALL_STAGING = YES > +GST1_PLUGINS_BASE_LICENSE_FILES = COPYING COPYING.LIB COPYING contains the GPL which isn't actually used by any source file (only some old tests). So it can be left out. > +GST1_PLUGINS_BASE_LICENSE = LGPLv2+ LGPLv2.1+ > + > +# freetype is only used by examples, but if it is not found > +# and the host has a freetype-config script, then the host > +# include dirs are added to the search path causing trouble > +GST1_PLUGINS_BASE_CONF_ENV = > + FT2_CONFIG=/bin/false \ > + ac_cv_header_stdint_t="stdint.h" Why is this necessary? > + > +GST1_PLUGINS_BASE_CONF_OPT = \ > + --disable-examples \ > + --disable-oggtest \ > + --disable-vorbistest \ > + --disable-freetypetest \ > + --disable-valgrind \ > + --disable-debug > + > +# Options which require currently unpackaged libraries > +GST1_PLUGINS_BASE_CONF_OPT += \ > + --disable-cdparanoia \ > + --disable-libvisual \ > + --disable-iso-codes > + > +GST1_PLUGINS_BASE_DEPENDENCIES = gstreamer1 > + > +ifeq ($(BR2_PACKAGE_XORG7),y) > +GST1_PLUGINS_BASE_DEPENDENCIES += xlib_libX11 xlib_libXext xlib_libXv > +GST1_PLUGINS_BASE_CONF_OPT += \ > + --enable-x \ > + --enable-xshm \ > + --enable-xvideo > +else > +GST1_PLUGINS_BASE_CONF_OPT += \ > + --disable-x \ > + --disable-xshm \ > + --disable-xvideo > +endif I would actually make configure options for ximagesink and xvimagesink (--enable-x and --enable-xvideo). > + > +ifeq ($(BR2_PACKAGE_ORC),y) > +GST1_PLUGINS_BASE_DEPENDENCIES += orc > +GST1_PLUGINS_BASE_CONF_OPT += --enable-orc > +endif > + It would be nice if the plugins below could be kept alphabetic. Regards, Arnout > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA),y) > +GST1_PLUGINS_BASE_DEPENDENCIES += alsa-lib > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-alsa > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ADDER),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-adder > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-adder > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-app > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-app > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOCONVERT),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-audioconvert > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-audioconvert > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORATE),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-audiorate > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-audiorate > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORESAMPLE),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-audioresample > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-audioresample > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOTESTSRC),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-audiotestsrc > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-audiotestsrc > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ENCODING),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-encoding > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-encoding > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOCONVERT),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-videoconvert > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-videoconvert > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_GIO),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-gio > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-gio > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PLAYBACK),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-playback > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-playback > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_SUBPARSE),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-subparse > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-subparse > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TCP),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-tcp > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-tcp > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TYPEFIND),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-typefind > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-typefind > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOTESTSRC),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-videotestsrc > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-videotestsrc > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEORATE),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-videorate > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-videorate > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOSCALE),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-videoscale > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-videoscale > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-volume > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-volume > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_OGG),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-ogg > +GST1_PLUGINS_BASE_DEPENDENCIES += libogg > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-ogg > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PANGO),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-pango > +GST1_PLUGINS_BASE_DEPENDENCIES += pango > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-pango > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_THEORA),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-theora > +GST1_PLUGINS_BASE_DEPENDENCIES += libtheora > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-theora > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TREMOR),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-ivorbis > +GST1_PLUGINS_BASE_DEPENDENCIES += tremor > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-ivorbis > +endif > + > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VORBIS),y) > +GST1_PLUGINS_BASE_CONF_OPT += --enable-vorbis > +GST1_PLUGINS_BASE_DEPENDENCIES += libvorbis > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-vorbis > +endif > + > +ifeq ($(BR2_PACKAGE_ZLIB),y) > +GST1_PLUGINS_BASE_DEPENDENCIES += zlib > +else > +GST1_PLUGINS_BASE_CONF_OPT += --disable-zlib > +endif > + > +$(eval $(autotools-package)) >
Arnout, Thanks for taking the time to review these patches. For your other two patch reviews, I have incorporated all changes into my next patch series. On Wed, Jun 12, 2013 at 1:21 AM, Arnout Vandecappelle <arnout@mind.be> wrote: > On 08/06/13 01:18, Spenser Gilliland wrote: >> >> Adds gstreamer 1.X base plugins. > > > Missing SoB. > > Protip: git config --global format.signoff true Usually, do this with git format-patch -s must have forgot to add the switch. I'll add this to my config. > >> --- >> package/multimedia/Config.in | 1 + >> package/multimedia/gst1-plugins-base/Config.in | 106 ++++++++++ >> .../gst1-plugins-base/gst1-plugins-base.mk | 204 >> ++++++++++++++++++++ >> 3 files changed, 311 insertions(+), 0 deletions(-) >> create mode 100644 package/multimedia/gst1-plugins-base/Config.in >> create mode 100644 >> package/multimedia/gst1-plugins-base/gst1-plugins-base.mk >> >> diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in >> index 0351fd0..253fd17 100644 >> --- a/package/multimedia/Config.in >> +++ b/package/multimedia/Config.in >> @@ -12,6 +12,7 @@ source "package/multimedia/gst-dsp/Config.in" >> source "package/multimedia/gst-fsl-plugins/Config.in" >> source "package/multimedia/gst-omapfb/Config.in" >> source "package/multimedia/gst-plugins-base/Config.in" >> +source "package/multimedia/gst1-plugins-base/Config.in" > > > Same remark: keep all gst1 stuff together. Will do. > > >> source "package/multimedia/gst-plugins-good/Config.in" >> source "package/multimedia/gst-plugins-bad/Config.in" >> source "package/multimedia/gst-plugins-ugly/Config.in" >> diff --git a/package/multimedia/gst1-plugins-base/Config.in >> b/package/multimedia/gst1-plugins-base/Config.in >> new file mode 100644 >> index 0000000..2a95846 >> --- /dev/null >> +++ b/package/multimedia/gst1-plugins-base/Config.in >> @@ -0,0 +1,106 @@ >> +menuconfig BR2_PACKAGE_GST1_PLUGINS_BASE >> + bool "gst1-plugins-base" >> + depends on BR2_PACKAGE_GSTREAMER1 >> + select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7 >> + select BR2_PACKAGE_XLIB_LIBXEXT if BR2_PACKAGE_XORG7 >> + select BR2_PACKAGE_XLIB_LIBXV if BR2_PACKAGE_XORG7 >> + help >> + A basic set of well-supported plug-ins for GStreamer. >> + >> + http://gstreamer.freedesktop.org/ >> + >> +if BR2_PACKAGE_GST1_PLUGINS_BASE >> + >> +comment "dependency-less plugins" > > > It would be nice if these plugins would get some help text explaining what > they are. Copy and past of the description in gst-inspect is probably > sufficient. Sounds reasonable. Will do. > >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ADDER >> + bool "adder" >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP >> + bool "app" >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOCONVERT >> + bool "audioconvert (mandatory for audio playback)" >> + default y >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORATE >> + bool "audiorate" >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORESAMPLE >> + bool "audioresample (mandatory for audio playback)" >> + default y >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOTESTSRC >> + bool "audiotestsrc" >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ENCODING >> + bool "encoding" >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_GIO >> + bool "gio" >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PLAYBACK >> + bool "playback" >> + default y > > > I would add a "select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TYPEFIND" here. > I think that is the only required dependency of the playsinks. Good to know. I'll add this to the next patch series. > There's also a gdp and a gst_v4l plugin for which no config option exists. I cannot find either of these options in the ./configure --help output are you sure they are available? > > >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_SUBPARSE >> + bool "subparse" >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TCP >> + bool "tcp" >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TYPEFIND >> + bool "typefind" >> + default y >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOCONVERT >> + bool "videoconvert" >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOTESTSRC >> + bool "videotestsrc" >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEORATE >> + bool "videorate" >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOSCALE >> + bool "videoscale (mandatory for video playback)" >> + default y >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME >> + bool "volume (mandatory for audio playback)" >> + default y >> + >> +comment "plugins with external dependencies (there may be more >> available)" > > > What does "there may be more available" mean? I've updated the wording to "plugins which have unpackaged dependencies are not shown" . > >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA >> + bool "alsa (mandatory for audio playback)" >> + select BR2_PACKAGE_ALSA_LIB >> + select BR2_PACKAGE_ALSA_LIB_MIXER >> + select BR2_PACKAGE_ALSA_LIB_PCM >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_OGG >> + bool "ogg (*.ogg audio/video)" >> + select BR2_PACKAGE_LIBOGG >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PANGO >> + bool "pango font renderer" >> + depends on BR2_INSTALL_LIBSTDCPP >> + select BR2_PACKAGE_PANGO >> + >> +comment "pango plugin requires a toolchain with C++ support" >> + depends on !BR2_INSTALL_LIBSTDCPP >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_THEORA >> + bool "theora (*.ogg video)" >> + select BR2_PACKAGE_LIBTHEORA >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TREMOR >> + bool "tremor" >> + select BR2_PACKAGE_TREMOR >> + >> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VORBIS >> + bool "vorbis (*.ogg audio)" >> + select BR2_PACKAGE_LIBVORBIS >> + >> +endif >> + >> diff --git a/package/multimedia/gst1-plugins-base/gst1-plugins-base.mk >> b/package/multimedia/gst1-plugins-base/gst1-plugins-base.mk >> new file mode 100644 >> index 0000000..63c4955 >> --- /dev/null >> +++ b/package/multimedia/gst1-plugins-base/gst1-plugins-base.mk >> @@ -0,0 +1,204 @@ >> >> +################################################################################ >> +# >> +# gst1-plugins-base >> +# >> >> +################################################################################ >> + >> +GST1_PLUGINS_BASE_VERSION = 1.1.1 > > > I could be wrong, but didn't gstreamer switch to simultaneous releases, so > we could use $(GSTREAMER1_VERSION) here instead? > > >> +GST1_PLUGINS_BASE_SOURCE = >> gst-plugins-base-$(GST1_PLUGINS_BASE_VERSION).tar.xz >> +GST1_PLUGINS_BASE_SITE = >> http://gstreamer.freedesktop.org/src/gst-plugins-base >> +GST1_PLUGINS_BASE_INSTALL_STAGING = YES >> +GST1_PLUGINS_BASE_LICENSE_FILES = COPYING COPYING.LIB > > > COPYING contains the GPL which isn't actually used by any source file (only > some old tests). So it can be left out. > > >> +GST1_PLUGINS_BASE_LICENSE = LGPLv2+ LGPLv2.1+ >> + >> +# freetype is only used by examples, but if it is not found >> +# and the host has a freetype-config script, then the host >> +# include dirs are added to the search path causing trouble >> +GST1_PLUGINS_BASE_CONF_ENV = >> + FT2_CONFIG=/bin/false \ >> + ac_cv_header_stdint_t="stdint.h" > > > Why is this necessary? Not sure, this was in the gst-plugins-base and was simply copied to gst1-plugins-base. The following two commits created these lines. http://git.buildroot.net/buildroot/commit/package/multimedia/gst-plugins-base/gst-plugins-base.mk?id=8232850c51e07b99ba84769b492faa147290fdc7 http://git.buildroot.net/buildroot/commit/package/multimedia/gst-plugins-base/gst-plugins-base.mk?id=32d319e6f7242553c821c7a1eadfabd2719f5992 > >> + >> +GST1_PLUGINS_BASE_CONF_OPT = \ >> + --disable-examples \ >> + --disable-oggtest \ >> + --disable-vorbistest \ >> + --disable-freetypetest \ >> + --disable-valgrind \ >> + --disable-debug >> + >> +# Options which require currently unpackaged libraries >> +GST1_PLUGINS_BASE_CONF_OPT += \ >> + --disable-cdparanoia \ >> + --disable-libvisual \ >> + --disable-iso-codes >> + >> +GST1_PLUGINS_BASE_DEPENDENCIES = gstreamer1 >> + >> +ifeq ($(BR2_PACKAGE_XORG7),y) >> +GST1_PLUGINS_BASE_DEPENDENCIES += xlib_libX11 xlib_libXext xlib_libXv >> +GST1_PLUGINS_BASE_CONF_OPT += \ >> + --enable-x \ >> + --enable-xshm \ >> + --enable-xvideo >> +else >> +GST1_PLUGINS_BASE_CONF_OPT += \ >> + --disable-x \ >> + --disable-xshm \ >> + --disable-xvideo >> +endif > > > I would actually make configure options for ximagesink and xvimagesink > (--enable-x and --enable-xvideo). As X already consumes a large amount of > >> + >> +ifeq ($(BR2_PACKAGE_ORC),y) >> +GST1_PLUGINS_BASE_DEPENDENCIES += orc >> +GST1_PLUGINS_BASE_CONF_OPT += --enable-orc >> +endif >> + > > > It would be nice if the plugins below could be kept alphabetic. How about if I keep them in the order of ./configure --help? That way its easy to spot when new ones are added and old ones removed. Thanks, Spenser -- Spenser Gilliland Computer Engineer Doctoral Candidate
On 12/06/13 21:19, Spenser Gilliland wrote: > On Wed, Jun 12, 2013 at 1:21 AM, Arnout Vandecappelle <arnout@mind.be> wrote: >> On 08/06/13 01:18, Spenser Gilliland wrote: [snip] >> There's also a gdp and a gst_v4l plugin for which no config option exists. > > I cannot find either of these options in the ./configure --help output > are you sure they are available? Sorry my bad - I was looking at my local git clone, and it still had a configure from 0.10 days (forgot to run autoregen). > >> >> >>> + >>> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_SUBPARSE >>> + bool "subparse" >>> + >>> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TCP >>> + bool "tcp" >>> + >>> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TYPEFIND >>> + bool "typefind" >>> + default y >>> + >>> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOCONVERT >>> + bool "videoconvert" >>> + >>> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOTESTSRC >>> + bool "videotestsrc" >>> + >>> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEORATE >>> + bool "videorate" >>> + >>> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOSCALE >>> + bool "videoscale (mandatory for video playback)" >>> + default y >>> + >>> +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME >>> + bool "volume (mandatory for audio playback)" >>> + default y >>> + >>> +comment "plugins with external dependencies (there may be more >>> available)" >> >> >> What does "there may be more available" mean? > > I've updated the wording to "plugins which have unpackaged > dependencies are not shown" . I think that will make the line too long so you'd have to split it. But actually, for other packages we never say things like that. [snip] >>> +# freetype is only used by examples, but if it is not found >>> +# and the host has a freetype-config script, then the host >>> +# include dirs are added to the search path causing trouble >>> +GST1_PLUGINS_BASE_CONF_ENV = >>> + FT2_CONFIG=/bin/false \ >>> + ac_cv_header_stdint_t="stdint.h" >> >> >> Why is this necessary? > > Not sure, this was in the gst-plugins-base and was simply copied to > gst1-plugins-base. > > The following two commits created these lines. > http://git.buildroot.net/buildroot/commit/package/multimedia/gst-plugins-base/gst-plugins-base.mk?id=8232850c51e07b99ba84769b492faa147290fdc7 > http://git.buildroot.net/buildroot/commit/package/multimedia/gst-plugins-base/gst-plugins-base.mk?id=32d319e6f7242553c821c7a1eadfabd2719f5992 I was only referring to the stdint - the other one has a proper comment. But since nothing seems to have changed in the stdint.h detection code since 0.10.25, I guess it's best to keep it. > >> >>> + >>> +GST1_PLUGINS_BASE_CONF_OPT = \ >>> + --disable-examples \ >>> + --disable-oggtest \ >>> + --disable-vorbistest \ >>> + --disable-freetypetest \ >>> + --disable-valgrind \ >>> + --disable-debug >>> + >>> +# Options which require currently unpackaged libraries >>> +GST1_PLUGINS_BASE_CONF_OPT += \ >>> + --disable-cdparanoia \ >>> + --disable-libvisual \ >>> + --disable-iso-codes >>> + >>> +GST1_PLUGINS_BASE_DEPENDENCIES = gstreamer1 >>> + >>> +ifeq ($(BR2_PACKAGE_XORG7),y) >>> +GST1_PLUGINS_BASE_DEPENDENCIES += xlib_libX11 xlib_libXext xlib_libXv >>> +GST1_PLUGINS_BASE_CONF_OPT += \ >>> + --enable-x \ >>> + --enable-xshm \ >>> + --enable-xvideo >>> +else >>> +GST1_PLUGINS_BASE_CONF_OPT += \ >>> + --disable-x \ >>> + --disable-xshm \ >>> + --disable-xvideo >>> +endif >> >> >> I would actually make configure options for ximagesink and xvimagesink >> (--enable-x and --enable-xvideo). > > As X already consumes a large amount of I can complete that sentence :-) Fair enough. >> >>> + >>> +ifeq ($(BR2_PACKAGE_ORC),y) >>> +GST1_PLUGINS_BASE_DEPENDENCIES += orc >>> +GST1_PLUGINS_BASE_CONF_OPT += --enable-orc >>> +endif >>> + >> >> >> It would be nice if the plugins below could be kept alphabetic. > > How about if I keep them in the order of ./configure --help? That way > its easy to spot when new ones are added and old ones removed. Yes, good idea. Regards, Arnout > > Thanks, > Spenser > > > -- > Spenser Gilliland > Computer Engineer > Doctoral Candidate >
Arnout, >>>> +comment "plugins with external dependencies (there may be more >>>> available)" >>> >>> >>> >>> What does "there may be more available" mean? >> >> >> I've updated the wording to "plugins which have unpackaged >> dependencies are not shown" . > > > I think that will make the line too long so you'd have to split it. But > actually, for other packages we never say things like that. > The more I look at this the more I believe it should be removed. It was a hold over from the gst-plugins-base package. I'll remove it from the next patch series instead of the previously mentioned explanation. > >>>> +# freetype is only used by examples, but if it is not found >>>> +# and the host has a freetype-config script, then the host >>>> +# include dirs are added to the search path causing trouble >>>> +GST1_PLUGINS_BASE_CONF_ENV = >>>> + FT2_CONFIG=/bin/false \ >>>> + ac_cv_header_stdint_t="stdint.h" >>> >>> >>> >>> Why is this necessary? >> >> >> Not sure, this was in the gst-plugins-base and was simply copied to >> gst1-plugins-base. >> >> The following two commits created these lines. >> >> http://git.buildroot.net/buildroot/commit/package/multimedia/gst-plugins-base/gst-plugins-base.mk?id=8232850c51e07b99ba84769b492faa147290fdc7 >> >> http://git.buildroot.net/buildroot/commit/package/multimedia/gst-plugins-base/gst-plugins-base.mk?id=32d319e6f7242553c821c7a1eadfabd2719f5992 > > > I was only referring to the stdint - the other one has a proper comment. > > But since nothing seems to have changed in the stdint.h detection code > since 0.10.25, I guess it's best to keep it. > Sounds good to me. >>> I would actually make configure options for ximagesink and xvimagesink >>> (--enable-x and --enable-xvideo). >> >> >> As X already consumes a large amount of > > > I can complete that sentence :-) > > Fair enough. Oops, forgot to include the rest there but the point does get across in not to many words! :) Hopefully, I can get a second opinion on this but X is not a package you include on a bare minimal system; therefore, IMHO it's probably more important to implicitly enable support rather than explicitly. >>> It would be nice if the plugins below could be kept alphabetic. >> >> >> How about if I keep them in the order of ./configure --help? That way >> its easy to spot when new ones are added and old ones removed. > > > Yes, good idea. Thanks, I'll make these adjustments in the next patch series. Thanks for the review! Thanks, Spenser -- Spenser Gilliland Computer Engineer Doctoral Candidate
diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in index 0351fd0..253fd17 100644 --- a/package/multimedia/Config.in +++ b/package/multimedia/Config.in @@ -12,6 +12,7 @@ source "package/multimedia/gst-dsp/Config.in" source "package/multimedia/gst-fsl-plugins/Config.in" source "package/multimedia/gst-omapfb/Config.in" source "package/multimedia/gst-plugins-base/Config.in" +source "package/multimedia/gst1-plugins-base/Config.in" source "package/multimedia/gst-plugins-good/Config.in" source "package/multimedia/gst-plugins-bad/Config.in" source "package/multimedia/gst-plugins-ugly/Config.in" diff --git a/package/multimedia/gst1-plugins-base/Config.in b/package/multimedia/gst1-plugins-base/Config.in new file mode 100644 index 0000000..2a95846 --- /dev/null +++ b/package/multimedia/gst1-plugins-base/Config.in @@ -0,0 +1,106 @@ +menuconfig BR2_PACKAGE_GST1_PLUGINS_BASE + bool "gst1-plugins-base" + depends on BR2_PACKAGE_GSTREAMER1 + select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7 + select BR2_PACKAGE_XLIB_LIBXEXT if BR2_PACKAGE_XORG7 + select BR2_PACKAGE_XLIB_LIBXV if BR2_PACKAGE_XORG7 + help + A basic set of well-supported plug-ins for GStreamer. + + http://gstreamer.freedesktop.org/ + +if BR2_PACKAGE_GST1_PLUGINS_BASE + +comment "dependency-less plugins" + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ADDER + bool "adder" + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP + bool "app" + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOCONVERT + bool "audioconvert (mandatory for audio playback)" + default y + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORATE + bool "audiorate" + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORESAMPLE + bool "audioresample (mandatory for audio playback)" + default y + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOTESTSRC + bool "audiotestsrc" + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ENCODING + bool "encoding" + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_GIO + bool "gio" + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PLAYBACK + bool "playback" + default y + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_SUBPARSE + bool "subparse" + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TCP + bool "tcp" + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TYPEFIND + bool "typefind" + default y + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOCONVERT + bool "videoconvert" + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOTESTSRC + bool "videotestsrc" + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEORATE + bool "videorate" + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOSCALE + bool "videoscale (mandatory for video playback)" + default y + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME + bool "volume (mandatory for audio playback)" + default y + +comment "plugins with external dependencies (there may be more available)" + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA + bool "alsa (mandatory for audio playback)" + select BR2_PACKAGE_ALSA_LIB + select BR2_PACKAGE_ALSA_LIB_MIXER + select BR2_PACKAGE_ALSA_LIB_PCM + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_OGG + bool "ogg (*.ogg audio/video)" + select BR2_PACKAGE_LIBOGG + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PANGO + bool "pango font renderer" + depends on BR2_INSTALL_LIBSTDCPP + select BR2_PACKAGE_PANGO + +comment "pango plugin requires a toolchain with C++ support" + depends on !BR2_INSTALL_LIBSTDCPP + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_THEORA + bool "theora (*.ogg video)" + select BR2_PACKAGE_LIBTHEORA + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TREMOR + bool "tremor" + select BR2_PACKAGE_TREMOR + +config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VORBIS + bool "vorbis (*.ogg audio)" + select BR2_PACKAGE_LIBVORBIS + +endif + diff --git a/package/multimedia/gst1-plugins-base/gst1-plugins-base.mk b/package/multimedia/gst1-plugins-base/gst1-plugins-base.mk new file mode 100644 index 0000000..63c4955 --- /dev/null +++ b/package/multimedia/gst1-plugins-base/gst1-plugins-base.mk @@ -0,0 +1,204 @@ +################################################################################ +# +# gst1-plugins-base +# +################################################################################ + +GST1_PLUGINS_BASE_VERSION = 1.1.1 +GST1_PLUGINS_BASE_SOURCE = gst-plugins-base-$(GST1_PLUGINS_BASE_VERSION).tar.xz +GST1_PLUGINS_BASE_SITE = http://gstreamer.freedesktop.org/src/gst-plugins-base +GST1_PLUGINS_BASE_INSTALL_STAGING = YES +GST1_PLUGINS_BASE_LICENSE_FILES = COPYING COPYING.LIB +GST1_PLUGINS_BASE_LICENSE = LGPLv2+ LGPLv2.1+ + +# freetype is only used by examples, but if it is not found +# and the host has a freetype-config script, then the host +# include dirs are added to the search path causing trouble +GST1_PLUGINS_BASE_CONF_ENV = + FT2_CONFIG=/bin/false \ + ac_cv_header_stdint_t="stdint.h" + +GST1_PLUGINS_BASE_CONF_OPT = \ + --disable-examples \ + --disable-oggtest \ + --disable-vorbistest \ + --disable-freetypetest \ + --disable-valgrind \ + --disable-debug + +# Options which require currently unpackaged libraries +GST1_PLUGINS_BASE_CONF_OPT += \ + --disable-cdparanoia \ + --disable-libvisual \ + --disable-iso-codes + +GST1_PLUGINS_BASE_DEPENDENCIES = gstreamer1 + +ifeq ($(BR2_PACKAGE_XORG7),y) +GST1_PLUGINS_BASE_DEPENDENCIES += xlib_libX11 xlib_libXext xlib_libXv +GST1_PLUGINS_BASE_CONF_OPT += \ + --enable-x \ + --enable-xshm \ + --enable-xvideo +else +GST1_PLUGINS_BASE_CONF_OPT += \ + --disable-x \ + --disable-xshm \ + --disable-xvideo +endif + +ifeq ($(BR2_PACKAGE_ORC),y) +GST1_PLUGINS_BASE_DEPENDENCIES += orc +GST1_PLUGINS_BASE_CONF_OPT += --enable-orc +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA),y) +GST1_PLUGINS_BASE_DEPENDENCIES += alsa-lib +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-alsa +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ADDER),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-adder +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-adder +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-app +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-app +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOCONVERT),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-audioconvert +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-audioconvert +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORATE),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-audiorate +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-audiorate +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORESAMPLE),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-audioresample +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-audioresample +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOTESTSRC),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-audiotestsrc +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-audiotestsrc +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ENCODING),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-encoding +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-encoding +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOCONVERT),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-videoconvert +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-videoconvert +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_GIO),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-gio +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-gio +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PLAYBACK),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-playback +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-playback +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_SUBPARSE),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-subparse +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-subparse +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TCP),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-tcp +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-tcp +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TYPEFIND),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-typefind +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-typefind +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOTESTSRC),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-videotestsrc +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-videotestsrc +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEORATE),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-videorate +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-videorate +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOSCALE),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-videoscale +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-videoscale +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-volume +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-volume +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_OGG),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-ogg +GST1_PLUGINS_BASE_DEPENDENCIES += libogg +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-ogg +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PANGO),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-pango +GST1_PLUGINS_BASE_DEPENDENCIES += pango +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-pango +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_THEORA),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-theora +GST1_PLUGINS_BASE_DEPENDENCIES += libtheora +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-theora +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TREMOR),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-ivorbis +GST1_PLUGINS_BASE_DEPENDENCIES += tremor +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-ivorbis +endif + +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VORBIS),y) +GST1_PLUGINS_BASE_CONF_OPT += --enable-vorbis +GST1_PLUGINS_BASE_DEPENDENCIES += libvorbis +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-vorbis +endif + +ifeq ($(BR2_PACKAGE_ZLIB),y) +GST1_PLUGINS_BASE_DEPENDENCIES += zlib +else +GST1_PLUGINS_BASE_CONF_OPT += --disable-zlib +endif + +$(eval $(autotools-package))