| Message ID | 1370990670-49249-7-git-send-email-paul.gortmaker@windriver.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Tue, Jun 11, 2013 at 06:44:30PM -0400, Paul Gortmaker wrote: > commit b6e96d0067d8 ("jbd2: use module parameters instead of debugfs > for jbd_debug") removed any need for a dependency on DEBUG_FS. It > also moved the /sys variables out from underneath the typical debugfs > mount point. Delete the dependency and update the /sys path to where > the debug settings are currently. > > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Applied, thanks. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 13-06-12 11:08 PM, Theodore Ts'o wrote: > On Tue, Jun 11, 2013 at 06:44:30PM -0400, Paul Gortmaker wrote: >> commit b6e96d0067d8 ("jbd2: use module parameters instead of debugfs >> for jbd_debug") removed any need for a dependency on DEBUG_FS. It >> also moved the /sys variables out from underneath the typical debugfs >> mount point. Delete the dependency and update the /sys path to where >> the debug settings are currently. >> >> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > > Applied, thanks. Just a heads up -- it seems some script threw away the 1st line of the commit log here. https://git.kernel.org/cgit/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=7c39c8340334b79019812d7366057b1d4376516e Paul. -- > > - Ted > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jun 13, 2013 at 09:51:31AM -0400, Paul Gortmaker wrote: > On 13-06-12 11:08 PM, Theodore Ts'o wrote: > > On Tue, Jun 11, 2013 at 06:44:30PM -0400, Paul Gortmaker wrote: > >> commit b6e96d0067d8 ("jbd2: use module parameters instead of debugfs > >> for jbd_debug") removed any need for a dependency on DEBUG_FS. It > >> also moved the /sys variables out from underneath the typical debugfs > >> mount point. Delete the dependency and update the /sys path to where > >> the debug settings are currently. > >> > >> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > > > > Applied, thanks. > > Just a heads up -- it seems some script threw away the 1st line of the > commit log here. Thanks for noticing this. Guilt is apparently stripping lines that begin with "commit". Using "Commit" avoids this. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 13-06-13 10:14 AM, Theodore Ts'o wrote: > On Thu, Jun 13, 2013 at 09:51:31AM -0400, Paul Gortmaker wrote: >> On 13-06-12 11:08 PM, Theodore Ts'o wrote: >>> On Tue, Jun 11, 2013 at 06:44:30PM -0400, Paul Gortmaker wrote: >>>> commit b6e96d0067d8 ("jbd2: use module parameters instead of debugfs >>>> for jbd_debug") removed any need for a dependency on DEBUG_FS. It >>>> also moved the /sys variables out from underneath the typical debugfs >>>> mount point. Delete the dependency and update the /sys path to where >>>> the debug settings are currently. >>>> >>>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> >>> >>> Applied, thanks. >> >> Just a heads up -- it seems some script threw away the 1st line of the >> commit log here. > > Thanks for noticing this. Guilt is apparently stripping lines that > begin with "commit". Using "Commit" avoids this. It appears that Guilt is guilty of clobbering the author dates with the commit date too, which might not be desirable... https://lkml.org/lkml/2013/6/9/200 Paul. -- > > - Ted > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/jbd2/Kconfig b/fs/jbd2/Kconfig index 69a48c2..5a9f553 100644 --- a/fs/jbd2/Kconfig +++ b/fs/jbd2/Kconfig @@ -20,7 +20,7 @@ config JBD2 config JBD2_DEBUG bool "JBD2 (ext4) debugging support" - depends on JBD2 && DEBUG_FS + depends on JBD2 help If you are using the ext4 journaled file system (or potentially any other filesystem/device using JBD2), this option @@ -29,7 +29,7 @@ config JBD2_DEBUG By default, the debugging output will be turned off. If you select Y here, then you will be able to turn on debugging - with "echo N > /sys/kernel/debug/jbd2/jbd2-debug", where N is a + with "echo N > /sys/module/jbd2/parameters/jbd2_debug", where N is a number between 1 and 5. The higher the number, the more debugging output is generated. To turn debugging off again, do - "echo 0 > /sys/kernel/debug/jbd2/jbd2-debug". + "echo 0 > /sys/module/jbd2/parameters/jbd2_debug".
commit b6e96d0067d8 ("jbd2: use module parameters instead of debugfs for jbd_debug") removed any need for a dependency on DEBUG_FS. It also moved the /sys variables out from underneath the typical debugfs mount point. Delete the dependency and update the /sys path to where the debug settings are currently. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- fs/jbd2/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)