Message ID | 20130607191921.GM26693@bill-the-cat |
---|---|
State | Changes Requested |
Delegated to: | Albert ARIBAUD |
Headers | show |
Hi Tom, Michael, > Hello, > > The following changes since commit 3da0e5750b24a9491058df6126c7be577a276c09: > > arm: factorize relocate_code routine (2013-05-30 20:24:38 +0200) > > are available in the git repository at: > > git://git.denx.de/u-boot-ti.git master > > for you to fetch changes up to 80dd596d1b442ff53dbeb33eccdb8efd2283be79: > [snip] > Michael Trimarchi (1): > usb: omap: ulpi: fix ulpi transceiver access [snip] > drivers/usb/ulpi/omap-ulpi-viewport.c | 40 +- [snip] I just made a clean clone of u-boot-ti/master, manually applied the changes to the ehci files, added my board files and made a build. Everything seems to work fine, but I see an error message regarding ULPI reset that was not present before, and obviously it is due to Michael's changes: SOM5_EVB # usb start (Re)start USB... USB0: ULPI: ulpi_reset: failed writing reset bit USB EHCI 1.00 scanning bus 0 for devices... 6 USB Device(s) found scanning usb for storage devices... 3 Storage Device(s) found scanning usb for ethernet devices... 1 Ethernet Device(s) found SOM5_EVB # usb tree USB device tree: 1 Hub (480 Mb/s, 0mA) | u-boot EHCI Host Controller | +-2 Mass Storage (480 Mb/s, 200mA) | FSC MEMORYBIRD USB2 C157040817120315AA | +-3 Hub (480 Mb/s, 2mA) | | | +-4 Mass Storage (480 Mb/s, 96mA) | | Generic Ultra Fast Media Reader 000000264001 | | | +-5 Mass Storage (480 Mb/s, 100mA) | USB Flash Drive 531C43B21928F11F | +-6 Vendor specific (480 Mb/s, 500mA) SOM5_EVB # Otherwise everything is OK, the device on the ULPI port is working (it is #2 above). It is now late and I shall investigate in detail tomorrow, this is just an early warning ;) Best regards, Lubo
Hi Tom, On Fri, 7 Jun 2013 15:19:21 -0400, Tom Rini <trini@ti.com> wrote: > Tom Rini (4): > arm: Remove OMAP2420H4 and all omap24xx support This one removes not only 2420h4 but also tnetv107x_evm. Is that normal? Amicalement,
Hi Lubomir, On 06/08/13 23:43, Lubomir Popov wrote: > Hi Tom, Michael, > >> Hello, >> >> The following changes since commit 3da0e5750b24a9491058df6126c7be577a276c09: >> >> arm: factorize relocate_code routine (2013-05-30 20:24:38 +0200) >> >> are available in the git repository at: >> >> git://git.denx.de/u-boot-ti.git master >> >> for you to fetch changes up to 80dd596d1b442ff53dbeb33eccdb8efd2283be79: >> > > [snip] > >> Michael Trimarchi (1): >> usb: omap: ulpi: fix ulpi transceiver access > > [snip] > >> drivers/usb/ulpi/omap-ulpi-viewport.c | 40 +- > > [snip] > > I just made a clean clone of u-boot-ti/master, manually applied the > changes to the ehci files, added my board files and made a build. > Everything seems to work fine, but I see an error message regarding > ULPI reset that was not present before, and obviously it is due to > Michael's changes: Yes indeed, those are due to Michael's patch. Michael's patch aligns the code with the TRM and seems to reveal an OMAP USB bug might an erratum. > > SOM5_EVB # usb start > (Re)start USB... > USB0: ULPI: ulpi_reset: failed writing reset bit > USB EHCI 1.00 > scanning bus 0 for devices... 6 USB Device(s) found > scanning usb for storage devices... 3 Storage Device(s) found > scanning usb for ethernet devices... 1 Ethernet Device(s) found > SOM5_EVB # usb tree > USB device tree: > 1 Hub (480 Mb/s, 0mA) > | u-boot EHCI Host Controller > | > +-2 Mass Storage (480 Mb/s, 200mA) > | FSC MEMORYBIRD USB2 C157040817120315AA > | > +-3 Hub (480 Mb/s, 2mA) > | | > | +-4 Mass Storage (480 Mb/s, 96mA) > | | Generic Ultra Fast Media Reader 000000264001 > | | > | +-5 Mass Storage (480 Mb/s, 100mA) > | USB Flash Drive 531C43B21928F11F > | > +-6 Vendor specific (480 Mb/s, 500mA) > > SOM5_EVB # > > Otherwise everything is OK, the device on the ULPI port is working > (it is #2 above). It is now late and I shall investigate in detail > tomorrow, this is just an early warning ;) > > Best regards, > Lubo > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >
On Sat, Jun 08, 2013 at 11:57:05PM +0200, Albert ARIBAUD wrote: > Hi Tom, > > On Fri, 7 Jun 2013 15:19:21 -0400, Tom Rini <trini@ti.com> wrote: > > > Tom Rini (4): > > > arm: Remove OMAP2420H4 and all omap24xx support > > This one removes not only 2420h4 but also tnetv107x_evm. Is that normal? That wasn't intentional, merge problem and/or fat-fingers. Re-did that commit and rebased onto current u-boot-arm, will re-do a pull request once MAKEALL -a arm finishes.