diff mbox

[-v2] ext4: add the spec for ext4 subdirectory limit(was: Problems with the max value for create directory)

Message ID 20090223032540.GB19739@mit.edu
State Accepted, archived
Headers show

Commit Message

Theodore Ts'o Feb. 23, 2009, 3:25 a.m. UTC
I really don't think this tweak to Documentation/filesystems/ext4.txt
is necessary, but if we going to do this, I want to tighten up the
explanation.

						- Ted

ext4: Add fine print for the 32000 subdirectory limit

Some poeple are reading the ext4 feature list too literally and create
dubious test cases involving very long filenames and 1k blocksize and
then complain when they run into an htree-imposed limit.  So add fine
print to the "fix 32000 subdirectory limit" ext4 feature.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Zhang Xiliang Feb. 24, 2009, 7:26 a.m. UTC | #1
Theodore Tso wrote:
> I really don't think this tweak to Documentation/filesystems/ext4.txt
> is necessary, but if we going to do this, I want to tighten up the
> explanation.
> 
> 						- Ted
> 
I agree.
Thanks.

> ext4: Add fine print for the 32000 subdirectory limit
> 
> Some poeple are reading the ext4 feature list too literally and create
> dubious test cases involving very long filenames and 1k blocksize and
> then complain when they run into an htree-imposed limit.  So add fine
> print to the "fix 32000 subdirectory limit" ext4 feature.
> 
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> diff --git a/Documentation/filesystems/ext4.txt b/Documentation/filesystems/ext4.txt
> index cec829b..5c484ae 100644
> --- a/Documentation/filesystems/ext4.txt
> +++ b/Documentation/filesystems/ext4.txt
> @@ -85,7 +85,7 @@ Note: More extensive information for getting started with ext4 can be
>  * extent format more robust in face of on-disk corruption due to magics,
>  * internal redundancy in tree
>  * improved file allocation (multi-block alloc)
> -* fix 32000 subdirectory limit
> +* lift 32000 subdirectory limit imposed by i_links_count[1]
>  * nsec timestamps for mtime, atime, ctime, create time
>  * inode version field on disk (NFSv4, Lustre)
>  * reduced e2fsck time via uninit_bg feature
> @@ -100,6 +100,9 @@ Note: More extensive information for getting started with ext4 can be
>  * efficent new ordered mode in JBD2 and ext4(avoid using buffer head to force
>    the ordering)
>  
> +[1] Filesystems with a block size of 1k may see a limit imposed by the
> +directory hash tree having a maximum depth of two.
> +
>  2.2 Candidate features for future inclusion
>  
>  * Online defrag (patches available but not well tested)
> 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/filesystems/ext4.txt b/Documentation/filesystems/ext4.txt
index cec829b..5c484ae 100644
--- a/Documentation/filesystems/ext4.txt
+++ b/Documentation/filesystems/ext4.txt
@@ -85,7 +85,7 @@  Note: More extensive information for getting started with ext4 can be
 * extent format more robust in face of on-disk corruption due to magics,
 * internal redundancy in tree
 * improved file allocation (multi-block alloc)
-* fix 32000 subdirectory limit
+* lift 32000 subdirectory limit imposed by i_links_count[1]
 * nsec timestamps for mtime, atime, ctime, create time
 * inode version field on disk (NFSv4, Lustre)
 * reduced e2fsck time via uninit_bg feature
@@ -100,6 +100,9 @@  Note: More extensive information for getting started with ext4 can be
 * efficent new ordered mode in JBD2 and ext4(avoid using buffer head to force
   the ordering)
 
+[1] Filesystems with a block size of 1k may see a limit imposed by the
+directory hash tree having a maximum depth of two.
+
 2.2 Candidate features for future inclusion
 
 * Online defrag (patches available but not well tested)