| Message ID | 1369645252-3847-1-git-send-email-horms+renesas@verge.net.au |
|---|---|
| State | New |
| Headers | show |
Hello. On 27-05-2013 13:00, Simon Horman wrote: > From: Magnus Damm <damm@opensource.se> > Use DEFINE_RES_MEM() and platform_device_register_simple() > to save a couple of lines of code. > Signed-off-by: Magnus Damm <damm@opensource.se> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > arch/arm/mach-shmobile/setup-sh73a0.c | 25 ++++++------------------- > 1 file changed, 6 insertions(+), 19 deletions(-) > diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c > index fdf3894..f8f4261 100644 > --- a/arch/arm/mach-shmobile/setup-sh73a0.c > +++ b/arch/arm/mach-shmobile/setup-sh73a0.c > @@ -61,29 +61,16 @@ void __init sh73a0_map_io(void) [...] > +/* PFC */ > +static const struct resource pfc_resources[] = { Should have been annotated as __initdata... too late, need another patch. > + DEFINE_RES_MEM(0xe6050000, 0x8000), > + DEFINE_RES_MEM(0xe605801c, 0x000c), > }; > > void __init sh73a0_pinmux_init(void) > { > - platform_device_register(&sh73a0_pfc_device); > + platform_device_register_simple("pfc-sh73a0", -1, pfc_resources, > + ARRAY_SIZE(pfc_resources)); > } WBR, Sergei
On Mon, May 27, 2013 at 06:13:22PM +0400, Sergei Shtylyov wrote: > Hello. > > On 27-05-2013 13:00, Simon Horman wrote: > > >From: Magnus Damm <damm@opensource.se> > > >Use DEFINE_RES_MEM() and platform_device_register_simple() > >to save a couple of lines of code. > > >Signed-off-by: Magnus Damm <damm@opensource.se> > >Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >--- > > arch/arm/mach-shmobile/setup-sh73a0.c | 25 ++++++------------------- > > 1 file changed, 6 insertions(+), 19 deletions(-) > > >diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c > >index fdf3894..f8f4261 100644 > >--- a/arch/arm/mach-shmobile/setup-sh73a0.c > >+++ b/arch/arm/mach-shmobile/setup-sh73a0.c > >@@ -61,29 +61,16 @@ void __init sh73a0_map_io(void) > [...] > >+/* PFC */ > >+static const struct resource pfc_resources[] = { > > Should have been annotated as __initdata... too late, need > another patch. See comments on other patches/pull requests, I think there's time to revisit this. I.e. I'll hold off on pulling this based on the other feedback. -Olof
On Mon, May 27, 2013 at 09:02:43PM -0700, Olof Johansson wrote: > On Mon, May 27, 2013 at 06:13:22PM +0400, Sergei Shtylyov wrote: > > Hello. > > > > On 27-05-2013 13:00, Simon Horman wrote: > > > > >From: Magnus Damm <damm@opensource.se> > > > > >Use DEFINE_RES_MEM() and platform_device_register_simple() > > >to save a couple of lines of code. > > > > >Signed-off-by: Magnus Damm <damm@opensource.se> > > >Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > >Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > >--- > > > arch/arm/mach-shmobile/setup-sh73a0.c | 25 ++++++------------------- > > > 1 file changed, 6 insertions(+), 19 deletions(-) > > > > >diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c > > >index fdf3894..f8f4261 100644 > > >--- a/arch/arm/mach-shmobile/setup-sh73a0.c > > >+++ b/arch/arm/mach-shmobile/setup-sh73a0.c > > >@@ -61,29 +61,16 @@ void __init sh73a0_map_io(void) > > [...] > > >+/* PFC */ > > >+static const struct resource pfc_resources[] = { > > > > Should have been annotated as __initdata... too late, need > > another patch. > > See comments on other patches/pull requests, I think there's time to revisit > this. I.e. I'll hold off on pulling this based on the other feedback. As I am respining I will fix this. However, it had been reviewed and I think that ordinarily it would be reasonable to perform further clean-up work in a subsequent patch.
On Tue, Jun 04, 2013 at 02:20:43PM +0900, Simon Horman wrote: > On Mon, May 27, 2013 at 09:02:43PM -0700, Olof Johansson wrote: > > On Mon, May 27, 2013 at 06:13:22PM +0400, Sergei Shtylyov wrote: > > > Hello. > > > > > > On 27-05-2013 13:00, Simon Horman wrote: > > > > > > >From: Magnus Damm <damm@opensource.se> > > > > > > >Use DEFINE_RES_MEM() and platform_device_register_simple() > > > >to save a couple of lines of code. > > > > > > >Signed-off-by: Magnus Damm <damm@opensource.se> > > > >Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > >Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > >--- > > > > arch/arm/mach-shmobile/setup-sh73a0.c | 25 ++++++------------------- > > > > 1 file changed, 6 insertions(+), 19 deletions(-) > > > > > > >diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c > > > >index fdf3894..f8f4261 100644 > > > >--- a/arch/arm/mach-shmobile/setup-sh73a0.c > > > >+++ b/arch/arm/mach-shmobile/setup-sh73a0.c > > > >@@ -61,29 +61,16 @@ void __init sh73a0_map_io(void) > > > [...] > > > >+/* PFC */ > > > >+static const struct resource pfc_resources[] = { > > > > > > Should have been annotated as __initdata... too late, need > > > another patch. > > > > See comments on other patches/pull requests, I think there's time to revisit > > this. I.e. I'll hold off on pulling this based on the other feedback. > > As I am respining I will fix this. > > However, it had been reviewed and I think that ordinarily > it would be reasonable to perform further clean-up > work in a subsequent patch. I decided to simply drop the patch and revisit it later.
Hi Simon, On Tuesday 04 June 2013 22:20:59 Simon Horman wrote: > On Tue, Jun 04, 2013 at 02:20:43PM +0900, Simon Horman wrote: > > On Mon, May 27, 2013 at 09:02:43PM -0700, Olof Johansson wrote: > > > On Mon, May 27, 2013 at 06:13:22PM +0400, Sergei Shtylyov wrote: > > > > On 27-05-2013 13:00, Simon Horman wrote: > > > > >From: Magnus Damm <damm@opensource.se> > > > > > > > > > >Use DEFINE_RES_MEM() and platform_device_register_simple() > > > > >to save a couple of lines of code. > > > > > > > > > >Signed-off-by: Magnus Damm <damm@opensource.se> > > > > >Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > >Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > > >--- > > > > > > > > > > arch/arm/mach-shmobile/setup-sh73a0.c | 25 > > > > > ++++++------------------- > > > > > 1 file changed, 6 insertions(+), 19 deletions(-) > > > > > > > > > >diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c > > > > >b/arch/arm/mach-shmobile/setup-sh73a0.c index fdf3894..f8f4261 > > > > >100644 > > > > >--- a/arch/arm/mach-shmobile/setup-sh73a0.c > > > > >+++ b/arch/arm/mach-shmobile/setup-sh73a0.c > > > > >@@ -61,29 +61,16 @@ void __init sh73a0_map_io(void) > > > > > > > > [...] > > > > > > > > >+/* PFC */ > > > > >+static const struct resource pfc_resources[] = { > > > > > > > > > Should have been annotated as __initdata... too late, need > > > > > > > > another patch. > > > > > > See comments on other patches/pull requests, I think there's time to > > > revisit this. I.e. I'll hold off on pulling this based on the other > > > feedback. > > > > As I am respining I will fix this. > > > > However, it had been reviewed and I think that ordinarily > > it would be reasonable to perform further clean-up > > work in a subsequent patch. > > I decided to simply drop the patch and revisit it later. This patch (as well as the sh7372 equivalent) is pretty simple. What about just adding __initdata and resubmitting them ? Otherwise they will get lost.
Hi Arnd, Hi Olof, The following changes since commit c7788792a5e7b0d5d7f96d0766b4cb6112d47d75: Linux 3.10-rc2 (2013-05-20 14:37:38 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-soc-sh73a0-for-v3.11 for you to fetch changes up to 8a6fca8ecd467a6255bda134d89fcda9ae1556ce: ARM: shmobile: sh73a0: div4 clocks must check the kick bit before changing rate (2013-05-25 09:57:10 +0900) ---------------------------------------------------------------- Renesas ARM based sh73a0 SoC updates for v3.11 * Change by Magnus Damm to use shmobile_setup_delay() when initialising the SoC using C-code, as was already the case when initialising the SoC using OF. This allows boot with TWD only. * CPUFreq support by Guennadi Liakhovetski * Clean-ups from Magnus Damm and Simon Horman to use DEFINE_RES_MEM() * Clean-up from Maxime Ripard to remove unnecessary init_irq declaration in machine description. ---------------------------------------------------------------- Guennadi Liakhovetski (4): ARM: shmobile: sh73a0: add support for adjusting CPU frequency ARM: shmobile: sh73a0: add CPUFreq support ARM: shmobile: sh73a0: do not overwrite all div4 clock operations ARM: shmobile: sh73a0: div4 clocks must check the kick bit before changing rate Magnus Damm (2): ARM: shmobile: sh73a0 pinmux platform device cleanup ARM: shmobile: sh73a0: Always use shmobile_setup_delay() Maxime Ripard (1): ARM: shmobile: sh73a0: Remove init_irq declaration in machine description Simon Horman (1): ARM: shmobile: sh73a0: Use DEFINE_RES_MEM*() everywhere arch/arm/mach-shmobile/Kconfig | 2 + arch/arm/mach-shmobile/clock-sh73a0.c | 111 +++++++++++++++++++++++++++++- arch/arm/mach-shmobile/setup-sh73a0.c | 122 ++++++++------------------------- 3 files changed, 141 insertions(+), 94 deletions(-)