| Message ID | 1367863561-11534-3-git-send-email-fabio.estevam@freescale.com |
|---|---|
| State | Accepted |
| Headers | show |
Hi Wolfram, On Mon, May 6, 2013 at 3:05 PM, Fabio Estevam <fabio.estevam@freescale.com> wrote: > Since commit ab78029 (drivers/pinctrl: grab default handles from device core), > we can rely on device core for handling pinctrl. > > So remove devm_pinctrl_get_select_default() from the driver. > > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: <linux-i2c@vger.kernel.org> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Any comments on this one? -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, May 26, 2013 at 05:58:31PM -0300, Fabio Estevam wrote: > Hi Wolfram, > > On Mon, May 6, 2013 at 3:05 PM, Fabio Estevam > <fabio.estevam@freescale.com> wrote: > > Since commit ab78029 (drivers/pinctrl: grab default handles from device core), > > we can rely on device core for handling pinctrl. > > > > So remove devm_pinctrl_get_select_default() from the driver. > > > > Cc: Wolfram Sang <wsa@the-dreams.de> > > Cc: <linux-i2c@vger.kernel.org> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > Any comments on this one? Yes, with series like this, you really need a cover-letter and CC it to all people involved. And mention there if you want these patches go via a specific tree or each patch via the corresponding subsystem tree. And mention if the patches are depending on each other. Otherwise I don't really know what to do with these patches.
On Sat, Jun 8, 2013 at 4:15 AM, Wolfram Sang <wsa@the-dreams.de> wrote: > Yes, with series like this, you really need a cover-letter and CC it to > all people involved. And mention there if you want these patches go via > a specific tree or each patch via the corresponding subsystem tree. And > mention if the patches are depending on each other. Otherwise I don't > really know what to do with these patches. Ok, understood, Wolfram. Please apply in your tree, if it looks good for you. Thanks, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please apply in your tree, if it looks good for you.
Applied to for-next, thanks!
diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c index 120f246..7f3dced 100644 --- a/drivers/i2c/busses/i2c-mxs.c +++ b/drivers/i2c/busses/i2c-mxs.c @@ -24,7 +24,6 @@ #include <linux/platform_device.h> #include <linux/jiffies.h> #include <linux/io.h> -#include <linux/pinctrl/consumer.h> #include <linux/stmp_device.h> #include <linux/of.h> #include <linux/of_device.h> @@ -604,16 +603,11 @@ static int mxs_i2c_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct mxs_i2c_dev *i2c; struct i2c_adapter *adap; - struct pinctrl *pinctrl; struct resource *res; resource_size_t res_size; int err, irq, dmairq; dma_cap_mask_t mask; - pinctrl = devm_pinctrl_get_select_default(dev); - if (IS_ERR(pinctrl)) - return PTR_ERR(pinctrl); - i2c = devm_kzalloc(dev, sizeof(struct mxs_i2c_dev), GFP_KERNEL); if (!i2c) return -ENOMEM;
Since commit ab78029 (drivers/pinctrl: grab default handles from device core), we can rely on device core for handling pinctrl. So remove devm_pinctrl_get_select_default() from the driver. Cc: Wolfram Sang <wsa@the-dreams.de> Cc: <linux-i2c@vger.kernel.org> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- drivers/i2c/busses/i2c-mxs.c | 6 ------ 1 file changed, 6 deletions(-)