Message ID | 1369176276-1895-2-git-send-email-robherring2@gmail.com |
---|---|
State | Superseded |
Delegated to: | Tom Rini |
Headers | show |
On Tue, May 21, 2013 at 05:44:31PM -0500, Rob Herring wrote: > From: Rob Herring <rob.herring@calxeda.com> > > gcc 4.7 will generate unaligned accesses to local char arrays, so make > them static to avoid that. > > Signed-off-by: Rob Herring <rob.herring@calxeda.com> Reviewed-by: Tom Rini <trini@ti.com>
Dear Rob Herring, In message <1369176276-1895-2-git-send-email-robherring2@gmail.com> you wrote: > > gcc 4.7 will generate unaligned accesses to local char arrays, so make > them static to avoid that. > > Signed-off-by: Rob Herring <rob.herring@calxeda.com> > --- > drivers/block/ahci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/ahci.c b/drivers/block/ahci.c > index b89be06..3cb37e7 100644 > --- a/drivers/block/ahci.c > +++ b/drivers/block/ahci.c > @@ -627,7 +627,7 @@ static void dump_ataid(hd_driveid_t *ataid) > */ > static int ata_scsiop_inquiry(ccb *pccb) > { > - u8 hdr[] = { > + static u8 hdr[] = { > 0, > 0, > 0x5, /* claim SPC-3 version compatibility */ Make it also "const" ? Best regards, Wolfgang Denk
diff --git a/drivers/block/ahci.c b/drivers/block/ahci.c index b89be06..3cb37e7 100644 --- a/drivers/block/ahci.c +++ b/drivers/block/ahci.c @@ -627,7 +627,7 @@ static void dump_ataid(hd_driveid_t *ataid) */ static int ata_scsiop_inquiry(ccb *pccb) { - u8 hdr[] = { + static u8 hdr[] = { 0, 0, 0x5, /* claim SPC-3 version compatibility */