Message ID | 20090214211346.23489.96321.stgit@vmbox.hanneseder.net |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
[Hannes Eder - Sat, Feb 14, 2009 at 10:13:52PM +0100]
| Fix this sparse warnings:
| drivers/net/ppp_generic.c:919:43: warning: incorrect type in argument 1 (different signedness)
| drivers/net/pppoe.c:1195:43: warning: incorrect type in argument 1 (different signedness)
| drivers/net/pppol2tp.c:2666:43: warning: incorrect type in argument 1 (different signedness)
|
| Signed-off-by: Hannes Eder <hannes@hanneseder.net>
...
Thanks Hannes,
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>
- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Cyrill Gorcunov - Sun, Feb 15, 2009 at 12:29:48AM +0300] | [Hannes Eder - Sat, Feb 14, 2009 at 10:13:52PM +0100] | | Fix this sparse warnings: | | drivers/net/ppp_generic.c:919:43: warning: incorrect type in argument 1 (different signedness) | | drivers/net/pppoe.c:1195:43: warning: incorrect type in argument 1 (different signedness) | | drivers/net/pppol2tp.c:2666:43: warning: incorrect type in argument 1 (different signedness) | | | | Signed-off-by: Hannes Eder <hannes@hanneseder.net> | ... | | Thanks Hannes, | | Acked-by: Cyrill Gorcunov <gorcunov@openvz.org> | | - Cyrill - Btw I think the same fix could be applied on drivers/net/tun.c (if you have time for :) - Cyrill - -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Feb 14, 2009 at 10:38 PM, Cyrill Gorcunov <gorcunov@gmail.com> wrote: > [Cyrill Gorcunov - Sun, Feb 15, 2009 at 12:29:48AM +0300] > | [Hannes Eder - Sat, Feb 14, 2009 at 10:13:52PM +0100] > | | Fix this sparse warnings: > | | drivers/net/ppp_generic.c:919:43: warning: incorrect type in argument 1 (different signedness) > | | drivers/net/pppoe.c:1195:43: warning: incorrect type in argument 1 (different signedness) > | | drivers/net/pppol2tp.c:2666:43: warning: incorrect type in argument 1 (different signedness) > | | > | | Signed-off-by: Hannes Eder <hannes@hanneseder.net> > | ... > | > | Thanks Hannes, > | > | Acked-by: Cyrill Gorcunov <gorcunov@openvz.org> > | > | - Cyrill - > > Btw I think the same fix could be applied on > drivers/net/tun.c (if you have time for :) This was fixed by this commit: commit 745417e20684e4951afcabfe74583a3884e54980 Author: Gerrit Renker <gerrit@erg.abdn.ac.uk> Date: Sun Jan 4 17:14:46 2009 -0800 which is in the linux-next tree. BTW, how can I check from which tree this commit came into the linux-next tree? -Hannes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[Hannes Eder - Sat, Feb 14, 2009 at 10:57:24PM +0100] ... | > Btw I think the same fix could be applied on | > drivers/net/tun.c (if you have time for :) | | This was fixed by this commit: | commit 745417e20684e4951afcabfe74583a3884e54980 | Author: Gerrit Renker <gerrit@erg.abdn.ac.uk> | Date: Sun Jan 4 17:14:46 2009 -0800 | | which is in the linux-next tree. Ah, good to know, thanks! | | BTW, how can I check from which tree this commit came into the linux-next tree? | | -Hannes | Not sure if it possible to find. if the commit was pulled without additional comments -- the only thing could be obtained -- is commit id itself. You better to ask someone who knows git well, not me :) - Cyrill - -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Cyrill Gorcunov <gorcunov@gmail.com> Date: Sun, 15 Feb 2009 00:29:48 +0300 > [Hannes Eder - Sat, Feb 14, 2009 at 10:13:52PM +0100] > | Fix this sparse warnings: > | drivers/net/ppp_generic.c:919:43: warning: incorrect type in argument 1 (different signedness) > | drivers/net/pppoe.c:1195:43: warning: incorrect type in argument 1 (different signedness) > | drivers/net/pppol2tp.c:2666:43: warning: incorrect type in argument 1 (different signedness) > | > | Signed-off-by: Hannes Eder <hannes@hanneseder.net> > ... > > Thanks Hannes, > > Acked-by: Cyrill Gorcunov <gorcunov@openvz.org> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c index fddc849..81e7fcc 100644 --- a/drivers/net/ppp_generic.c +++ b/drivers/net/ppp_generic.c @@ -183,7 +183,7 @@ static atomic_t ppp_unit_count = ATOMIC_INIT(0); static atomic_t channel_count = ATOMIC_INIT(0); /* per-net private data for this module */ -static unsigned int ppp_net_id; +static int ppp_net_id; struct ppp_net { /* units to ppp mapping */ struct idr units_idr; diff --git a/drivers/net/pppoe.c b/drivers/net/pppoe.c index af6321d..e2968f0 100644 --- a/drivers/net/pppoe.c +++ b/drivers/net/pppoe.c @@ -97,7 +97,7 @@ static const struct proto_ops pppoe_ops; static struct ppp_channel_ops pppoe_chan_ops; /* per-net private data for this module */ -static unsigned int pppoe_net_id; +static int pppoe_net_id; struct pppoe_net { /* * we could use _single_ hash table for all diff --git a/drivers/net/pppol2tp.c b/drivers/net/pppol2tp.c index 1ba0f68..5b07dd8 100644 --- a/drivers/net/pppol2tp.c +++ b/drivers/net/pppol2tp.c @@ -232,7 +232,7 @@ static struct ppp_channel_ops pppol2tp_chan_ops = { pppol2tp_xmit , NULL }; static struct proto_ops pppol2tp_ops; /* per-net private data for this module */ -static unsigned int pppol2tp_net_id; +static int pppol2tp_net_id; struct pppol2tp_net { struct list_head pppol2tp_tunnel_list; rwlock_t pppol2tp_tunnel_list_lock;
Fix this sparse warnings: drivers/net/ppp_generic.c:919:43: warning: incorrect type in argument 1 (different signedness) drivers/net/pppoe.c:1195:43: warning: incorrect type in argument 1 (different signedness) drivers/net/pppol2tp.c:2666:43: warning: incorrect type in argument 1 (different signedness) Signed-off-by: Hannes Eder <hannes@hanneseder.net> --- drivers/net/ppp_generic.c | 2 +- drivers/net/pppoe.c | 2 +- drivers/net/pppol2tp.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html