| Message ID | 1369305374-20433-20-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, May 23, 2013 at 04:06:01PM +0530, Sachin Kamat wrote: > After the switch to devm_* functions and the removal of > rtc_device_unregister(), the 'remove' function does not do anything. > Delete it. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > Cc: Thierry Reding <thierry.reding@avionic-design.de> Looks good to me: Acked-by: Thierry Reding <thierry.reding@avionic-design.de>
diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c index 305c951..5c8f822 100644 --- a/drivers/rtc/rtc-pcf8523.c +++ b/drivers/rtc/rtc-pcf8523.c @@ -317,11 +317,6 @@ static int pcf8523_probe(struct i2c_client *client, return 0; } -static int pcf8523_remove(struct i2c_client *client) -{ - return 0; -} - static const struct i2c_device_id pcf8523_id[] = { { "pcf8523", 0 }, { } @@ -343,7 +338,6 @@ static struct i2c_driver pcf8523_driver = { .of_match_table = of_match_ptr(pcf8523_of_match), }, .probe = pcf8523_probe, - .remove = pcf8523_remove, .id_table = pcf8523_id, }; module_i2c_driver(pcf8523_driver);
After the switch to devm_* functions and the removal of rtc_device_unregister(), the 'remove' function does not do anything. Delete it. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Cc: Thierry Reding <thierry.reding@avionic-design.de> --- drivers/rtc/rtc-pcf8523.c | 6 ------ 1 file changed, 6 deletions(-)