Message ID | 1368822717-19745-1-git-send-email-colin.king@canonical.com |
---|---|
State | Rejected |
Headers | show |
On 05/18/2013 04:31 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Add efi path to the scanner, ensure we pick up efi error messages > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/utilities/kernelscan.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/utilities/kernelscan.sh b/src/utilities/kernelscan.sh > index 636f4e7..91ff442 100755 > --- a/src/utilities/kernelscan.sh > +++ b/src/utilities/kernelscan.sh > @@ -68,6 +68,7 @@ scan_source_tree $src/drivers/acpi > scan_source_tree $src/arch/x86/kernel/acpi > scan_source_tree $src/arch/x86/platform/efi > scan_source_tree $src/drivers/pnp/pnpbios # need to do, loads of errors > +scan_source_tree $src/arch/x86/platform/efi > > > # > Hi Colin, Isn't the added line a duplicate of two lines above? Cheers, Alex Hung
On 21/05/13 07:05, Alex Hung wrote: > On 05/18/2013 04:31 AM, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Add efi path to the scanner, ensure we pick up efi error messages >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> src/utilities/kernelscan.sh | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/src/utilities/kernelscan.sh b/src/utilities/kernelscan.sh >> index 636f4e7..91ff442 100755 >> --- a/src/utilities/kernelscan.sh >> +++ b/src/utilities/kernelscan.sh >> @@ -68,6 +68,7 @@ scan_source_tree $src/drivers/acpi >> scan_source_tree $src/arch/x86/kernel/acpi >> scan_source_tree $src/arch/x86/platform/efi >> scan_source_tree $src/drivers/pnp/pnpbios # need to do, loads of >> errors >> +scan_source_tree $src/arch/x86/platform/efi >> >> >> # >> > Hi Colin, > > Isn't the added line a duplicate of two lines above? > > Cheers, > Alex Hung > It is, somehow I completely overlooked that. Doh. Thanks, it's a NACK. Colin
diff --git a/src/utilities/kernelscan.sh b/src/utilities/kernelscan.sh index 636f4e7..91ff442 100755 --- a/src/utilities/kernelscan.sh +++ b/src/utilities/kernelscan.sh @@ -68,6 +68,7 @@ scan_source_tree $src/drivers/acpi scan_source_tree $src/arch/x86/kernel/acpi scan_source_tree $src/arch/x86/platform/efi scan_source_tree $src/drivers/pnp/pnpbios # need to do, loads of errors +scan_source_tree $src/arch/x86/platform/efi #