| Message ID | 20130520231916.32416.7318.stgit@bhelgaas-glaptop (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
From: Bjorn Helgaas <bhelgaas@google.com> Date: Mon, 20 May 2013 17:19:16 -0600 > Previously we initialized dev->current_state to 4 (PCI_D3cold), but I think > we wanted PCI_UNKNOWN (5) here based on the comment and the fact that the > generic version of this code, pci_setup_device(), uses PCI_UNKNOWN. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Acked-by: David S. Miller <davem@davemloft.net>
diff --git a/arch/sparc/kernel/pci.c b/arch/sparc/kernel/pci.c index baf4366..972892a 100644 --- a/arch/sparc/kernel/pci.c +++ b/arch/sparc/kernel/pci.c @@ -327,7 +327,7 @@ static struct pci_dev *of_create_pci_dev(struct pci_pbm_info *pbm, if ((dev->class >> 8) == PCI_CLASS_STORAGE_IDE) pci_set_master(dev); - dev->current_state = 4; /* unknown power state */ + dev->current_state = PCI_UNKNOWN; /* unknown power state */ dev->error_state = pci_channel_io_normal; dev->dma_mask = 0xffffffff;
Previously we initialized dev->current_state to 4 (PCI_D3cold), but I think we wanted PCI_UNKNOWN (5) here based on the comment and the fact that the generic version of this code, pci_setup_device(), uses PCI_UNKNOWN. Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> --- arch/sparc/kernel/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)