Message ID | 1369041650-22056-1-git-send-email-lilei@linux.vnet.ibm.com |
---|---|
State | New |
Headers | show |
Am 20.05.2013 11:20, schrieb Lei Li: > Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com> > --- > linux-user/syscall.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 30e93bc..72c6866 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -8236,7 +8236,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, > #ifdef TARGET_NR_madvise > case TARGET_NR_madvise: > /* A straight passthrough may not be safe because qemu sometimes > - turns private flie-backed mappings into anonymous mappings. > + turns private file-backed mappings into anonymous mappings. > This will break MADV_DONTNEED. > This is a hint, so ignoring and returning success is ok. */ > ret = get_errno(0); Reviewed-by: Stefan Weil <sw@weilnetz.de>
On 05/20/2013 07:10 PM, Stefan Weil wrote: > Am 20.05.2013 11:20, schrieb Lei Li: >> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com> >> --- >> linux-user/syscall.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/linux-user/syscall.c b/linux-user/syscall.c >> index 30e93bc..72c6866 100644 >> --- a/linux-user/syscall.c >> +++ b/linux-user/syscall.c >> @@ -8236,7 +8236,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, >> #ifdef TARGET_NR_madvise >> case TARGET_NR_madvise: >> /* A straight passthrough may not be safe because qemu sometimes >> - turns private flie-backed mappings into anonymous mappings. >> + turns private file-backed mappings into anonymous mappings. >> This will break MADV_DONTNEED. >> This is a hint, so ignoring and returning success is ok. */ >> ret = get_errno(0); > Reviewed-by: Stefan Weil <sw@weilnetz.de> > PING?
20.05.2013 13:20, Lei Li wrote: > Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com> > --- > linux-user/syscall.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patch queue. /mjt
diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 30e93bc..72c6866 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -8236,7 +8236,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, #ifdef TARGET_NR_madvise case TARGET_NR_madvise: /* A straight passthrough may not be safe because qemu sometimes - turns private flie-backed mappings into anonymous mappings. + turns private file-backed mappings into anonymous mappings. This will break MADV_DONTNEED. This is a hint, so ignoring and returning success is ok. */ ret = get_errno(0);
Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com> --- linux-user/syscall.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)