diff mbox

[3/9] data: klog.json: Add checks for Intel Lynxpoint LPSS errors

Message ID 1368540031-28500-4-git-send-email-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King May 14, 2013, 2 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

Add some explaination for LPSS failures.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Keng-Yu Lin May 20, 2013, 8:25 a.m. UTC | #1
On Tue, May 14, 2013 at 10:00 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add some explaination for LPSS failures.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 552b030..38e2dba 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -77,6 +77,14 @@
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI",
> +    "pattern": "MMIO size insufficient to access LTR",
> +    "advice": "Intel Lynxpoint Low Power Subsystem have a set of MMIO mapped registers that provide access to the LTR (Latency Tolerance Reporting).  However, the MMIO size is smaller than expected. The corresponding I/O resource for this is incorrect, it should have a resource size set to a minimum of 24 bytes.",
> +    "label": "KlogAcpiLpssMmioSizeTooSmall"
> +  },
> +  {
> +    "compare_mode": "string",
> +    "log_level": "LOG_LEVEL_HIGH",
> +    "tag": "FWTS_TAG_ACPI",
>      "pattern": "Error installing notify handler",
>      "advice": "Failed to install a notify handler for the ACPI video driver. The ACPI video driver cannot handle notify events to change brightness levels or turn the display on/off.",
>      "label": "KlogAcpiNotifyHandlerInstallFailed"
> --
> 1.8.1.2
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung May 21, 2013, 6:08 a.m. UTC | #2
On 05/14/2013 10:00 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add some explaination for LPSS failures.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 552b030..38e2dba 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -77,6 +77,14 @@
>       "compare_mode": "string",
>       "log_level": "LOG_LEVEL_HIGH",
>       "tag": "FWTS_TAG_ACPI",
> +    "pattern": "MMIO size insufficient to access LTR",
> +    "advice": "Intel Lynxpoint Low Power Subsystem have a set of MMIO mapped registers that provide access to the LTR (Latency Tolerance Reporting).  However, the MMIO size is smaller than expected. The corresponding I/O resource for this is incorrect, it should have a resource size set to a minimum of 24 bytes.",
> +    "label": "KlogAcpiLpssMmioSizeTooSmall"
> +  },
> +  {
> +    "compare_mode": "string",
> +    "log_level": "LOG_LEVEL_HIGH",
> +    "tag": "FWTS_TAG_ACPI",
>       "pattern": "Error installing notify handler",
>       "advice": "Failed to install a notify handler for the ACPI video driver. The ACPI video driver cannot handle notify events to change brightness levels or turn the display on/off.",
>       "label": "KlogAcpiNotifyHandlerInstallFailed"
>
Acked-by: Alex Hung <alex.hung@canonical.com>
diff mbox

Patch

diff --git a/data/klog.json b/data/klog.json
index 552b030..38e2dba 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -77,6 +77,14 @@ 
     "compare_mode": "string",
     "log_level": "LOG_LEVEL_HIGH",
     "tag": "FWTS_TAG_ACPI",
+    "pattern": "MMIO size insufficient to access LTR",
+    "advice": "Intel Lynxpoint Low Power Subsystem have a set of MMIO mapped registers that provide access to the LTR (Latency Tolerance Reporting).  However, the MMIO size is smaller than expected. The corresponding I/O resource for this is incorrect, it should have a resource size set to a minimum of 24 bytes.",
+    "label": "KlogAcpiLpssMmioSizeTooSmall"
+  },
+  {
+    "compare_mode": "string",
+    "log_level": "LOG_LEVEL_HIGH",
+    "tag": "FWTS_TAG_ACPI",
     "pattern": "Error installing notify handler",
     "advice": "Failed to install a notify handler for the ACPI video driver. The ACPI video driver cannot handle notify events to change brightness levels or turn the display on/off.",
     "label": "KlogAcpiNotifyHandlerInstallFailed"