| Message ID | 1368452840.10208.2.camel@phoenix |
|---|---|
| State | Accepted |
| Headers | show |
Hello Axel, Am 13.05.2013 15:47, schrieb Axel Lin: > In the disable AIE irq code path, current code passes "1" to enable parameter of > rv3029c2_rtc_i2c_alarm_set_irq(). Thus it does not disable AIE irq. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > Hi Heiko, > I don't have the hardware to test, but current code looks obviously wrong. > I'd appreciate if you can review and test this patch. Sorry, I do not have such a hw anymore :-( > I think this patch should be also applied to stable trees. > Regards, > Axel > drivers/rtc/rtc-rv3029c2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-rv3029c2.c b/drivers/rtc/rtc-rv3029c2.c > index 5032c24..9100a34 100644 > --- a/drivers/rtc/rtc-rv3029c2.c > +++ b/drivers/rtc/rtc-rv3029c2.c > @@ -310,7 +310,7 @@ static int rv3029c2_rtc_i2c_set_alarm(struct i2c_client *client, > dev_dbg(&client->dev, "alarm IRQ armed\n"); > } else { > /* disable AIE irq */ > - ret = rv3029c2_rtc_i2c_alarm_set_irq(client, 1); > + ret = rv3029c2_rtc_i2c_alarm_set_irq(client, 0); > if (ret) > return ret; Yes, this seems wrong! Thanks for this fix! Acked-by: Heiko Schocher <hs@denx.de> bye, Heiko
diff --git a/drivers/rtc/rtc-rv3029c2.c b/drivers/rtc/rtc-rv3029c2.c index 5032c24..9100a34 100644 --- a/drivers/rtc/rtc-rv3029c2.c +++ b/drivers/rtc/rtc-rv3029c2.c @@ -310,7 +310,7 @@ static int rv3029c2_rtc_i2c_set_alarm(struct i2c_client *client, dev_dbg(&client->dev, "alarm IRQ armed\n"); } else { /* disable AIE irq */ - ret = rv3029c2_rtc_i2c_alarm_set_irq(client, 1); + ret = rv3029c2_rtc_i2c_alarm_set_irq(client, 0); if (ret) return ret;
In the disable AIE irq code path, current code passes "1" to enable parameter of rv3029c2_rtc_i2c_alarm_set_irq(). Thus it does not disable AIE irq. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- Hi Heiko, I don't have the hardware to test, but current code looks obviously wrong. I'd appreciate if you can review and test this patch. I think this patch should be also applied to stable trees. Regards, Axel drivers/rtc/rtc-rv3029c2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)