Message ID | 1368083537-32075-1-git-send-email-yamada.m@jp.panasonic.com |
---|---|
State | Changes Requested |
Delegated to: | Albert ARIBAUD |
Headers | show |
Dear Masahiro Yamada, On Thursday, May 9, 2013 9:12:17 AM, Masahiro Yamada wrote: > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> > --- > arch/arm/lib/crt0.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/lib/crt0.S b/arch/arm/lib/crt0.S > index a9657d1..58fcd03 100644 > --- a/arch/arm/lib/crt0.S > +++ b/arch/arm/lib/crt0.S > @@ -103,7 +103,7 @@ ENTRY(_main) > sub r8, r8, #GD_SIZE /* new GD is below bd */ > > adr lr, here > - ldr r0, [r8, #GD_RELOC_OFF] /* lr = gd->start_addr_sp */ > + ldr r0, [r8, #GD_RELOC_OFF] /* r0 = gd->reloc_off */ > add lr, lr, r0 > ldr r0, [r8, #GD_RELOCADDR] /* r0 = gd->relocaddr */ > b relocate_code > -- > 1.7.9.5 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > Correct. While you're at it, can you also fix the comment on line 100: "r8 = gd->start_addr_sp" -> "sp = gd->start_addr_sp" Thanks. Best regards, Benoît
> Correct. While you're at it, can you also fix the comment on line 100: > "r8 = gd->start_addr_sp" -> "sp = gd->start_addr_sp" Thanks Benoit. I modified my patch as suggested and posted it as v2. Best regards, Masahiro Yamada
diff --git a/arch/arm/lib/crt0.S b/arch/arm/lib/crt0.S index a9657d1..58fcd03 100644 --- a/arch/arm/lib/crt0.S +++ b/arch/arm/lib/crt0.S @@ -103,7 +103,7 @@ ENTRY(_main) sub r8, r8, #GD_SIZE /* new GD is below bd */ adr lr, here - ldr r0, [r8, #GD_RELOC_OFF] /* lr = gd->start_addr_sp */ + ldr r0, [r8, #GD_RELOC_OFF] /* r0 = gd->reloc_off */ add lr, lr, r0 ldr r0, [r8, #GD_RELOCADDR] /* r0 = gd->relocaddr */ b relocate_code
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> --- arch/arm/lib/crt0.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)