Message ID | 1367877219-17142-1-git-send-email-colin.king@canonical.com |
---|---|
State | Accepted |
Headers | show |
On 05/07/2013 05:53 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Coverity CID #997341, Resource leak. > > Need to free klog list before we return. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/lib/src/fwts_memorymap.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/lib/src/fwts_memorymap.c b/src/lib/src/fwts_memorymap.c > index 2988e5b..6e8bc1e 100644 > --- a/src/lib/src/fwts_memorymap.c > +++ b/src/lib/src/fwts_memorymap.c > @@ -233,8 +233,10 @@ fwts_list *fwts_memory_map_table_load_from_klog(fwts_framework *fw) > if ((klog = fwts_klog_read()) == NULL) > return NULL; > > - if ((memory_map_list = fwts_list_new()) == NULL) > + if ((memory_map_list = fwts_list_new()) == NULL) { > + fwts_klog_free(klog); > return NULL; > + } > > fwts_list_iterate(klog, fwts_memory_map_dmesg_info, memory_map_list); > fwts_klog_free(klog); > Acked-by: Alex Hung <alex.hung@canonical.com>
On 05/07/2013 05:53 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Coverity CID #997341, Resource leak. > > Need to free klog list before we return. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/lib/src/fwts_memorymap.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/lib/src/fwts_memorymap.c b/src/lib/src/fwts_memorymap.c > index 2988e5b..6e8bc1e 100644 > --- a/src/lib/src/fwts_memorymap.c > +++ b/src/lib/src/fwts_memorymap.c > @@ -233,8 +233,10 @@ fwts_list *fwts_memory_map_table_load_from_klog(fwts_framework *fw) > if ((klog = fwts_klog_read()) == NULL) > return NULL; > > - if ((memory_map_list = fwts_list_new()) == NULL) > + if ((memory_map_list = fwts_list_new()) == NULL) { > + fwts_klog_free(klog); > return NULL; > + } > > fwts_list_iterate(klog, fwts_memory_map_dmesg_info, memory_map_list); > fwts_klog_free(klog); > Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/lib/src/fwts_memorymap.c b/src/lib/src/fwts_memorymap.c index 2988e5b..6e8bc1e 100644 --- a/src/lib/src/fwts_memorymap.c +++ b/src/lib/src/fwts_memorymap.c @@ -233,8 +233,10 @@ fwts_list *fwts_memory_map_table_load_from_klog(fwts_framework *fw) if ((klog = fwts_klog_read()) == NULL) return NULL; - if ((memory_map_list = fwts_list_new()) == NULL) + if ((memory_map_list = fwts_list_new()) == NULL) { + fwts_klog_free(klog); return NULL; + } fwts_list_iterate(klog, fwts_memory_map_dmesg_info, memory_map_list); fwts_klog_free(klog);