| Message ID | 1367808836-28635-1-git-send-email-tiejun.chen@windriver.com |
|---|---|
| State | New, archived |
| Headers | show |
On 05/06/2013 04:53 AM, Tiejun Chen wrote: > Actually E500MC also support doorbell exception, and CONFIG_PPC_E500MC > can cover BOOK3E/BOOK3E_64 as well. > > Signed-off-by: Tiejun Chen<tiejun.chen@windriver.com> > --- > arch/powerpc/kvm/booke.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c > index 1020119..dc1f590 100644 > --- a/arch/powerpc/kvm/booke.c > +++ b/arch/powerpc/kvm/booke.c > @@ -795,7 +795,7 @@ static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu, > kvmppc_fill_pt_regs(®s); > timer_interrupt(®s); > break; > -#if defined(CONFIG_PPC_FSL_BOOK3E) || defined(CONFIG_PPC_BOOK3E_64) > +#if defined(CONFIG_PPC_E500MC) I suppose you mean CONFIG_KVM_E500MC here? Why didn't this work for you before? The ifdef above should cover the same range of CPUs. Alex -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/06/2013 10:58 PM, Alexander Graf wrote: > On 05/06/2013 04:53 AM, Tiejun Chen wrote: >> Actually E500MC also support doorbell exception, and CONFIG_PPC_E500MC >> can cover BOOK3E/BOOK3E_64 as well. >> >> Signed-off-by: Tiejun Chen<tiejun.chen@windriver.com> >> --- >> arch/powerpc/kvm/booke.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c >> index 1020119..dc1f590 100644 >> --- a/arch/powerpc/kvm/booke.c >> +++ b/arch/powerpc/kvm/booke.c >> @@ -795,7 +795,7 @@ static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu, >> kvmppc_fill_pt_regs(®s); >> timer_interrupt(®s); >> break; >> -#if defined(CONFIG_PPC_FSL_BOOK3E) || defined(CONFIG_PPC_BOOK3E_64) >> +#if defined(CONFIG_PPC_E500MC) > > I suppose you mean CONFIG_KVM_E500MC here? Why didn't this work for you before? This works for me. Here I just mean currently CONFIG_PPC_E500MC is always selected no matter what CONFIG_PPC_FSL_BOOK3E or CONFIG_PPC_BOOK3E_64 is enabled. And especially, this is already in the arch/powerpc/kvm/booke.c file, so I think one #ifdef (CONFIG_PPC_E500MC) is enough and also makes sense. > The ifdef above should cover the same range of CPUs. Or furthermore, the #ifdef CONFIG_PPC_DOORBELL is reasonable to cover this. Tiejun -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/07/2013 09:33 AM, tiejun.chen wrote: > On 05/06/2013 10:58 PM, Alexander Graf wrote: >> On 05/06/2013 04:53 AM, Tiejun Chen wrote: >>> Actually E500MC also support doorbell exception, and CONFIG_PPC_E500MC >>> can cover BOOK3E/BOOK3E_64 as well. >>> >>> Signed-off-by: Tiejun Chen<tiejun.chen@windriver.com> >>> --- >>> arch/powerpc/kvm/booke.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c >>> index 1020119..dc1f590 100644 >>> --- a/arch/powerpc/kvm/booke.c >>> +++ b/arch/powerpc/kvm/booke.c >>> @@ -795,7 +795,7 @@ static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu, >>> kvmppc_fill_pt_regs(®s); >>> timer_interrupt(®s); >>> break; >>> -#if defined(CONFIG_PPC_FSL_BOOK3E) || defined(CONFIG_PPC_BOOK3E_64) >>> +#if defined(CONFIG_PPC_E500MC) >> >> I suppose you mean CONFIG_KVM_E500MC here? Why didn't this work for you before? > > This works for me. > > Here I just mean currently CONFIG_PPC_E500MC is always selected no matter what > CONFIG_PPC_FSL_BOOK3E or CONFIG_PPC_BOOK3E_64 is enabled. And especially, this > is already in the arch/powerpc/kvm/booke.c file, so I think one #ifdef > (CONFIG_PPC_E500MC) is enough and also makes sense. > >> The ifdef above should cover the same range of CPUs. > > Or furthermore, the #ifdef CONFIG_PPC_DOORBELL is reasonable to cover this. > I think this may be better so I send next version with this. So please take a look at. Tiejun -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c index 1020119..dc1f590 100644 --- a/arch/powerpc/kvm/booke.c +++ b/arch/powerpc/kvm/booke.c @@ -795,7 +795,7 @@ static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu, kvmppc_fill_pt_regs(®s); timer_interrupt(®s); break; -#if defined(CONFIG_PPC_FSL_BOOK3E) || defined(CONFIG_PPC_BOOK3E_64) +#if defined(CONFIG_PPC_E500MC) case BOOKE_INTERRUPT_DOORBELL: kvmppc_fill_pt_regs(®s); doorbell_exception(®s);
Actually E500MC also support doorbell exception, and CONFIG_PPC_E500MC can cover BOOK3E/BOOK3E_64 as well. Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com> --- arch/powerpc/kvm/booke.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)