| Message ID | 1367823055.15842.23.camel@pasglop (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | d5dae721308ac5d5db03bf3aebaa15fcdcfb4862 |
| Headers | show |
On Mon, 2013-05-06 at 16:50 +1000, Benjamin Herrenschmidt wrote: > We are registering the attribute with permission 0600 but it > doesn't have a store callback, which causes WARN_ON's during > boot. Fix the permission. Ignore the 8/8 in the subject, that's just me not cleaning things up properly :-) Cheers, Ben. > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > --- > arch/powerpc/kernel/sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/sysfs.c b/arch/powerpc/kernel/sysfs.c > index 3ce1f86..e68a845 100644 > --- a/arch/powerpc/kernel/sysfs.c > +++ b/arch/powerpc/kernel/sysfs.c > @@ -180,7 +180,7 @@ SYSFS_PMCSETUP(dscr, SPRN_DSCR); > SYSFS_PMCSETUP(pir, SPRN_PIR); > > static DEVICE_ATTR(mmcra, 0600, show_mmcra, store_mmcra); > -static DEVICE_ATTR(spurr, 0600, show_spurr, NULL); > +static DEVICE_ATTR(spurr, 0400, show_spurr, NULL); > static DEVICE_ATTR(dscr, 0600, show_dscr, store_dscr); > static DEVICE_ATTR(purr, 0600, show_purr, store_purr); > static DEVICE_ATTR(pir, 0400, show_pir, NULL); > > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev
diff --git a/arch/powerpc/kernel/sysfs.c b/arch/powerpc/kernel/sysfs.c index 3ce1f86..e68a845 100644 --- a/arch/powerpc/kernel/sysfs.c +++ b/arch/powerpc/kernel/sysfs.c @@ -180,7 +180,7 @@ SYSFS_PMCSETUP(dscr, SPRN_DSCR); SYSFS_PMCSETUP(pir, SPRN_PIR); static DEVICE_ATTR(mmcra, 0600, show_mmcra, store_mmcra); -static DEVICE_ATTR(spurr, 0600, show_spurr, NULL); +static DEVICE_ATTR(spurr, 0400, show_spurr, NULL); static DEVICE_ATTR(dscr, 0600, show_dscr, store_dscr); static DEVICE_ATTR(purr, 0600, show_purr, store_purr); static DEVICE_ATTR(pir, 0400, show_pir, NULL);
We are registering the attribute with permission 0600 but it doesn't have a store callback, which causes WARN_ON's during boot. Fix the permission. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- arch/powerpc/kernel/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)