Message ID | 1367582973-20541-1-git-send-email-gustavo@zacarias.com.ar |
---|---|
State | Superseded |
Headers | show |
On 3 May 2013 13:09, Gustavo Zacarias <gustavo@zacarias.com.ar> wrote: > Add the jquery-keyboard package based on Simon Dawson's patch with a > newer version and improvements (license, select jquery, install > layouts). > > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > --- > package/Config.in | 1 + > package/jquery-keyboard/Config.in | 7 +++++++ > package/jquery-keyboard/jquery-keyboard.mk | 26 ++++++++++++++++++++++++++ > 3 files changed, 34 insertions(+) > create mode 100644 package/jquery-keyboard/Config.in > create mode 100644 package/jquery-keyboard/jquery-keyboard.mk > > diff --git a/package/Config.in b/package/Config.in > index cb1e8e1..14630a7 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -485,6 +485,7 @@ menu "Javascript" > source "package/explorercanvas/Config.in" > source "package/flot/Config.in" > source "package/jquery/Config.in" > +source "package/jquery-keyboard/Config.in" > source "package/jquery-sparkline/Config.in" > source "package/jquery-validation/Config.in" > source "package/jsmin/Config.in" > diff --git a/package/jquery-keyboard/Config.in b/package/jquery-keyboard/Config.in > new file mode 100644 > index 0000000..ee97662 > --- /dev/null > +++ b/package/jquery-keyboard/Config.in > @@ -0,0 +1,7 @@ > +config BR2_PACKAGE_JQUERY_KEYBOARD > + bool "jQuery keyboard" > + select BR2_PACKAGE_JQUERY > + help > + Virtual Keyboard using jQuery UI > + > + https://github.com/Mottie/Keyboard > diff --git a/package/jquery-keyboard/jquery-keyboard.mk b/package/jquery-keyboard/jquery-keyboard.mk > new file mode 100644 > index 0000000..81764ee > --- /dev/null > +++ b/package/jquery-keyboard/jquery-keyboard.mk > @@ -0,0 +1,26 @@ > +############################################################# > +# > +# jquery-keyboard > +# > +############################################################# > + > +JQUERY_KEYBOARD_VERSION = 1.17.4 > +JQUERY_KEYBOARD_SITE = \ > + http://github.com/Mottie/Keyboard/tarball/v$(JQUERY_KEYBOARD_VERSION) > +JQUERY_KEYBOARD_LICENSE = MIT WTFPL > +JQUERY_KEYBOARD_LICENSE_FILES = README.markdown > + > +define JQUERY_KEYBOARD_INSTALL_TARGET_CMDS > + $(INSTALL) -m 0755 -d $(TARGET_DIR)/var/www/css > + $(INSTALL) -m 0644 -D $(@D)/css/keyboard.css \ > + $(TARGET_DIR)/var/www/css/keyboard.css > + $(INSTALL) -m 0644 -D $(@D)/js/jquery.keyboard*.js \ > + $(TARGET_DIR)/var/www > + $(INSTALL) -m 0644 -D $(@D)/js/jquery.mousewheel.js \ > + $(TARGET_DIR)/var/www/jquery.mousewheel.js > + $(INSTALL) -m 0755 -d $(TARGET_DIR)/var/www/layouts > + $(INSTALL) -m 0644 -D $(@D)/layouts/*.js \ > + $(TARGET_DIR)/var/www/layouts > +endef > + > +$(eval $(call generic-package)) > -- > 1.8.1.5 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot Acked-by: Simon Dawson <spdawson@gmail.com>
On 03/05/13 14:09, Gustavo Zacarias wrote: > Add the jquery-keyboard package based on Simon Dawson's patch with a > newer version and improvements (license, select jquery, install > layouts). > > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> [snip] > diff --git a/package/jquery-keyboard/jquery-keyboard.mk b/package/jquery-keyboard/jquery-keyboard.mk > new file mode 100644 > index 0000000..81764ee > --- /dev/null > +++ b/package/jquery-keyboard/jquery-keyboard.mk > @@ -0,0 +1,26 @@ > +############################################################# > +# > +# jquery-keyboard > +# > +############################################################# > + > +JQUERY_KEYBOARD_VERSION = 1.17.4 > +JQUERY_KEYBOARD_SITE = \ > + http://github.com/Mottie/Keyboard/tarball/v$(JQUERY_KEYBOARD_VERSION) > +JQUERY_KEYBOARD_LICENSE = MIT WTFPL I prefer JQUERY_KEYBOARD_LICENSE = MIT (code), WTFPL (layouts) > +JQUERY_KEYBOARD_LICENSE_FILES = README.markdown That file does nothing more than refer to the websites with the license text... Not sure how to deal with that. > + > +define JQUERY_KEYBOARD_INSTALL_TARGET_CMDS > + $(INSTALL) -m 0755 -d $(TARGET_DIR)/var/www/css With the -D arguments below, the line above is redundant. > + $(INSTALL) -m 0644 -D $(@D)/css/keyboard.css \ > + $(TARGET_DIR)/var/www/css/keyboard.css > + $(INSTALL) -m 0644 -D $(@D)/js/jquery.keyboard*.js \ > + $(TARGET_DIR)/var/www > + $(INSTALL) -m 0644 -D $(@D)/js/jquery.mousewheel.js \ > + $(TARGET_DIR)/var/www/jquery.mousewheel.js > + $(INSTALL) -m 0755 -d $(TARGET_DIR)/var/www/layouts > + $(INSTALL) -m 0644 -D $(@D)/layouts/*.js \ > + $(TARGET_DIR)/var/www/layouts But why not just cp -r $(@D)/{css,js,layouts} $(TARGET_DIR)/var/www ? Regards, Arnout > +endef > + > +$(eval $(call generic-package)) >
On 05/03/2013 04:50 PM, Arnout Vandecappelle wrote: >> +JQUERY_KEYBOARD_LICENSE_FILES = README.markdown > > That file does nothing more than refer to the websites with the license > text... Not sure how to deal with that. I usually do it to avoid license-hunting, the details are stated there, i wouldn't consider it out of place to include it. Call it for lazy people who can't google "WTFPL", and it also details what's covered by each license and a little exception in line 70 of that file. >> + >> +define JQUERY_KEYBOARD_INSTALL_TARGET_CMDS >> + $(INSTALL) -m 0755 -d $(TARGET_DIR)/var/www/css > > With the -D arguments below, the line above is redundant. > Oops true, copy/paste overdone. >> + $(INSTALL) -m 0644 -D $(@D)/css/keyboard.css \ >> + $(TARGET_DIR)/var/www/css/keyboard.css >> + $(INSTALL) -m 0644 -D $(@D)/js/jquery.keyboard*.js \ >> + $(TARGET_DIR)/var/www >> + $(INSTALL) -m 0644 -D $(@D)/js/jquery.mousewheel.js \ >> + $(TARGET_DIR)/var/www/jquery.mousewheel.js >> + $(INSTALL) -m 0755 -d $(TARGET_DIR)/var/www/layouts >> + $(INSTALL) -m 0644 -D $(@D)/layouts/*.js \ >> + $(TARGET_DIR)/var/www/layouts > > But why not just cp -r $(@D)/{css,js,layouts} $(TARGET_DIR)/var/www ? I usually prefer to be quite explicit with dir/file modes. Regards.
diff --git a/package/Config.in b/package/Config.in index cb1e8e1..14630a7 100644 --- a/package/Config.in +++ b/package/Config.in @@ -485,6 +485,7 @@ menu "Javascript" source "package/explorercanvas/Config.in" source "package/flot/Config.in" source "package/jquery/Config.in" +source "package/jquery-keyboard/Config.in" source "package/jquery-sparkline/Config.in" source "package/jquery-validation/Config.in" source "package/jsmin/Config.in" diff --git a/package/jquery-keyboard/Config.in b/package/jquery-keyboard/Config.in new file mode 100644 index 0000000..ee97662 --- /dev/null +++ b/package/jquery-keyboard/Config.in @@ -0,0 +1,7 @@ +config BR2_PACKAGE_JQUERY_KEYBOARD + bool "jQuery keyboard" + select BR2_PACKAGE_JQUERY + help + Virtual Keyboard using jQuery UI + + https://github.com/Mottie/Keyboard diff --git a/package/jquery-keyboard/jquery-keyboard.mk b/package/jquery-keyboard/jquery-keyboard.mk new file mode 100644 index 0000000..81764ee --- /dev/null +++ b/package/jquery-keyboard/jquery-keyboard.mk @@ -0,0 +1,26 @@ +############################################################# +# +# jquery-keyboard +# +############################################################# + +JQUERY_KEYBOARD_VERSION = 1.17.4 +JQUERY_KEYBOARD_SITE = \ + http://github.com/Mottie/Keyboard/tarball/v$(JQUERY_KEYBOARD_VERSION) +JQUERY_KEYBOARD_LICENSE = MIT WTFPL +JQUERY_KEYBOARD_LICENSE_FILES = README.markdown + +define JQUERY_KEYBOARD_INSTALL_TARGET_CMDS + $(INSTALL) -m 0755 -d $(TARGET_DIR)/var/www/css + $(INSTALL) -m 0644 -D $(@D)/css/keyboard.css \ + $(TARGET_DIR)/var/www/css/keyboard.css + $(INSTALL) -m 0644 -D $(@D)/js/jquery.keyboard*.js \ + $(TARGET_DIR)/var/www + $(INSTALL) -m 0644 -D $(@D)/js/jquery.mousewheel.js \ + $(TARGET_DIR)/var/www/jquery.mousewheel.js + $(INSTALL) -m 0755 -d $(TARGET_DIR)/var/www/layouts + $(INSTALL) -m 0644 -D $(@D)/layouts/*.js \ + $(TARGET_DIR)/var/www/layouts +endef + +$(eval $(call generic-package))
Add the jquery-keyboard package based on Simon Dawson's patch with a newer version and improvements (license, select jquery, install layouts). Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> --- package/Config.in | 1 + package/jquery-keyboard/Config.in | 7 +++++++ package/jquery-keyboard/jquery-keyboard.mk | 26 ++++++++++++++++++++++++++ 3 files changed, 34 insertions(+) create mode 100644 package/jquery-keyboard/Config.in create mode 100644 package/jquery-keyboard/jquery-keyboard.mk