| Message ID | 1365474152-21524-1-git-send-email-dongsheng.wang@freescale.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 5ff04b7287d87c1db74f47360365905ed9a97ff7 |
| Delegated to: | Scott Wood |
| Headers | show |
Hi scott, Could you ACK these patches? [PATCH v3 2/4] powerpc/mpic: add global timer support [PATCH v3 3/4] powerpc/mpic: create mpic subsystem object [PATCH v3 4/4] powerpc/fsl: add MPIC timer wakeup support Thanks. > -----Original Message----- > From: Wang Dongsheng-B40534 > Sent: Tuesday, April 09, 2013 10:22 AM > To: Wood Scott-B07421 > Cc: linuxppc-dev@lists.ozlabs.org; Wang Dongsheng-B40534 > Subject: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > Add irq_set_wake support. Just add IRQF_NO_SUSPEND to desc->action->flag. > So the wake up interrupt will not be disable in suspend_device_irqs. > > Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com> > --- > v3: > * Modify: Change "EINVAL" to "ENXIO" in mpic_irq_set_wake() > > v2: > * Add: Check freescale chip in mpic_irq_set_wake(). > * Remove: Support mpic_irq_set_wake() in ht_chip. > > arch/powerpc/sysdev/mpic.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c > index 3b2efd4..ae709d2 100644 > --- a/arch/powerpc/sysdev/mpic.c > +++ b/arch/powerpc/sysdev/mpic.c > @@ -920,6 +920,22 @@ int mpic_set_irq_type(struct irq_data *d, unsigned > int flow_type) > return IRQ_SET_MASK_OK_NOCOPY; > } > > +static int mpic_irq_set_wake(struct irq_data *d, unsigned int on) { > + struct irq_desc *desc = container_of(d, struct irq_desc, irq_data); > + struct mpic *mpic = mpic_from_irq_data(d); > + > + if (!(mpic->flags & MPIC_FSL)) > + return -ENXIO; > + > + if (on) > + desc->action->flags |= IRQF_NO_SUSPEND; > + else > + desc->action->flags &= ~IRQF_NO_SUSPEND; > + > + return 0; > +} > + > void mpic_set_vector(unsigned int virq, unsigned int vector) { > struct mpic *mpic = mpic_from_irq(virq); @@ -957,6 +973,7 @@ static > struct irq_chip mpic_irq_chip = { > .irq_unmask = mpic_unmask_irq, > .irq_eoi = mpic_end_irq, > .irq_set_type = mpic_set_irq_type, > + .irq_set_wake = mpic_irq_set_wake, > }; > > #ifdef CONFIG_SMP > @@ -971,6 +988,7 @@ static struct irq_chip mpic_tm_chip = { > .irq_mask = mpic_mask_tm, > .irq_unmask = mpic_unmask_tm, > .irq_eoi = mpic_end_irq, > + .irq_set_wake = mpic_irq_set_wake, > }; > > #ifdef CONFIG_MPIC_U3_HT_IRQS > -- > 1.8.0
ACK -Scott On 04/16/2013 05:58:52 AM, Wang Dongsheng-B40534 wrote: > Hi scott, > > Could you ACK these patches? > > [PATCH v3 2/4] powerpc/mpic: add global timer support > [PATCH v3 3/4] powerpc/mpic: create mpic subsystem object > [PATCH v3 4/4] powerpc/fsl: add MPIC timer wakeup support > > Thanks. > > > -----Original Message----- > > From: Wang Dongsheng-B40534 > > Sent: Tuesday, April 09, 2013 10:22 AM > > To: Wood Scott-B07421 > > Cc: linuxppc-dev@lists.ozlabs.org; Wang Dongsheng-B40534 > > Subject: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > Add irq_set_wake support. Just add IRQF_NO_SUSPEND to > desc->action->flag. > > So the wake up interrupt will not be disable in suspend_device_irqs. > > > > Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com> > > --- > > v3: > > * Modify: Change "EINVAL" to "ENXIO" in mpic_irq_set_wake() > > > > v2: > > * Add: Check freescale chip in mpic_irq_set_wake(). > > * Remove: Support mpic_irq_set_wake() in ht_chip. > > > > arch/powerpc/sysdev/mpic.c | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c > > index 3b2efd4..ae709d2 100644 > > --- a/arch/powerpc/sysdev/mpic.c > > +++ b/arch/powerpc/sysdev/mpic.c > > @@ -920,6 +920,22 @@ int mpic_set_irq_type(struct irq_data *d, > unsigned > > int flow_type) > > return IRQ_SET_MASK_OK_NOCOPY; > > } > > > > +static int mpic_irq_set_wake(struct irq_data *d, unsigned int on) { > > + struct irq_desc *desc = container_of(d, struct irq_desc, > irq_data); > > + struct mpic *mpic = mpic_from_irq_data(d); > > + > > + if (!(mpic->flags & MPIC_FSL)) > > + return -ENXIO; > > + > > + if (on) > > + desc->action->flags |= IRQF_NO_SUSPEND; > > + else > > + desc->action->flags &= ~IRQF_NO_SUSPEND; > > + > > + return 0; > > +} > > + > > void mpic_set_vector(unsigned int virq, unsigned int vector) { > > struct mpic *mpic = mpic_from_irq(virq); @@ -957,6 +973,7 @@ > static > > struct irq_chip mpic_irq_chip = { > > .irq_unmask = mpic_unmask_irq, > > .irq_eoi = mpic_end_irq, > > .irq_set_type = mpic_set_irq_type, > > + .irq_set_wake = mpic_irq_set_wake, > > }; > > > > #ifdef CONFIG_SMP > > @@ -971,6 +988,7 @@ static struct irq_chip mpic_tm_chip = { > > .irq_mask = mpic_mask_tm, > > .irq_unmask = mpic_unmask_tm, > > .irq_eoi = mpic_end_irq, > > + .irq_set_wake = mpic_irq_set_wake, > > }; > > > > #ifdef CONFIG_MPIC_U3_HT_IRQS > > -- > > 1.8.0 > > >
Hi Kumar, Could you apply these patches? Thanks. [v3,1/4] powerpc/mpic: add irq_set_wake support http://patchwork.ozlabs.org/patch/234934/ [v3,2/4] powerpc/mpic: add global timer support http://patchwork.ozlabs.org/patch/234935/ [v3,3/4] powerpc/mpic: create mpic subsystem object http://patchwork.ozlabs.org/patch/234936/ [v3,4/4] powerpc/fsl: add MPIC timer wakeup support http://patchwork.ozlabs.org/patch/234937/ > -----Original Message----- > From: Wood Scott-B07421 > Sent: Wednesday, April 17, 2013 7:30 AM > To: Wang Dongsheng-B40534 > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > galak@kernel.crashing.org > Subject: Re: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > ACK > > -Scott > > On 04/16/2013 05:58:52 AM, Wang Dongsheng-B40534 wrote: > > Hi scott, > > > > Could you ACK these patches? > > > > [PATCH v3 2/4] powerpc/mpic: add global timer support > > [PATCH v3 3/4] powerpc/mpic: create mpic subsystem object > > [PATCH v3 4/4] powerpc/fsl: add MPIC timer wakeup support > > > > Thanks. > >
Hi Kumar, Could you apply these patches? Thanks. > -----Original Message----- > From: Wang Dongsheng-B40534 > Sent: Tuesday, April 23, 2013 6:10 PM > To: galak@kernel.crashing.org > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421 > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > Hi Kumar, > > Could you apply these patches? > > Thanks. > > [v3,1/4] powerpc/mpic: add irq_set_wake support > http://patchwork.ozlabs.org/patch/234934/ > > [v3,2/4] powerpc/mpic: add global timer support > http://patchwork.ozlabs.org/patch/234935/ > > [v3,3/4] powerpc/mpic: create mpic subsystem object > http://patchwork.ozlabs.org/patch/234936/ > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > http://patchwork.ozlabs.org/patch/234937/ > > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, April 17, 2013 7:30 AM > > To: Wang Dongsheng-B40534 > > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > > galak@kernel.crashing.org > > Subject: Re: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > ACK > > > > -Scott > > > > On 04/16/2013 05:58:52 AM, Wang Dongsheng-B40534 wrote: > > > Hi scott, > > > > > > Could you ACK these patches? > > > > > > [PATCH v3 2/4] powerpc/mpic: add global timer support [PATCH v3 3/4] > > > powerpc/mpic: create mpic subsystem object [PATCH v3 4/4] > > > powerpc/fsl: add MPIC timer wakeup support > > > > > > Thanks. > > >
Hi Benjamin, Could you apply these patches? Scott already ACK. [v3,1/4] powerpc/mpic: add irq_set_wake support http://patchwork.ozlabs.org/patch/234934/ [v3,2/4] powerpc/mpic: add global timer support http://patchwork.ozlabs.org/patch/234935/ [v3,3/4] powerpc/mpic: create mpic subsystem object http://patchwork.ozlabs.org/patch/234936/ [v3,4/4] powerpc/fsl: add MPIC timer wakeup support http://patchwork.ozlabs.org/patch/234937/ Thanks. > -----Original Message----- > From: Wang Dongsheng-B40534 > Sent: Friday, May 03, 2013 9:54 AM > To: 'galak@kernel.crashing.org' > Cc: 'linuxppc-dev@lists.ozlabs.org'; Wood Scott-B07421; > 'benh@kernel.crashing.org' > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > Hi Kumar, > > Could you apply these patches? > > Thanks. > > > -----Original Message----- > > From: Wang Dongsheng-B40534 > > Sent: Tuesday, April 23, 2013 6:10 PM > > To: galak@kernel.crashing.org > > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421 > > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > Hi Kumar, > > > > Could you apply these patches? > > > > Thanks. > > > > [v3,1/4] powerpc/mpic: add irq_set_wake support > > http://patchwork.ozlabs.org/patch/234934/ > > > > [v3,2/4] powerpc/mpic: add global timer support > > http://patchwork.ozlabs.org/patch/234935/ > > > > [v3,3/4] powerpc/mpic: create mpic subsystem object > > http://patchwork.ozlabs.org/patch/234936/ > > > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > > http://patchwork.ozlabs.org/patch/234937/ > > > > > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Wednesday, April 17, 2013 7:30 AM > > > To: Wang Dongsheng-B40534 > > > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > > > galak@kernel.crashing.org > > > Subject: Re: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > > > ACK > > > > > > -Scott > > > > > > On 04/16/2013 05:58:52 AM, Wang Dongsheng-B40534 wrote: > > > > Hi scott, > > > > > > > > Could you ACK these patches? > > > > > > > > [PATCH v3 2/4] powerpc/mpic: add global timer support [PATCH v3 > > > > 3/4] > > > > powerpc/mpic: create mpic subsystem object [PATCH v3 4/4] > > > > powerpc/fsl: add MPIC timer wakeup support > > > > > > > > Thanks. > > > >
On Mon, 2013-05-13 at 04:25 +0000, Wang Dongsheng-B40534 wrote: > Hi Benjamin, > > Could you apply these patches? I'll have a look, I was assuming Kumar would take them but since not I'll queue them up. Cheers, Ben. > Scott already ACK. > > [v3,1/4] powerpc/mpic: add irq_set_wake support > http://patchwork.ozlabs.org/patch/234934/ > > [v3,2/4] powerpc/mpic: add global timer support > http://patchwork.ozlabs.org/patch/234935/ > > [v3,3/4] powerpc/mpic: create mpic subsystem object > http://patchwork.ozlabs.org/patch/234936/ > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > http://patchwork.ozlabs.org/patch/234937/ > > Thanks. > > > -----Original Message----- > > From: Wang Dongsheng-B40534 > > Sent: Friday, May 03, 2013 9:54 AM > > To: 'galak@kernel.crashing.org' > > Cc: 'linuxppc-dev@lists.ozlabs.org'; Wood Scott-B07421; > > 'benh@kernel.crashing.org' > > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > Hi Kumar, > > > > Could you apply these patches? > > > > Thanks. > > > > > -----Original Message----- > > > From: Wang Dongsheng-B40534 > > > Sent: Tuesday, April 23, 2013 6:10 PM > > > To: galak@kernel.crashing.org > > > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421 > > > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > > > Hi Kumar, > > > > > > Could you apply these patches? > > > > > > Thanks. > > > > > > [v3,1/4] powerpc/mpic: add irq_set_wake support > > > http://patchwork.ozlabs.org/patch/234934/ > > > > > > [v3,2/4] powerpc/mpic: add global timer support > > > http://patchwork.ozlabs.org/patch/234935/ > > > > > > [v3,3/4] powerpc/mpic: create mpic subsystem object > > > http://patchwork.ozlabs.org/patch/234936/ > > > > > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > > > http://patchwork.ozlabs.org/patch/234937/ > > > > > > > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Wednesday, April 17, 2013 7:30 AM > > > > To: Wang Dongsheng-B40534 > > > > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > > > > galak@kernel.crashing.org > > > > Subject: Re: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > > > > > ACK > > > > > > > > -Scott > > > > > > > > On 04/16/2013 05:58:52 AM, Wang Dongsheng-B40534 wrote: > > > > > Hi scott, > > > > > > > > > > Could you ACK these patches? > > > > > > > > > > [PATCH v3 2/4] powerpc/mpic: add global timer support [PATCH v3 > > > > > 3/4] > > > > > powerpc/mpic: create mpic subsystem object [PATCH v3 4/4] > > > > > powerpc/fsl: add MPIC timer wakeup support > > > > > > > > > > Thanks. > > > > >
Thanks ben. :) - dongsheng. > -----Original Message----- > From: Benjamin Herrenschmidt [mailto:benh@kernel.crashing.org] > Sent: Monday, May 13, 2013 1:00 PM > To: Wang Dongsheng-B40534 > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; > galak@kernel.crashing.org > Subject: Re: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > On Mon, 2013-05-13 at 04:25 +0000, Wang Dongsheng-B40534 wrote: > > Hi Benjamin, > > > > Could you apply these patches? > > I'll have a look, I was assuming Kumar would take them but since not I'll > queue them up. > > Cheers, > Ben. > > > Scott already ACK. > > > > [v3,1/4] powerpc/mpic: add irq_set_wake support > > http://patchwork.ozlabs.org/patch/234934/ > > > > [v3,2/4] powerpc/mpic: add global timer support > > http://patchwork.ozlabs.org/patch/234935/ > > > > [v3,3/4] powerpc/mpic: create mpic subsystem object > > http://patchwork.ozlabs.org/patch/234936/ > > > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > > http://patchwork.ozlabs.org/patch/234937/ > > > > Thanks. > > > > > -----Original Message----- > > > From: Wang Dongsheng-B40534 > > > Sent: Friday, May 03, 2013 9:54 AM > > > To: 'galak@kernel.crashing.org' > > > Cc: 'linuxppc-dev@lists.ozlabs.org'; Wood Scott-B07421; > > > 'benh@kernel.crashing.org' > > > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > > > Hi Kumar, > > > > > > Could you apply these patches? > > > > > > Thanks. > > > > > > > -----Original Message----- > > > > From: Wang Dongsheng-B40534 > > > > Sent: Tuesday, April 23, 2013 6:10 PM > > > > To: galak@kernel.crashing.org > > > > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421 > > > > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > > > > > Hi Kumar, > > > > > > > > Could you apply these patches? > > > > > > > > Thanks. > > > > > > > > [v3,1/4] powerpc/mpic: add irq_set_wake support > > > > http://patchwork.ozlabs.org/patch/234934/ > > > > > > > > [v3,2/4] powerpc/mpic: add global timer support > > > > http://patchwork.ozlabs.org/patch/234935/ > > > > > > > > [v3,3/4] powerpc/mpic: create mpic subsystem object > > > > http://patchwork.ozlabs.org/patch/234936/ > > > > > > > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > > > > http://patchwork.ozlabs.org/patch/234937/ > > > > > > > > > > > > > -----Original Message----- > > > > > From: Wood Scott-B07421 > > > > > Sent: Wednesday, April 17, 2013 7:30 AM > > > > > To: Wang Dongsheng-B40534 > > > > > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > > > > > galak@kernel.crashing.org > > > > > Subject: Re: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake > > > > > support > > > > > > > > > > ACK > > > > > > > > > > -Scott > > > > > > > > > > On 04/16/2013 05:58:52 AM, Wang Dongsheng-B40534 wrote: > > > > > > Hi scott, > > > > > > > > > > > > Could you ACK these patches? > > > > > > > > > > > > [PATCH v3 2/4] powerpc/mpic: add global timer support [PATCH > > > > > > v3 3/4] > > > > > > powerpc/mpic: create mpic subsystem object [PATCH v3 4/4] > > > > > > powerpc/fsl: add MPIC timer wakeup support > > > > > > > > > > > > Thanks. > > > > > > > >
Hi ben, Could you apply these patches? Thanks. :) - dongsheng > -----Original Message----- > From: Benjamin Herrenschmidt [mailto:benh@kernel.crashing.org] > Sent: Monday, May 13, 2013 1:00 PM > To: Wang Dongsheng-B40534 > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; > galak@kernel.crashing.org > Subject: Re: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > On Mon, 2013-05-13 at 04:25 +0000, Wang Dongsheng-B40534 wrote: > > Hi Benjamin, > > > > Could you apply these patches? > > I'll have a look, I was assuming Kumar would take them but since not I'll > queue them up. > > Cheers, > Ben. > > > Scott already ACK. > > > > [v3,1/4] powerpc/mpic: add irq_set_wake support > > http://patchwork.ozlabs.org/patch/234934/ > > > > [v3,2/4] powerpc/mpic: add global timer support > > http://patchwork.ozlabs.org/patch/234935/ > > > > [v3,3/4] powerpc/mpic: create mpic subsystem object > > http://patchwork.ozlabs.org/patch/234936/ > > > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > > http://patchwork.ozlabs.org/patch/234937/ > > > > Thanks. > > > > > -----Original Message----- > > > From: Wang Dongsheng-B40534 > > > Sent: Friday, May 03, 2013 9:54 AM > > > To: 'galak@kernel.crashing.org' > > > Cc: 'linuxppc-dev@lists.ozlabs.org'; Wood Scott-B07421; > > > 'benh@kernel.crashing.org' > > > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > > > Hi Kumar, > > > > > > Could you apply these patches? > > > > > > Thanks. > > > > > > > -----Original Message----- > > > > From: Wang Dongsheng-B40534 > > > > Sent: Tuesday, April 23, 2013 6:10 PM > > > > To: galak@kernel.crashing.org > > > > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421 > > > > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > > > > > Hi Kumar, > > > > > > > > Could you apply these patches? > > > > > > > > Thanks. > > > > > > > > [v3,1/4] powerpc/mpic: add irq_set_wake support > > > > http://patchwork.ozlabs.org/patch/234934/ > > > > > > > > [v3,2/4] powerpc/mpic: add global timer support > > > > http://patchwork.ozlabs.org/patch/234935/ > > > > > > > > [v3,3/4] powerpc/mpic: create mpic subsystem object > > > > http://patchwork.ozlabs.org/patch/234936/ > > > > > > > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > > > > http://patchwork.ozlabs.org/patch/234937/ > > > > > > > > > > > > > -----Original Message----- > > > > > From: Wood Scott-B07421 > > > > > Sent: Wednesday, April 17, 2013 7:30 AM > > > > > To: Wang Dongsheng-B40534 > > > > > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > > > > > galak@kernel.crashing.org > > > > > Subject: Re: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake > > > > > support > > > > > > > > > > ACK > > > > > > > > > > -Scott > > > > > > > > > > On 04/16/2013 05:58:52 AM, Wang Dongsheng-B40534 wrote: > > > > > > Hi scott, > > > > > > > > > > > > Could you ACK these patches? > > > > > > > > > > > > [PATCH v3 2/4] powerpc/mpic: add global timer support [PATCH > > > > > > v3 3/4] > > > > > > powerpc/mpic: create mpic subsystem object [PATCH v3 4/4] > > > > > > powerpc/fsl: add MPIC timer wakeup support > > > > > > > > > > > > Thanks. > > > > > > > >
Hi Benjamin & Kumar & scott, I am not sure who can apply these patches... Scott already ACK these patches. A few days ago Scott have a pull request, Scott can accept them? Or ? [v3,1/4] powerpc/mpic: add irq_set_wake support http://patchwork.ozlabs.org/patch/234934/ [v3,2/4] powerpc/mpic: add global timer support http://patchwork.ozlabs.org/patch/234935/ [v3,3/4] powerpc/mpic: create mpic subsystem object http://patchwork.ozlabs.org/patch/234936 [v3,4/4] powerpc/fsl: add MPIC timer wakeup support http://patchwork.ozlabs.org/patch/234937/ Thanks. -dongsheng > -----Original Message----- > From: Wang Dongsheng-B40534 > Sent: Sunday, June 09, 2013 4:20 PM > To: 'Benjamin Herrenschmidt' > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; > galak@kernel.crashing.org > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > Hi ben, > > Could you apply these patches? Thanks. :) > > - dongsheng > > > -----Original Message----- > > From: Benjamin Herrenschmidt [mailto:benh@kernel.crashing.org] > > Sent: Monday, May 13, 2013 1:00 PM > > To: Wang Dongsheng-B40534 > > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; > > galak@kernel.crashing.org > > Subject: Re: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > On Mon, 2013-05-13 at 04:25 +0000, Wang Dongsheng-B40534 wrote: > > > Hi Benjamin, > > > > > > Could you apply these patches? > > > > I'll have a look, I was assuming Kumar would take them but since not > > I'll queue them up. > > > > Cheers, > > Ben. > > > > > Scott already ACK. > > > > > > [v3,1/4] powerpc/mpic: add irq_set_wake support > > > http://patchwork.ozlabs.org/patch/234934/ > > > > > > [v3,2/4] powerpc/mpic: add global timer support > > > http://patchwork.ozlabs.org/patch/234935/ > > > > > > [v3,3/4] powerpc/mpic: create mpic subsystem object > > > http://patchwork.ozlabs.org/patch/234936/ > > > > > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > > > http://patchwork.ozlabs.org/patch/234937/ > > > > > > Thanks. > > > > > > > -----Original Message----- > > > > From: Wang Dongsheng-B40534 > > > > Sent: Friday, May 03, 2013 9:54 AM > > > > To: 'galak@kernel.crashing.org' > > > > Cc: 'linuxppc-dev@lists.ozlabs.org'; Wood Scott-B07421; > > > > 'benh@kernel.crashing.org' > > > > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > > > > > Hi Kumar, > > > > > > > > Could you apply these patches? > > > > > > > > Thanks. > > > > > > > > > -----Original Message----- > > > > > From: Wang Dongsheng-B40534 > > > > > Sent: Tuesday, April 23, 2013 6:10 PM > > > > > To: galak@kernel.crashing.org > > > > > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421 > > > > > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake > > > > > support > > > > > > > > > > Hi Kumar, > > > > > > > > > > Could you apply these patches? > > > > > > > > > > Thanks. > > > > > > > > > > [v3,1/4] powerpc/mpic: add irq_set_wake support > > > > > http://patchwork.ozlabs.org/patch/234934/ > > > > > > > > > > [v3,2/4] powerpc/mpic: add global timer support > > > > > http://patchwork.ozlabs.org/patch/234935/ > > > > > > > > > > [v3,3/4] powerpc/mpic: create mpic subsystem object > > > > > http://patchwork.ozlabs.org/patch/234936/ > > > > > > > > > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > > > > > http://patchwork.ozlabs.org/patch/234937/ > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Wood Scott-B07421 > > > > > > Sent: Wednesday, April 17, 2013 7:30 AM > > > > > > To: Wang Dongsheng-B40534 > > > > > > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > > > > > > galak@kernel.crashing.org > > > > > > Subject: Re: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake > > > > > > support > > > > > > > > > > > > ACK > > > > > > > > > > > > -Scott > > > > > > > > > > > > On 04/16/2013 05:58:52 AM, Wang Dongsheng-B40534 wrote: > > > > > > > Hi scott, > > > > > > > > > > > > > > Could you ACK these patches? > > > > > > > > > > > > > > [PATCH v3 2/4] powerpc/mpic: add global timer support [PATCH > > > > > > > v3 3/4] > > > > > > > powerpc/mpic: create mpic subsystem object [PATCH v3 4/4] > > > > > > > powerpc/fsl: add MPIC timer wakeup support > > > > > > > > > > > > > > Thanks. > > > > > > > > > > >
On Mon, 2013-07-01 at 02:38 +0000, Wang Dongsheng-B40534 wrote: > Hi Benjamin & Kumar & scott, > > I am not sure who can apply these patches... > > Scott already ACK these patches. > > A few days ago Scott have a pull request, Scott can accept them? Or ? I'm happy to pull from Scott. Do somebody other than me has access to an old Mac (a G5 for example) to check they don't break anything there ? Ben. > [v3,1/4] powerpc/mpic: add irq_set_wake support > http://patchwork.ozlabs.org/patch/234934/ > > [v3,2/4] powerpc/mpic: add global timer support > http://patchwork.ozlabs.org/patch/234935/ > > [v3,3/4] powerpc/mpic: create mpic subsystem object > http://patchwork.ozlabs.org/patch/234936 > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > http://patchwork.ozlabs.org/patch/234937/ > > Thanks. > > -dongsheng > > > -----Original Message----- > > From: Wang Dongsheng-B40534 > > Sent: Sunday, June 09, 2013 4:20 PM > > To: 'Benjamin Herrenschmidt' > > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; > > galak@kernel.crashing.org > > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > Hi ben, > > > > Could you apply these patches? Thanks. :) > > > > - dongsheng > > > > > -----Original Message----- > > > From: Benjamin Herrenschmidt [mailto:benh@kernel.crashing.org] > > > Sent: Monday, May 13, 2013 1:00 PM > > > To: Wang Dongsheng-B40534 > > > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; > > > galak@kernel.crashing.org > > > Subject: Re: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > > > On Mon, 2013-05-13 at 04:25 +0000, Wang Dongsheng-B40534 wrote: > > > > Hi Benjamin, > > > > > > > > Could you apply these patches? > > > > > > I'll have a look, I was assuming Kumar would take them but since not > > > I'll queue them up. > > > > > > Cheers, > > > Ben. > > > > > > > Scott already ACK. > > > > > > > > [v3,1/4] powerpc/mpic: add irq_set_wake support > > > > http://patchwork.ozlabs.org/patch/234934/ > > > > > > > > [v3,2/4] powerpc/mpic: add global timer support > > > > http://patchwork.ozlabs.org/patch/234935/ > > > > > > > > [v3,3/4] powerpc/mpic: create mpic subsystem object > > > > http://patchwork.ozlabs.org/patch/234936/ > > > > > > > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > > > > http://patchwork.ozlabs.org/patch/234937/ > > > > > > > > Thanks. > > > > > > > > > -----Original Message----- > > > > > From: Wang Dongsheng-B40534 > > > > > Sent: Friday, May 03, 2013 9:54 AM > > > > > To: 'galak@kernel.crashing.org' > > > > > Cc: 'linuxppc-dev@lists.ozlabs.org'; Wood Scott-B07421; > > > > > 'benh@kernel.crashing.org' > > > > > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > > > > > > > Hi Kumar, > > > > > > > > > > Could you apply these patches? > > > > > > > > > > Thanks. > > > > > > > > > > > -----Original Message----- > > > > > > From: Wang Dongsheng-B40534 > > > > > > Sent: Tuesday, April 23, 2013 6:10 PM > > > > > > To: galak@kernel.crashing.org > > > > > > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421 > > > > > > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake > > > > > > support > > > > > > > > > > > > Hi Kumar, > > > > > > > > > > > > Could you apply these patches? > > > > > > > > > > > > Thanks. > > > > > > > > > > > > [v3,1/4] powerpc/mpic: add irq_set_wake support > > > > > > http://patchwork.ozlabs.org/patch/234934/ > > > > > > > > > > > > [v3,2/4] powerpc/mpic: add global timer support > > > > > > http://patchwork.ozlabs.org/patch/234935/ > > > > > > > > > > > > [v3,3/4] powerpc/mpic: create mpic subsystem object > > > > > > http://patchwork.ozlabs.org/patch/234936/ > > > > > > > > > > > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > > > > > > http://patchwork.ozlabs.org/patch/234937/ > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Wood Scott-B07421 > > > > > > > Sent: Wednesday, April 17, 2013 7:30 AM > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > > > > > > > galak@kernel.crashing.org > > > > > > > Subject: Re: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake > > > > > > > support > > > > > > > > > > > > > > ACK > > > > > > > > > > > > > > -Scott > > > > > > > > > > > > > > On 04/16/2013 05:58:52 AM, Wang Dongsheng-B40534 wrote: > > > > > > > > Hi scott, > > > > > > > > > > > > > > > > Could you ACK these patches? > > > > > > > > > > > > > > > > [PATCH v3 2/4] powerpc/mpic: add global timer support [PATCH > > > > > > > > v3 3/4] > > > > > > > > powerpc/mpic: create mpic subsystem object [PATCH v3 4/4] > > > > > > > > powerpc/fsl: add MPIC timer wakeup support > > > > > > > > > > > > > > > > Thanks. > > > > > > > > > > > > > > >
> -----Original Message----- > From: Benjamin Herrenschmidt [mailto:benh@kernel.crashing.org] > Sent: Monday, July 01, 2013 10:49 AM > To: Wang Dongsheng-B40534 > Cc: Wood Scott-B07421; galak@kernel.crashing.org; linuxppc- > dev@lists.ozlabs.org > Subject: Re: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > On Mon, 2013-07-01 at 02:38 +0000, Wang Dongsheng-B40534 wrote: > > Hi Benjamin & Kumar & scott, > > > > I am not sure who can apply these patches... > > > > Scott already ACK these patches. > > > > A few days ago Scott have a pull request, Scott can accept them? Or ? > > I'm happy to pull from Scott. Thanks Ben. -dongsheng >Do somebody other than me has access to an > old Mac (a G5 for example) to check they don't break anything there ? > > Ben. > > > [v3,1/4] powerpc/mpic: add irq_set_wake support > > http://patchwork.ozlabs.org/patch/234934/ > > > > [v3,2/4] powerpc/mpic: add global timer support > > http://patchwork.ozlabs.org/patch/234935/ > > > > [v3,3/4] powerpc/mpic: create mpic subsystem object > > http://patchwork.ozlabs.org/patch/234936 > > > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > > http://patchwork.ozlabs.org/patch/234937/ > > > > Thanks. > > > > -dongsheng > > > > > -----Original Message----- > > > From: Wang Dongsheng-B40534 > > > Sent: Sunday, June 09, 2013 4:20 PM > > > To: 'Benjamin Herrenschmidt' > > > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; > > > galak@kernel.crashing.org > > > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > > > Hi ben, > > > > > > Could you apply these patches? Thanks. :) > > > > > > - dongsheng > > > > > > > -----Original Message----- > > > > From: Benjamin Herrenschmidt [mailto:benh@kernel.crashing.org] > > > > Sent: Monday, May 13, 2013 1:00 PM > > > > To: Wang Dongsheng-B40534 > > > > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; > > > > galak@kernel.crashing.org > > > > Subject: Re: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake support > > > > > > > > On Mon, 2013-05-13 at 04:25 +0000, Wang Dongsheng-B40534 wrote: > > > > > Hi Benjamin, > > > > > > > > > > Could you apply these patches? > > > > > > > > I'll have a look, I was assuming Kumar would take them but since > not > > > > I'll queue them up. > > > > > > > > Cheers, > > > > Ben. > > > > > > > > > Scott already ACK. > > > > > > > > > > [v3,1/4] powerpc/mpic: add irq_set_wake support > > > > > http://patchwork.ozlabs.org/patch/234934/ > > > > > > > > > > [v3,2/4] powerpc/mpic: add global timer support > > > > > http://patchwork.ozlabs.org/patch/234935/ > > > > > > > > > > [v3,3/4] powerpc/mpic: create mpic subsystem object > > > > > http://patchwork.ozlabs.org/patch/234936/ > > > > > > > > > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > > > > > http://patchwork.ozlabs.org/patch/234937/ > > > > > > > > > > Thanks. > > > > > > > > > > > -----Original Message----- > > > > > > From: Wang Dongsheng-B40534 > > > > > > Sent: Friday, May 03, 2013 9:54 AM > > > > > > To: 'galak@kernel.crashing.org' > > > > > > Cc: 'linuxppc-dev@lists.ozlabs.org'; Wood Scott-B07421; > > > > > > 'benh@kernel.crashing.org' > > > > > > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake > support > > > > > > > > > > > > Hi Kumar, > > > > > > > > > > > > Could you apply these patches? > > > > > > > > > > > > Thanks. > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Wang Dongsheng-B40534 > > > > > > > Sent: Tuesday, April 23, 2013 6:10 PM > > > > > > > To: galak@kernel.crashing.org > > > > > > > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421 > > > > > > > Subject: RE: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake > > > > > > > support > > > > > > > > > > > > > > Hi Kumar, > > > > > > > > > > > > > > Could you apply these patches? > > > > > > > > > > > > > > Thanks. > > > > > > > > > > > > > > [v3,1/4] powerpc/mpic: add irq_set_wake support > > > > > > > http://patchwork.ozlabs.org/patch/234934/ > > > > > > > > > > > > > > [v3,2/4] powerpc/mpic: add global timer support > > > > > > > http://patchwork.ozlabs.org/patch/234935/ > > > > > > > > > > > > > > [v3,3/4] powerpc/mpic: create mpic subsystem object > > > > > > > http://patchwork.ozlabs.org/patch/234936/ > > > > > > > > > > > > > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > > > > > > > http://patchwork.ozlabs.org/patch/234937/ > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Wood Scott-B07421 > > > > > > > > Sent: Wednesday, April 17, 2013 7:30 AM > > > > > > > > To: Wang Dongsheng-B40534 > > > > > > > > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > > > > > > > > galak@kernel.crashing.org > > > > > > > > Subject: Re: [PATCH v3 1/4] powerpc/mpic: add irq_set_wake > > > > > > > > support > > > > > > > > > > > > > > > > ACK > > > > > > > > > > > > > > > > -Scott > > > > > > > > > > > > > > > > On 04/16/2013 05:58:52 AM, Wang Dongsheng-B40534 wrote: > > > > > > > > > Hi scott, > > > > > > > > > > > > > > > > > > Could you ACK these patches? > > > > > > > > > > > > > > > > > > [PATCH v3 2/4] powerpc/mpic: add global timer support > [PATCH > > > > > > > > > v3 3/4] > > > > > > > > > powerpc/mpic: create mpic subsystem object [PATCH v3 4/4] > > > > > > > > > powerpc/fsl: add MPIC timer wakeup support > > > > > > > > > > > > > > > > > > Thanks. > > > > > > > > > > > > > > > > > > > > >
On 06/30/2013 09:38:15 PM, Wang Dongsheng-B40534 wrote: > Hi Benjamin & Kumar & scott, > > I am not sure who can apply these patches... > > Scott already ACK these patches. > > A few days ago Scott have a pull request, Scott can accept them? Or ? > > [v3,1/4] powerpc/mpic: add irq_set_wake support > http://patchwork.ozlabs.org/patch/234934/ > > [v3,2/4] powerpc/mpic: add global timer support > http://patchwork.ozlabs.org/patch/234935/ > > [v3,3/4] powerpc/mpic: create mpic subsystem object > http://patchwork.ozlabs.org/patch/234936 > > [v3,4/4] powerpc/fsl: add MPIC timer wakeup support > http://patchwork.ozlabs.org/patch/234937/ I've been picking patches and hope to send a pull request soon. I already have these patches queued up as part of it. -Scott
On Mon, 2013-07-01 at 11:55 -0500, Scott Wood wrote: > I've been picking patches and hope to send a pull request soon. I > already have these patches queued up as part of it. Hurry ! Next time, I'd like the bulk of your stuff around -rc2 or 3 if possible, ie, keep feeding me rather than one big pull in the merge window. Thanks ! Cheers, Ben.
diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c index 3b2efd4..ae709d2 100644 --- a/arch/powerpc/sysdev/mpic.c +++ b/arch/powerpc/sysdev/mpic.c @@ -920,6 +920,22 @@ int mpic_set_irq_type(struct irq_data *d, unsigned int flow_type) return IRQ_SET_MASK_OK_NOCOPY; } +static int mpic_irq_set_wake(struct irq_data *d, unsigned int on) +{ + struct irq_desc *desc = container_of(d, struct irq_desc, irq_data); + struct mpic *mpic = mpic_from_irq_data(d); + + if (!(mpic->flags & MPIC_FSL)) + return -ENXIO; + + if (on) + desc->action->flags |= IRQF_NO_SUSPEND; + else + desc->action->flags &= ~IRQF_NO_SUSPEND; + + return 0; +} + void mpic_set_vector(unsigned int virq, unsigned int vector) { struct mpic *mpic = mpic_from_irq(virq); @@ -957,6 +973,7 @@ static struct irq_chip mpic_irq_chip = { .irq_unmask = mpic_unmask_irq, .irq_eoi = mpic_end_irq, .irq_set_type = mpic_set_irq_type, + .irq_set_wake = mpic_irq_set_wake, }; #ifdef CONFIG_SMP @@ -971,6 +988,7 @@ static struct irq_chip mpic_tm_chip = { .irq_mask = mpic_mask_tm, .irq_unmask = mpic_unmask_tm, .irq_eoi = mpic_end_irq, + .irq_set_wake = mpic_irq_set_wake, }; #ifdef CONFIG_MPIC_U3_HT_IRQS
Add irq_set_wake support. Just add IRQF_NO_SUSPEND to desc->action->flag. So the wake up interrupt will not be disable in suspend_device_irqs. Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com> --- v3: * Modify: Change "EINVAL" to "ENXIO" in mpic_irq_set_wake() v2: * Add: Check freescale chip in mpic_irq_set_wake(). * Remove: Support mpic_irq_set_wake() in ht_chip. arch/powerpc/sysdev/mpic.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)