| Message ID | 1367290790-19159-1-git-send-email-lig.fnst@cn.fujitsu.com |
|---|---|
| State | New |
| Headers | show |
On 30 April 2013 03:59, liguang <lig.fnst@cn.fujitsu.com> wrote: > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> > --- > translate-all.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/translate-all.c b/translate-all.c > index da93608..d04a116 100644 > --- a/translate-all.c > +++ b/translate-all.c > @@ -55,7 +55,6 @@ > #else > #include "exec/address-spaces.h" > #endif > -#include "qemu/timer.h" Nice catch -- this was a fix for a compile failure when compiling with profiling enabled, which got fixed once directly (commit 0aa09897) and once via a commit through the PPC tree (commit c8ff5daa0). This change fixes the double-include by effectively reverting the latter commit. thanks -- PMM
30.04.2013 06:59, liguang wrote: > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> > --- > translate-all.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Hmm. Does we require S-o-b line even for such a trivial (but nevertheless important) stuff? Also, Peter, does your followup email mean your Rewieved-by should be added too? Confused, /mjt > diff --git a/translate-all.c b/translate-all.c > index da93608..d04a116 100644 > --- a/translate-all.c > +++ b/translate-all.c > @@ -55,7 +55,6 @@ > #else > #include "exec/address-spaces.h" > #endif > -#include "qemu/timer.h" > > #include "exec/cputlb.h" > #include "translate-all.h" >
Am 01.05.2013 19:09, schrieb Michael Tokarev: > 30.04.2013 06:59, liguang wrote: >> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> >> --- >> translate-all.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) > > Hmm. Does we require S-o-b line even for such a trivial (but nevertheless important) stuff? Yes: http://wiki.qemu.org/Contribute/SubmitAPatch If it's missing, author can either reply with Signed-off-by - if you're willing to fix it up - or resend. And whenever you pick up patches, you sign them off as well. > Also, Peter, does your followup email mean your Rewieved-by should be added too? No, generally not if it was not explicitly given. Exception from the rule: We have allowed to turn an informal "ack" into an Acked-by. Thanks for taking over qemu-trivial! Andreas
On 1 May 2013 18:09, Michael Tokarev <mjt@tls.msk.ru> wrote: > Also, Peter, does your followup email mean your Rewieved-by > should be added too? As Andreas says, you don't add R-b: tags unless they were explicitly given. However in this case I think I just forgot to write it, so here you are: Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
30.04.2013 06:59, liguang wrote:
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
Thanks, applied to the trivial patches queue.
/mjt
diff --git a/translate-all.c b/translate-all.c index da93608..d04a116 100644 --- a/translate-all.c +++ b/translate-all.c @@ -55,7 +55,6 @@ #else #include "exec/address-spaces.h" #endif -#include "qemu/timer.h" #include "exec/cputlb.h" #include "translate-all.h"
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> --- translate-all.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)