Message ID | 1367000755-2571-1-git-send-email-haiyangz@microsoft.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Haiyang Zhang <haiyangz@microsoft.com> Date: Fri, 26 Apr 2013 11:25:55 -0700 > Fixed: warning: cast from pointer to integer of different size > > The Hyper-V hosts always use 64 bit request id. The guests can have 32 or 64 > bit pointers which equal to the ulong type size. So we cast it to ulong type. > And, assigning 32bit integer to 64 bit variable works fine. > > The VMBus returns the same id in the completion packet. But the value has no > effect on the host side. > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> > Reviewed-by: K. Y. Srinivasan <kys@microsoft.com> Applied, but: > - req_id = (u64)packet; > + req_id = (ulong)packet; I really do not like these shorthands for fundamental C types, we generally do not use "ulong", "uint" etc. Please expand them out explicitly to "unsigned long", "unsigned int", etc. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Monday, April 29, 2013 2:10 PM > To: Haiyang Zhang > Cc: netdev@vger.kernel.org; KY Srinivasan; olaf@aepfle.de; > jasowang@redhat.com; linux-kernel@vger.kernel.org; > devel@linuxdriverproject.org > Subject: Re: [PATCH net-next] hyperv: Fix a compiler warning in > netvsc_send() > > From: Haiyang Zhang <haiyangz@microsoft.com> > Date: Fri, 26 Apr 2013 11:25:55 -0700 > > > Fixed: warning: cast from pointer to integer of different size > > > > The Hyper-V hosts always use 64 bit request id. The guests can have 32 > > or 64 bit pointers which equal to the ulong type size. So we cast it to ulong > type. > > And, assigning 32bit integer to 64 bit variable works fine. > > > > The VMBus returns the same id in the completion packet. But the value > > has no effect on the host side. > > > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> > > Reviewed-by: K. Y. Srinivasan <kys@microsoft.com> > > Applied, but: > > > - req_id = (u64)packet; > > + req_id = (ulong)packet; > > I really do not like these shorthands for fundamental C types, we generally > do not use "ulong", "uint" etc. Please expand them out explicitly to > "unsigned long", "unsigned int", etc. Thanks for applying it. Going forward, I will use the long format, like "unsigned long", instead of "ulong", etc. Thanks, - Haiyang -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index f5f0f09..2b04804 100644 --- a/drivers/net/hyperv/netvsc.c +++ b/drivers/net/hyperv/netvsc.c @@ -522,7 +522,7 @@ int netvsc_send(struct hv_device *device, sendMessage.msg.v1_msg.send_rndis_pkt.send_buf_section_size = 0; if (packet->completion.send.send_completion) - req_id = (u64)packet; + req_id = (ulong)packet; else req_id = 0;