| Message ID | 5179DA23.8000407@asianux.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
于 2013/4/26 9:36, Chen Gang 写道: > On 2013年04月26日 09:18, Chen Gang wrote: >> On 2013年04月26日 09:06, Chen Gang wrote: >>>> CFAR is the Come From Register. It saves the location of the last >>>>> branch and is hence overwritten by any branch. >>>>> >>> Do we process it just like others done (e.g. 0x300, 0xe00, 0xe20 ...) ? >>> . = 0x900 >>> .globl decrementer_pSeries >>> decrementer_pSeries: >>> HMT_MEDIUM_PPR_DISCARD >>> SET_SCRATCH0(r13) >>> b decrementer_pSeries_0 >>> >>> ... >>> >>> > Oh, it seems EXCEPTION_PROLOG_1 will save the regesters which related > with CFAR, so I think need move EXCEPTION_PROLOG_1 to near 0x900. I will try your diff V2, to see if the machine can boot up > ---------------------------------diff v2 begin----------------------------- > > diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S > index e789ee7..f0489c4 100644 > --- a/arch/powerpc/kernel/exceptions-64s.S > +++ b/arch/powerpc/kernel/exceptions-64s.S > @@ -254,7 +254,15 @@ hardware_interrupt_hv: > STD_EXCEPTION_PSERIES(0x800, 0x800, fp_unavailable) > KVM_HANDLER_PR(PACA_EXGEN, EXC_STD, 0x800) > > - MASKABLE_EXCEPTION_PSERIES(0x900, 0x900, decrementer) > + . = 0x900 > + .globl decrementer_pSeries > +decrementer_pSeries: > + HMT_MEDIUM_PPR_DISCARD > + SET_SCRATCH0(r13) /* save r13 */ > + EXCEPTION_PROLOG_0(PACA_EXGEN) > + EXCEPTION_PROLOG_1(PACA_EXGEN, SOFTEN_TEST_PR, 0x900) > + b decrementer_pSeries_0 > + > STD_EXCEPTION_HV(0x980, 0x982, hdecrementer) > > MASKABLE_EXCEPTION_PSERIES(0xa00, 0xa00, doorbell_super) > @@ -536,6 +544,11 @@ ALT_FTR_SECTION_END_IFCLR(CPU_FTR_ARCH_206) > #endif > > .align 7 > + /* moved from 0x900 */ > +decrementer_pSeries_0: > + EXCEPTION_PROLOG_PSERIES_1(decrementer_common, EXC_STD) > + > + .align 7 > /* moved from 0xe00 */ > STD_EXCEPTION_HV_OOL(0xe02, h_data_storage) > KVM_HANDLER_SKIP(PACA_EXGEN, EXC_HV, 0xe02) > > > ---------------------------------diff v2 end------------------------------- > > >> Such as the fix below, is it OK (just like 0x300 or 0x200 has done) ? >> >> Please check, thanks. >> >> ---------------------------diff begin------------------------------------- >> >> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S >> index e789ee7..a0a5ff2 100644 >> --- a/arch/powerpc/kernel/exceptions-64s.S >> +++ b/arch/powerpc/kernel/exceptions-64s.S >> @@ -254,7 +254,14 @@ hardware_interrupt_hv: >> STD_EXCEPTION_PSERIES(0x800, 0x800, fp_unavailable) >> KVM_HANDLER_PR(PACA_EXGEN, EXC_STD, 0x800) >> >> - MASKABLE_EXCEPTION_PSERIES(0x900, 0x900, decrementer) >> + . = 0x900 >> + .globl decrementer_pSeries >> +decrementer_pSeries: >> + HMT_MEDIUM_PPR_DISCARD >> + SET_SCRATCH0(r13) /* save r13 */ >> + EXCEPTION_PROLOG_0(PACA_EXGEN) >> + b decrementer_pSeries_0 >> + >> STD_EXCEPTION_HV(0x980, 0x982, hdecrementer) >> >> MASKABLE_EXCEPTION_PSERIES(0xa00, 0xa00, doorbell_super) >> @@ -536,6 +543,12 @@ ALT_FTR_SECTION_END_IFCLR(CPU_FTR_ARCH_206) >> #endif >> >> .align 7 >> + /* moved from 0x900 */ >> +decrementer_pSeries_0: >> + EXCEPTION_PROLOG_1(PACA_EXGEN, SOFTEN_TEST_PR, 0x900) >> + EXCEPTION_PROLOG_PSERIES_1(decrementer_common, EXC_STD) >> + >> + .align 7 >> /* moved from 0xe00 */ >> STD_EXCEPTION_HV_OOL(0xe02, h_data_storage) >> KVM_HANDLER_SKIP(PACA_EXGEN, EXC_HV, 0xe02) >> >> ---------------------------diff end--------------------------------------- >> >
On 2013年04月26日 10:03, Mike Qiu wrote: > �� 2013/4/26 9:36, Chen Gang д��: >> > On 2013��04��26�� 09:18, Chen Gang wrote: >>> >> On 2013��04��26�� 09:06, Chen Gang wrote: >>>>> >>>> CFAR is the Come From Register. It saves the location of the last >>>>>> >>>>> branch and is hence overwritten by any branch. >>>>>> >>>>> >>>> >>> Do we process it just like others done (e.g. 0x300, 0xe00, 0xe20 ...) ? >>>> >>> . = 0x900 >>>> >>> .globl decrementer_pSeries >>>> >>> decrementer_pSeries: >>>> >>> HMT_MEDIUM_PPR_DISCARD >>>> >>> SET_SCRATCH0(r13) >>>> >>> b decrementer_pSeries_0 >>>> >>> >>>> >>> ... >>>> >>> >>>> >>> >> > Oh, it seems EXCEPTION_PROLOG_1 will save the regesters which related >> > with CFAR, so I think need move EXCEPTION_PROLOG_1 to near 0x900. > I will try your diff V2, to see if the machine can boot up OK, thanks. (hope it can work) :-)
于 2013/4/26 10:06, Chen Gang 写道: > On 2013年04月26日 10:03, Mike Qiu wrote: >> �� 2013/4/26 9:36, Chen Gang д��: >>>> On 2013��04��26�� 09:18, Chen Gang wrote: >>>>>> On 2013��04��26�� 09:06, Chen Gang wrote: >>>>>>>>>> CFAR is the Come From Register. It saves the location of the last >>>>>>>>>>>> branch and is hence overwritten by any branch. >>>>>>>>>>>> >>>>>>>> Do we process it just like others done (e.g. 0x300, 0xe00, 0xe20 ...) ? >>>>>>>> . = 0x900 >>>>>>>> .globl decrementer_pSeries >>>>>>>> decrementer_pSeries: >>>>>>>> HMT_MEDIUM_PPR_DISCARD >>>>>>>> SET_SCRATCH0(r13) >>>>>>>> b decrementer_pSeries_0 >>>>>>>> >>>>>>>> ... >>>>>>>> >>>>>>>> >>>> Oh, it seems EXCEPTION_PROLOG_1 will save the regesters which related >>>> with CFAR, so I think need move EXCEPTION_PROLOG_1 to near 0x900. >> I will try your diff V2, to see if the machine can boot up > OK, thanks. (hope it can work) It seems that the machine can be bootup in powernv mode, but I'm not sure if my machine call that module. At lease my machine can boot up Thanks Mike > > :-) >
On 2013年04月26日 11:08, Mike Qiu wrote: > 于 2013/4/26 10:06, Chen Gang 写道: >> On 2013年04月26日 10:03, Mike Qiu wrote: >>> �� 2013/4/26 9:36, Chen Gang д��: >>>>> On 2013��04��26�� 09:18, Chen Gang wrote: >>>>>>> On 2013��04��26�� 09:06, Chen Gang wrote: >>>>>>>>>>> CFAR is the Come From Register. It saves the location of the >>>>>>>>>>> last >>>>>>>>>>>>> branch and is hence overwritten by any branch. >>>>>>>>>>>>> >>>>>>>>> Do we process it just like others done (e.g. 0x300, 0xe00, >>>>>>>>> 0xe20 ...) ? >>>>>>>>> . = 0x900 >>>>>>>>> .globl decrementer_pSeries >>>>>>>>> decrementer_pSeries: >>>>>>>>> HMT_MEDIUM_PPR_DISCARD >>>>>>>>> SET_SCRATCH0(r13) >>>>>>>>> b decrementer_pSeries_0 >>>>>>>>> >>>>>>>>> ... >>>>>>>>> >>>>>>>>> >>>>> Oh, it seems EXCEPTION_PROLOG_1 will save the regesters which related >>>>> with CFAR, so I think need move EXCEPTION_PROLOG_1 to near 0x900. >>> I will try your diff V2, to see if the machine can boot up >> OK, thanks. (hope it can work) > It seems that the machine can be bootup in powernv mode, but I'm not > sure if my machine call that module. > > At lease my machine can boot up Thank you for your information ! I have checked the disassemble by powerpc64-linux-gnu-objdump, it seems all we have done for 0x900 is almost like the original done for 0x200. I am just learning about the CFAR (google it), And I plan to wait for a day, if all things go smoothly, I will send patch v3. :-)
On 2013年04月26日 11:25, Chen Gang wrote: > On 2013年04月26日 11:08, Mike Qiu wrote: >> 于 2013/4/26 10:06, Chen Gang 写道: >>> On 2013年04月26日 10:03, Mike Qiu wrote: >>>> �� 2013/4/26 9:36, Chen Gang д��: >>>>>> On 2013��04��26�� 09:18, Chen Gang wrote: >>>>>>>> On 2013��04��26�� 09:06, Chen Gang wrote: >>>>>>>>>>>> CFAR is the Come From Register. It saves the location of the >>>>>>>>>>>> last >>>>>>>>>>>>>> branch and is hence overwritten by any branch. >>>>>>>>>>>>>> >>>>>>>>>> Do we process it just like others done (e.g. 0x300, 0xe00, >>>>>>>>>> 0xe20 ...) ? >>>>>>>>>> . = 0x900 >>>>>>>>>> .globl decrementer_pSeries >>>>>>>>>> decrementer_pSeries: >>>>>>>>>> HMT_MEDIUM_PPR_DISCARD >>>>>>>>>> SET_SCRATCH0(r13) >>>>>>>>>> b decrementer_pSeries_0 >>>>>>>>>> >>>>>>>>>> ... >>>>>>>>>> >>>>>>>>>> >>>>>> Oh, it seems EXCEPTION_PROLOG_1 will save the regesters which related >>>>>> with CFAR, so I think need move EXCEPTION_PROLOG_1 to near 0x900. >>>> I will try your diff V2, to see if the machine can boot up >>> OK, thanks. (hope it can work) >> It seems that the machine can be bootup in powernv mode, but I'm not >> sure if my machine call that module. >> >> At lease my machine can boot up > Please reference commit number: 1707dd161349e6c54170c88d94fed012e3d224e3 (1707dd1 powerpc: Save CFAR before branching in interrupt entry paths) What our diff v2 has done is just the fix for our patch v2 (just like the commit 1707dd1 has done). Please check, thanks. :-) > Thank you for your information ! > > I have checked the disassemble by powerpc64-linux-gnu-objdump, it seems > all we have done for 0x900 is almost like the original done for 0x200. > > I am just learning about the CFAR (google it), And I plan to wait for a > day, if all things go smoothly, I will send patch v3. > > > :-) >
于 2013/4/26 11:42, Chen Gang 写道: > On 2013年04月26日 11:25, Chen Gang wrote: >> On 2013年04月26日 11:08, Mike Qiu wrote: >>> 于 2013/4/26 10:06, Chen Gang 写道: >>>> On 2013年04月26日 10:03, Mike Qiu wrote: >>>>> �� 2013/4/26 9:36, Chen Gang д��: >>>>>>> On 2013��04��26�� 09:18, Chen Gang wrote: >>>>>>>>> On 2013��04��26�� 09:06, Chen Gang wrote: >>>>>>>>>>>>> CFAR is the Come From Register. It saves the location of the >>>>>>>>>>>>> last >>>>>>>>>>>>>>> branch and is hence overwritten by any branch. >>>>>>>>>>>>>>> >>>>>>>>>>> Do we process it just like others done (e.g. 0x300, 0xe00, >>>>>>>>>>> 0xe20 ...) ? >>>>>>>>>>> . = 0x900 >>>>>>>>>>> .globl decrementer_pSeries >>>>>>>>>>> decrementer_pSeries: >>>>>>>>>>> HMT_MEDIUM_PPR_DISCARD >>>>>>>>>>> SET_SCRATCH0(r13) >>>>>>>>>>> b decrementer_pSeries_0 >>>>>>>>>>> >>>>>>>>>>> ... >>>>>>>>>>> >>>>>>>>>>> >>>>>>> Oh, it seems EXCEPTION_PROLOG_1 will save the regesters which related >>>>>>> with CFAR, so I think need move EXCEPTION_PROLOG_1 to near 0x900. >>>>> I will try your diff V2, to see if the machine can boot up >>>> OK, thanks. (hope it can work) >>> It seems that the machine can be bootup in powernv mode, but I'm not >>> sure if my machine call that module. >>> >>> At lease my machine can boot up > Please reference commit number: 1707dd161349e6c54170c88d94fed012e3d224e3 > (1707dd1 powerpc: Save CFAR before branching in interrupt entry paths) > > What our diff v2 has done is just the fix for our patch v2 (just like > the commit 1707dd1 has done). > > Please check, thanks. > > :-) I will check this evening or tomorrow, I have something else to do this afteroon. >> Thank you for your information ! >> >> I have checked the disassemble by powerpc64-linux-gnu-objdump, it seems >> all we have done for 0x900 is almost like the original done for 0x200. >> >> I am just learning about the CFAR (google it), And I plan to wait for a >> day, if all things go smoothly, I will send patch v3. >> >> >> :-) >> >
On 2013年04月26日 11:54, Mike Qiu wrote: > 于 2013/4/26 11:42, Chen Gang 写道: >> On 2013年04月26日 11:25, Chen Gang wrote: >>> On 2013年04月26日 11:08, Mike Qiu wrote: >>>> 于 2013/4/26 10:06, Chen Gang 写道: >>>>> On 2013年04月26日 10:03, Mike Qiu wrote: >>>>>> �� 2013/4/26 9:36, Chen Gang д��: >>>>>>>> On 2013��04��26�� 09:18, Chen Gang wrote: >>>>>>>>>> On 2013��04��26�� 09:06, Chen Gang wrote: >>>>>>>>>>>>>> CFAR is the Come From Register. It saves the location of the >>>>>>>>>>>>>> last >>>>>>>>>>>>>>>> branch and is hence overwritten by any branch. >>>>>>>>>>>>>>>> >>>>>>>>>>>> Do we process it just like others done (e.g. 0x300, 0xe00, >>>>>>>>>>>> 0xe20 ...) ? >>>>>>>>>>>> . = 0x900 >>>>>>>>>>>> .globl decrementer_pSeries >>>>>>>>>>>> decrementer_pSeries: >>>>>>>>>>>> HMT_MEDIUM_PPR_DISCARD >>>>>>>>>>>> SET_SCRATCH0(r13) >>>>>>>>>>>> b decrementer_pSeries_0 >>>>>>>>>>>> >>>>>>>>>>>> ... >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>> Oh, it seems EXCEPTION_PROLOG_1 will save the regesters which >>>>>>>> related >>>>>>>> with CFAR, so I think need move EXCEPTION_PROLOG_1 to near 0x900. >>>>>> I will try your diff V2, to see if the machine can boot up >>>>> OK, thanks. (hope it can work) >>>> It seems that the machine can be bootup in powernv mode, but I'm not >>>> sure if my machine call that module. >>>> >>>> At lease my machine can boot up >> Please reference commit number: 1707dd161349e6c54170c88d94fed012e3d224e3 >> (1707dd1 powerpc: Save CFAR before branching in interrupt entry paths) >> >> What our diff v2 has done is just the fix for our patch v2 (just like >> the commit 1707dd1 has done). >> >> Please check, thanks. >> >> :-) > I will check this evening or tomorrow, I have something else to do this > afteroon. I think the diff v2 is correct, but is not the best one for this issue. I prefer the Paul's patch for this issue which has better performance :-) Thanks.
于 2013/4/27 17:28, Chen Gang F T 写道: > On 2013年04月26日 11:54, Mike Qiu wrote: >> 于 2013/4/26 11:42, Chen Gang 写道: >>> On 2013年04月26日 11:25, Chen Gang wrote: >>>> On 2013年04月26日 11:08, Mike Qiu wrote: >>>>> 于 2013/4/26 10:06, Chen Gang 写道: >>>>>> On 2013年04月26日 10:03, Mike Qiu wrote: >>>>>>> �� 2013/4/26 9:36, Chen Gang д��: >>>>>>>>> On 2013��04��26�� 09:18, Chen Gang wrote: >>>>>>>>>>> On 2013��04��26�� 09:06, Chen Gang wrote: >>>>>>>>>>>>>>> CFAR is the Come From Register. It saves the location of the >>>>>>>>>>>>>>> last >>>>>>>>>>>>>>>>> branch and is hence overwritten by any branch. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>> Do we process it just like others done (e.g. 0x300, 0xe00, >>>>>>>>>>>>> 0xe20 ...) ? >>>>>>>>>>>>> . = 0x900 >>>>>>>>>>>>> .globl decrementer_pSeries >>>>>>>>>>>>> decrementer_pSeries: >>>>>>>>>>>>> HMT_MEDIUM_PPR_DISCARD >>>>>>>>>>>>> SET_SCRATCH0(r13) >>>>>>>>>>>>> b decrementer_pSeries_0 >>>>>>>>>>>>> >>>>>>>>>>>>> ... >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>> Oh, it seems EXCEPTION_PROLOG_1 will save the regesters which >>>>>>>>> related >>>>>>>>> with CFAR, so I think need move EXCEPTION_PROLOG_1 to near 0x900. >>>>>>> I will try your diff V2, to see if the machine can boot up >>>>>> OK, thanks. (hope it can work) >>>>> It seems that the machine can be bootup in powernv mode, but I'm not >>>>> sure if my machine call that module. >>>>> >>>>> At lease my machine can boot up >>> Please reference commit number: 1707dd161349e6c54170c88d94fed012e3d224e3 >>> (1707dd1 powerpc: Save CFAR before branching in interrupt entry paths) >>> >>> What our diff v2 has done is just the fix for our patch v2 (just like >>> the commit 1707dd1 has done). >>> >>> Please check, thanks. >>> >>> :-) >> I will check this evening or tomorrow, I have something else to do this >> afteroon. > I think the diff v2 is correct, but is not the best one for this issue. > > I prefer the Paul's patch for this issue which has better performance > > :-) yes, I use your patch and it can work, also Paul's patch can work too. > > Thanks. >
On 2013年04月27日 17:32, Mike Qiu wrote: >>> >> I think the diff v2 is correct, but is not the best one for this issue. >> >> I prefer the Paul's patch for this issue which has better performance >> >> :-) > yes, I use your patch and it can work, also Paul's patch can work too. Good news. Bye ! :-)
diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S index e789ee7..f0489c4 100644 --- a/arch/powerpc/kernel/exceptions-64s.S +++ b/arch/powerpc/kernel/exceptions-64s.S @@ -254,7 +254,15 @@ hardware_interrupt_hv: STD_EXCEPTION_PSERIES(0x800, 0x800, fp_unavailable) KVM_HANDLER_PR(PACA_EXGEN, EXC_STD, 0x800) - MASKABLE_EXCEPTION_PSERIES(0x900, 0x900, decrementer) + . = 0x900 + .globl decrementer_pSeries +decrementer_pSeries: + HMT_MEDIUM_PPR_DISCARD + SET_SCRATCH0(r13) /* save r13 */ + EXCEPTION_PROLOG_0(PACA_EXGEN) + EXCEPTION_PROLOG_1(PACA_EXGEN, SOFTEN_TEST_PR, 0x900) + b decrementer_pSeries_0 + STD_EXCEPTION_HV(0x980, 0x982, hdecrementer) MASKABLE_EXCEPTION_PSERIES(0xa00, 0xa00, doorbell_super) @@ -536,6 +544,11 @@ ALT_FTR_SECTION_END_IFCLR(CPU_FTR_ARCH_206) #endif .align 7 + /* moved from 0x900 */ +decrementer_pSeries_0: + EXCEPTION_PROLOG_PSERIES_1(decrementer_common, EXC_STD) + + .align 7 /* moved from 0xe00 */ STD_EXCEPTION_HV_OOL(0xe02, h_data_storage) KVM_HANDLER_SKIP(PACA_EXGEN, EXC_HV, 0xe02)