| Message ID | 51762E16.703@asianux.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, Apr 22, 2013 at 11:45 PM, Chen Gang <gang.chen@asianux.com> wrote: > > Need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W, > the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5 > ("GRE: Refactor GRE tunneling code") > > > Signed-off-by: Chen Gang <gang.chen@asianux.com> Thanks for fixing it. Acked-by: Pravin B Shelar <pshelar@nicira.com> > --- > net/ipv4/ip_gre.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c > index 987a4e5..c625e4d 100644 > --- a/net/ipv4/ip_gre.c > +++ b/net/ipv4/ip_gre.c > @@ -444,7 +444,7 @@ static netdev_tx_t ipgre_xmit(struct sk_buff *skb, > if (dev->header_ops) { > /* Need space for new headers */ > if (skb_cow_head(skb, dev->needed_headroom - > - (tunnel->hlen + sizeof(struct iphdr)))); > + (tunnel->hlen + sizeof(struct iphdr)))) > goto free_skb; > > tnl_params = (const struct iphdr *)skb->data; > -- > 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2013年04月25日 02:09, Pravin Shelar wrote: > On Mon, Apr 22, 2013 at 11:45 PM, Chen Gang <gang.chen@asianux.com> wrote: >> > >> > Need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W, >> > the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5 >> > ("GRE: Refactor GRE tunneling code") >> > >> > >> > Signed-off-by: Chen Gang <gang.chen@asianux.com> > Thanks for fixing it. > > Acked-by: Pravin B Shelar <pshelar@nicira.com> > Thanks, too.
From: Chen Gang <gang.chen@asianux.com> Date: Tue, 23 Apr 2013 14:45:42 +0800 > Need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W, > the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5 > ("GRE: Refactor GRE tunneling code") > > Signed-off-by: Chen Gang <gang.chen@asianux.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2013年04月25日 16:08, David Miller wrote: > From: Chen Gang <gang.chen@asianux.com> > Date: Tue, 23 Apr 2013 14:45:42 +0800 > >> > Need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W, >> > the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5 >> > ("GRE: Refactor GRE tunneling code") >> > >> > Signed-off-by: Chen Gang <gang.chen@asianux.com> > Applied. > > Thanks.
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c index 987a4e5..c625e4d 100644 --- a/net/ipv4/ip_gre.c +++ b/net/ipv4/ip_gre.c @@ -444,7 +444,7 @@ static netdev_tx_t ipgre_xmit(struct sk_buff *skb, if (dev->header_ops) { /* Need space for new headers */ if (skb_cow_head(skb, dev->needed_headroom - - (tunnel->hlen + sizeof(struct iphdr)))); + (tunnel->hlen + sizeof(struct iphdr)))) goto free_skb; tnl_params = (const struct iphdr *)skb->data;
Need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W, the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5 ("GRE: Refactor GRE tunneling code") Signed-off-by: Chen Gang <gang.chen@asianux.com> --- net/ipv4/ip_gre.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)