Message ID | 1365498867-27782-8-git-send-email-lczerner@redhat.com |
---|---|
State | Superseded, archived |
Headers | show |
On Tue, Apr 09, 2013 at 11:14:16AM +0200, Lukas Czerner wrote: > ->invalidatepage() aop now accepts range to invalidate so we can make > use of it in ceph_invalidatepage(). > > Signed-off-by: Lukas Czerner <lczerner@redhat.com> > Cc: ceph-devel@vger.kernel.org To ceph-devel, Since half of this patch series modifies ext4 extensively, and changes to the other file systems are relatively small, I plan to carry the invalidatepage patch set in the ext4 tree for the next development cycle (i.e., not the upcoming merge window, but the next one). To that end, it would be great if you take a look at this patch set and send us an Acked-by signoff. Thanks!! - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 9 Apr 2013, Lukas Czerner wrote: > ->invalidatepage() aop now accepts range to invalidate so we can make > use of it in ceph_invalidatepage(). > > Signed-off-by: Lukas Czerner <lczerner@redhat.com> > Cc: ceph-devel@vger.kernel.org Acked-by: Sage Weil <sage@inktank.com> > --- > fs/ceph/addr.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > index 168a35a..d953afd 100644 > --- a/fs/ceph/addr.c > +++ b/fs/ceph/addr.c > @@ -164,20 +164,20 @@ static void ceph_invalidatepage(struct page *page, unsigned int offset, > if (!PageDirty(page)) > pr_err("%p invalidatepage %p page not dirty\n", inode, page); > > - if (offset == 0) > + if (offset == 0 && length == PAGE_CACHE_SIZE) > ClearPageChecked(page); > > ci = ceph_inode(inode); > - if (offset == 0) { > - dout("%p invalidatepage %p idx %lu full dirty page %u\n", > - inode, page, page->index, offset); > + if (offset == 0 && length == PAGE_CACHE_SIZE) { > + dout("%p invalidatepage %p idx %lu full dirty page\n", > + inode, page, page->index); > ceph_put_wrbuffer_cap_refs(ci, 1, snapc); > ceph_put_snap_context(snapc); > page->private = 0; > ClearPagePrivate(page); > } else { > - dout("%p invalidatepage %p idx %lu partial dirty page\n", > - inode, page, page->index); > + dout("%p invalidatepage %p idx %lu partial dirty page %u(%u)\n", > + inode, page, page->index, offset, length); > } > } > > -- > 1.7.7.6 > > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 168a35a..d953afd 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -164,20 +164,20 @@ static void ceph_invalidatepage(struct page *page, unsigned int offset, if (!PageDirty(page)) pr_err("%p invalidatepage %p page not dirty\n", inode, page); - if (offset == 0) + if (offset == 0 && length == PAGE_CACHE_SIZE) ClearPageChecked(page); ci = ceph_inode(inode); - if (offset == 0) { - dout("%p invalidatepage %p idx %lu full dirty page %u\n", - inode, page, page->index, offset); + if (offset == 0 && length == PAGE_CACHE_SIZE) { + dout("%p invalidatepage %p idx %lu full dirty page\n", + inode, page, page->index); ceph_put_wrbuffer_cap_refs(ci, 1, snapc); ceph_put_snap_context(snapc); page->private = 0; ClearPagePrivate(page); } else { - dout("%p invalidatepage %p idx %lu partial dirty page\n", - inode, page, page->index); + dout("%p invalidatepage %p idx %lu partial dirty page %u(%u)\n", + inode, page, page->index, offset, length); } }
->invalidatepage() aop now accepts range to invalidate so we can make use of it in ceph_invalidatepage(). Signed-off-by: Lukas Czerner <lczerner@redhat.com> Cc: ceph-devel@vger.kernel.org --- fs/ceph/addr.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)